You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/09 01:23:53 UTC
[GitHub] [tvm] ccjoechou opened a new pull request #9235: [bug] pooling convert layout bug in pooling.cc and in test_pass_conve…
ccjoechou opened a new pull request #9235:
URL: https://github.com/apache/tvm/pull/9235
…rt_op_layout.py
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ccjoechou commented on pull request #9235: [Op] Do not override specified layout in pooling
Posted by GitBox <gi...@apache.org>.
ccjoechou commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-946314894
I did.
Please look at the other one (out of working), which is at the bottom and it shows: Merge branch 'working' of<https://github.com/apache/tvm/pull/9235/commits/5e77c54c868ff6fef00a2bb53face303f76de8b1> https://github.com/ccjoechou/tvm into working<https://github.com/apache/tvm/pull/9235/commits/5e77c54c868ff6fef00a2bb53face303f76de8b1>.
It failed Jenkins build because it was using a new lint command (comparing to what’s been listed in this file: tvm/docs/contribut/pull_request.rst<https://sj1git1.cavium.com/plugins/gitblit/blob/?r=IP/SW/ML/cdk/tvm.git&f=docs/contribute/pull_request.rst&h=tvm-v0.8.0-08172021-devel> ==> docker/lint.sh
vs what is used now by Apache TVM Jenkins build: docker/bash.sh tlcpack/ci-lint:v0.67 ./tests/scripts/task_lint.sh
The old one does not do check on py files but the new command does.
I am fixing format for two py files, which I modified (including old and existing APIs and statements).
Thanks,
* Joe
From: Cody Yu ***@***.***>
Sent: Monday, October 18, 2021 7:22 PM
To: apache/tvm ***@***.***>
Cc: Joe Chou ***@***.***>; Author ***@***.***>
Subject: [EXT] Re: [apache/tvm] [Op] Do not override specified layout in pooling (#9235)
External Email
________________________________
Ah please rebase against to the latest commit. This PR shouldn't have 9k changes...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_tvm_pull_9235-23issuecomment-2D946311616&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=3oIC9-8ssjUbY7yhqmJNcNDFnGecI_Qzw2A0KvCn0ZQ&s=cG5_VvMBF_TzGoa2PeLmW5cNWtOEigEBD2P5VoLXwdw&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AM636PEAYVIBJLFIU4JGXO3UHTI3VANCNFSM5FUWAG4A&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=3oIC9-8ssjUbY7yhqmJNcNDFnGecI_Qzw2A0KvCn0ZQ&s=6FDyJAs7u7xCI56GaZ2ZTqdGZ6BIiFGFA8gvmsYpQA0&e=>.
Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=3oIC9-8ssjUbY7yhqmJNcNDFnGecI_Qzw2A0KvCn0ZQ&s=Cl5lOZWPoaIoW5Ebqh64PIMLE_a1kx10pkVUBCm269Q&e=> or Android<https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=3oIC9-8ssjUbY7yhqmJNcNDFnGecI_Qzw2A0KvCn0ZQ&s=1lLeL_Zoj_tIj3AWA1KxuD7FnCTEXidWHeBxj7KrAKg&e=>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ccjoechou edited a comment on pull request #9235: [bug] pooling convert layout bug in pooling.cc and in test_pass_conve… (see also issue #8848)
Posted by GitBox <gi...@apache.org>.
ccjoechou edited a comment on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-943494906
Hi Wuwei, (or any other who can help?)
I have spent lots time on this pooling issue, which I believe it is a fundamental-concept-related issue.
Similar to what we have implemented for the ConvInferCorrectLayout() function in the tvm/src/relay/op/nn/convention.h file – for instance, it keeps the conv op’s layouts, if they are provided.
Let me use the nn.max_pool2d op as an example.
If in a given (input) IR graph, it is “explicitly” described that a nn.max_pool2d op needs to use the layout == “NHWC”.
* E.g.: y = relay.nn.max_pool2d(y, pool_size=(2, 2), layout="NHWC")
Plus, there is either:
* Either, “no” transforms.ConvertLayout() is given with a desired layout for nn.max_pool2d op, or
* A transforms.ConvertLayout() is given with a desired layout for "nn.max_pool2d": ["NHWC"] – i.e., to tell TVM.relay that the nn.max_pool2d op must stick with its “NHWC” data layout format (for input and for output)
In the above conditions, shouldn’t TVM.relay keep the nn.max_pool2d op’s input, data, output layouts as “NHWC”?
That is when nn.max_pool2d op’s param->layout != “” (assuming it is a legal layout format), we should use:
* InferCorrectLayoutOutput({use the original, given params->layout}, {use the original, given params->layout}, Attrs(params))
If this fundamental concept stands, then, the PR-#9235’s change to pooling.cc file should be (kind of) correct !
If you are in agreement with this fundamental concept, then, I can make further changes to the following “test suites” …
* Tvm/tests/python/contrib/test_vitis_ai/test_vitis_ai_runtime_cpu_part.py – by change its golden result to have 18 tvm ops (instead of 7, originally)
* Performance Note: this can affect the visit ai team’s run-time performance because, now, 11 more ops will not be executed on the visit ai accelerator (based on their byoc comments)
* It is possible that we may need to provide an additional pool param->layout == ?? so that it can force pooling.cc to use the new_in_layout as the param->layout instead if it is defined (the original condition)
* tests/python/relay/test_pass_alter_op_layout.py – by making similar changes as I did to the tvm/tests/python/relay/test_pass_convert_op_layout.py test suite.
… Please advice so that I can continue and then resolve this PR.
Thanks a lot !
* Joe
From: Joe Chou
Sent: Monday, October 11, 2021 12:05 PM
To: apache/tvm ***@***.***>; apache/tvm ***@***.***>
Cc: Author ***@***.***>
Subject: RE: [EXT] Re: [apache/tvm] [bug] pooling convert layout bug in pooling.cc and in test_pass_conve… (see also issue #8848) (#9235)
Yes and I am trying to reproduce them locally in order to find resolutions.
* Joe
From: Wuwei Lin ***@***.******@***.***>>
Sent: Monday, October 11, 2021 12:00 PM
To: apache/tvm ***@***.******@***.***>>
Cc: Joe Chou ***@***.******@***.***>>; Author ***@***.******@***.***>>
Subject: [EXT] Re: [apache/tvm] [bug] pooling convert layout bug in pooling.cc and in test_pass_conve… (see also issue #8848) (#9235)
External Email
________________________________
There are some failing test cases on CI that relate to this change
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_tvm_pull_9235-23issuecomment-2D940364473&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=escaZCs9wQeKyQiDz74nwKHPHsm5mss21WkH6-ffeSk&s=Mdy5MIJStP_P1-hkWJjXslSooRthmG2tR48tsd6o5Tg&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AM636PADO63ICYSJVE5VHLLUGMXZFANCNFSM5FUWAG4A&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=escaZCs9wQeKyQiDz74nwKHPHsm5mss21WkH6-ffeSk&s=GGqpJDj2F6zu0XWc28cFTudrEPooKQUKfAiBQoZlecA&e=>.
Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=escaZCs9wQeKyQiDz74nwKHPHsm5mss21WkH6-ffeSk&s=xoFKW0tfvMfEkDFOnw9BnAhKtdJVug-1lHe6Arsxh-c&e=> or Android<https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=escaZCs9wQeKyQiDz74nwKHPHsm5mss21WkH6-ffeSk&s=W1tjMqF4DUukbs-p5E7Zxx507jXS0S3LEDr_tHLx0Ig&e=>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on pull request #9235: [Op] Do not override specified layout in pooling
Posted by GitBox <gi...@apache.org>.
vinx13 commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-947040792
since you have already used merge, you need to run `git rebase main` in `working` branch (you need to make sure main is up to date first)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ccjoechou commented on pull request #9235: [Op] Do not override specified layout in pooling
Posted by GitBox <gi...@apache.org>.
ccjoechou commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-946302949
@comaniac, @vinx13, @masahi: I have pushed changes based on feedback. Latest changes are now utilizing a new out_layout field of pooling op (similar to what conv op has) so that, when out_layout is specified by user for pooling, pooling op will use and stick to the specified out_layout format.
Otherwise, the original infer layout will be used as originally.
4 new test cases have been added to the test_pass_convert_op_layout.py test suite to illustrate how to specify layout in pooling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ccjoechou commented on pull request #9235: [bug] pooling convert layout bug in pooling.cc and in test_pass_conve… (see also issue #8848)
Posted by GitBox <gi...@apache.org>.
ccjoechou commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-940368033
Yes and I am trying to reproduce them locally in order to find resolutions.
* Joe
From: Wuwei Lin ***@***.***>
Sent: Monday, October 11, 2021 12:00 PM
To: apache/tvm ***@***.***>
Cc: Joe Chou ***@***.***>; Author ***@***.***>
Subject: [EXT] Re: [apache/tvm] [bug] pooling convert layout bug in pooling.cc and in test_pass_conve… (see also issue #8848) (#9235)
External Email
________________________________
There are some failing test cases on CI that relate to this change
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_tvm_pull_9235-23issuecomment-2D940364473&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=escaZCs9wQeKyQiDz74nwKHPHsm5mss21WkH6-ffeSk&s=Mdy5MIJStP_P1-hkWJjXslSooRthmG2tR48tsd6o5Tg&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AM636PADO63ICYSJVE5VHLLUGMXZFANCNFSM5FUWAG4A&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=escaZCs9wQeKyQiDz74nwKHPHsm5mss21WkH6-ffeSk&s=GGqpJDj2F6zu0XWc28cFTudrEPooKQUKfAiBQoZlecA&e=>.
Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=escaZCs9wQeKyQiDz74nwKHPHsm5mss21WkH6-ffeSk&s=xoFKW0tfvMfEkDFOnw9BnAhKtdJVug-1lHe6Arsxh-c&e=> or Android<https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=escaZCs9wQeKyQiDz74nwKHPHsm5mss21WkH6-ffeSk&s=W1tjMqF4DUukbs-p5E7Zxx507jXS0S3LEDr_tHLx0Ig&e=>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on pull request #9235: [Op] Do not override specified layout in pooling
Posted by GitBox <gi...@apache.org>.
vinx13 commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-946984950
You can force push to current branch, so that you don't need to create new PR. Usually you will use `git pull --rebase`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ccjoechou commented on pull request #9235: [Op] Do not override specified layout in pooling
Posted by GitBox <gi...@apache.org>.
ccjoechou commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-946798867
I did use rebase on my side.
But for this time around because I did not know that, for upstreaming further changes, I have to advance my pull request’s base (main) to latest TVM github main again; therefore, the order of my git commands were not correct – leading to the merging situation.
Do you happen to have instructions (or sample links), which is for “github” pull request and allows to do rebase in order upstream new changes?
Can you share those links with us so that we can follow to avoid future git related troubles?
We have our own git server & GUI but different requirements are implemented over there; but, we want to follow TVM github git guidelines.
Thanks,
* Joe
From: Cody Yu ***@***.***>
Sent: Monday, October 18, 2021 7:50 PM
To: apache/tvm ***@***.***>
Cc: Joe Chou ***@***.***>; Author ***@***.***>
Subject: [EXT] Re: [apache/tvm] [Op] Do not override specified layout in pooling (#9235)
External Email
________________________________
Please use rebase instead of merge. We need to see the correct changes of this PR, and it cannot include the commits from other PRs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_tvm_pull_9235-23issuecomment-2D946321611&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=cvYw2dlkGTNlnqbrVbxm_jJT-EVbz2hXQgh1XeV3fsI&s=-yW2Oqts6oW8PhsVqKlygMxGKQHZWfFSYb0ZvPbkONQ&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AM636PGAEJEDSDXBTXACSH3UHTMGBANCNFSM5FUWAG4A&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=cvYw2dlkGTNlnqbrVbxm_jJT-EVbz2hXQgh1XeV3fsI&s=-jJkbT1vqONySNCUJQ5xWRymSYgJVvp8NNg8xUhTWow&e=>.
Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=cvYw2dlkGTNlnqbrVbxm_jJT-EVbz2hXQgh1XeV3fsI&s=I1dAssFokDD8qTL1IyLWBXLcPq0dglCw26sNYtyTeds&e=> or Android<https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=cvYw2dlkGTNlnqbrVbxm_jJT-EVbz2hXQgh1XeV3fsI&s=CE89y59UuMjK8HE8Ytf9bMy8FLbGK-KvUm3hZ2QeaH8&e=>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on pull request #9235: [Op] Do not override specified layout in pooling
Posted by GitBox <gi...@apache.org>.
vinx13 commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-947060998
```
git checkout main
git pull upstream main # this will update main branch locally
git checkout working
git rebase main
```
creating a new PR is ok but you still need to make sure you branch is clean (via cherry-pick or rebase)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on pull request #9235: [bug] pooling convert layout bug in pooling.cc and in test_pass_conve… (see also issue #8848)
Posted by GitBox <gi...@apache.org>.
vinx13 commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-940364473
There are some failing test cases on CI that relate to this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ccjoechou commented on pull request #9235: [Op] Do not override specified layout in pooling
Posted by GitBox <gi...@apache.org>.
ccjoechou commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-946806951
Do you like me to create a new TVM github pull request with all changes in one upstream again so it is cleaner?
I can do that but not sure how to move all discussions over.
Please advise !
Once again, if there happen to have instructions (or sample links), which are for “github” pull request with rebase, please point us to those so we will not make same mistake again.
Thanks,
* Joe
From: Joe Chou
Sent: Tuesday, October 19, 2021 7:46 AM
To: apache/tvm ***@***.***>; apache/tvm ***@***.***>
Cc: Author ***@***.***>
Subject: RE: [EXT] Re: [apache/tvm] [Op] Do not override specified layout in pooling (#9235)
I did use rebase on my side.
But for this time around because I did not know that, for upstreaming further changes, I have to advance my pull request’s base (main) to latest TVM github main again; therefore, the order of my git commands were not correct – leading to the merging situation.
Do you happen to have instructions (or sample links), which is for “github” pull request and allows to do rebase in order upstream new changes?
Can you share those links with us so that we can follow to avoid future git related troubles?
We have our own git server & GUI but different requirements are implemented over there; but, we want to follow TVM github git guidelines.
Thanks,
* Joe
From: Cody Yu ***@***.******@***.***>>
Sent: Monday, October 18, 2021 7:50 PM
To: apache/tvm ***@***.******@***.***>>
Cc: Joe Chou ***@***.******@***.***>>; Author ***@***.******@***.***>>
Subject: [EXT] Re: [apache/tvm] [Op] Do not override specified layout in pooling (#9235)
External Email
________________________________
Please use rebase instead of merge. We need to see the correct changes of this PR, and it cannot include the commits from other PRs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_tvm_pull_9235-23issuecomment-2D946321611&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=cvYw2dlkGTNlnqbrVbxm_jJT-EVbz2hXQgh1XeV3fsI&s=-yW2Oqts6oW8PhsVqKlygMxGKQHZWfFSYb0ZvPbkONQ&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AM636PGAEJEDSDXBTXACSH3UHTMGBANCNFSM5FUWAG4A&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=cvYw2dlkGTNlnqbrVbxm_jJT-EVbz2hXQgh1XeV3fsI&s=-jJkbT1vqONySNCUJQ5xWRymSYgJVvp8NNg8xUhTWow&e=>.
Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=cvYw2dlkGTNlnqbrVbxm_jJT-EVbz2hXQgh1XeV3fsI&s=I1dAssFokDD8qTL1IyLWBXLcPq0dglCw26sNYtyTeds&e=> or Android<https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=cvYw2dlkGTNlnqbrVbxm_jJT-EVbz2hXQgh1XeV3fsI&s=CE89y59UuMjK8HE8Ytf9bMy8FLbGK-KvUm3hZ2QeaH8&e=>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ccjoechou commented on pull request #9235: [bug] pooling convert layout bug in pooling.cc and in test_pass_conve… (see also issue #8848)
Posted by GitBox <gi...@apache.org>.
ccjoechou commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-943494906
Hi Wuwei, (or any other who can help?)
I have spent lots time on this pooling issue, which I believe it is a fundamental-concept-related issue.
Similar to what we have implemented for the ConvInferCorrectLayout() function in the tvm/src/relay/op/nn/convention.h file – for instance, it keeps the conv op’s layouts, if they are provided.
Let me use the nn.max_pool2d op as an example.
If in a given (input) IR graph, it is “explicitly” described that a nn.max_pool2d op needs to use the layout == “NHWC”.
* E.g.: y = relay.nn.max_pool2d(y, pool_size=(2, 2), layout="NHWC")
Plus, there is either:
* Either, “no” transforms.ConvertLayout() is given with a desired layout for nn.max_pool2d op, or
* A transforms.ConvertLayout() is given with a desired layout for "nn.max_pool2d": ["NHWC"] – i.e., to tell TVM.relay that the nn.max_pool2d op must stick with its “NHWC” data layout format (for input and for output)
In the above conditions, shouldn’t TVM.relay keep the nn.max_pool2d op’s input, data, output layouts as “NHWC”?
That is when nn.max_pool2d op’s param->layout != “” (assuming it is a legal layout format), we should use:
* InferCorrectLayoutOutput({use the original, given params->layout}, {use the original, given params->layout}, Attrs(params))
If this fundamental concept stands, then, the PR-#9235’s change to pooling.cc file should be (kind of) correct !
If you are in agreement with this fundamental concept, then, I can make further changes to the following “test suites” …
* Tvm/tests/python/contrib/test_vitis_ai/test_vitis_ai_runtime_cpu_part.py – by change its golden result to have 18 tvm ops (instead of 7, originally)
* Performance Note: this can affect the visit ai team’s run-time performance because, now, 11 more ops will not be executed on the visit ai accelerator (based on their byoc comments)
* It is possible that we may need to provide an additional pool param->layout == ?? so that it can force
* tests/python/relay/test_pass_alter_op_layout.py – by making similar changes as I did to the tvm/tests/python/relay/test_pass_convert_op_layout.py test suite.
… Please advice so that I can continue and then resolve this PR.
Thanks a lot !
* Joe
From: Joe Chou
Sent: Monday, October 11, 2021 12:05 PM
To: apache/tvm ***@***.***>; apache/tvm ***@***.***>
Cc: Author ***@***.***>
Subject: RE: [EXT] Re: [apache/tvm] [bug] pooling convert layout bug in pooling.cc and in test_pass_conve… (see also issue #8848) (#9235)
Yes and I am trying to reproduce them locally in order to find resolutions.
* Joe
From: Wuwei Lin ***@***.******@***.***>>
Sent: Monday, October 11, 2021 12:00 PM
To: apache/tvm ***@***.******@***.***>>
Cc: Joe Chou ***@***.******@***.***>>; Author ***@***.******@***.***>>
Subject: [EXT] Re: [apache/tvm] [bug] pooling convert layout bug in pooling.cc and in test_pass_conve… (see also issue #8848) (#9235)
External Email
________________________________
There are some failing test cases on CI that relate to this change
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_tvm_pull_9235-23issuecomment-2D940364473&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=escaZCs9wQeKyQiDz74nwKHPHsm5mss21WkH6-ffeSk&s=Mdy5MIJStP_P1-hkWJjXslSooRthmG2tR48tsd6o5Tg&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AM636PADO63ICYSJVE5VHLLUGMXZFANCNFSM5FUWAG4A&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=escaZCs9wQeKyQiDz74nwKHPHsm5mss21WkH6-ffeSk&s=GGqpJDj2F6zu0XWc28cFTudrEPooKQUKfAiBQoZlecA&e=>.
Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=escaZCs9wQeKyQiDz74nwKHPHsm5mss21WkH6-ffeSk&s=xoFKW0tfvMfEkDFOnw9BnAhKtdJVug-1lHe6Arsxh-c&e=> or Android<https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=escaZCs9wQeKyQiDz74nwKHPHsm5mss21WkH6-ffeSk&s=W1tjMqF4DUukbs-p5E7Zxx507jXS0S3LEDr_tHLx0Ig&e=>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ccjoechou commented on pull request #9235: [Op] Do not override specified layout in pooling
Posted by GitBox <gi...@apache.org>.
ccjoechou commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-947058170
Just to be careful …
Do I need to (a) change to my PR’s main branch and do git push origin main first (after pulling my local is different from github PR’s main), before I can (b) change to my PR’s working branch and then do git push origin working?
Or, I can ignore my PR’s main branch completely.
BTW, is it true that creating an additional PR working branch can complicate the git push process to github …
Thanks,
* Joe
From: Wuwei Lin ***@***.***>
Sent: Tuesday, October 19, 2021 12:30 PM
To: apache/tvm ***@***.***>
Cc: Joe Chou ***@***.***>; Author ***@***.***>
Subject: [EXT] Re: [apache/tvm] [Op] Do not override specified layout in pooling (#9235)
External Email
________________________________
since you have already used merge, you need to run git rebase main in working branch (you need to make sure main is up to date first)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_tvm_pull_9235-23issuecomment-2D947040792&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=nV9hbaeC-Dl3o-Vb62u3O5KruL-kwICaKKSUCjaHFDI&s=MCPlJ8EGw3kDfdYsOf6fjj9KwzkqaCnKXJTck5dbyhk&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AM636PHYSOGQH7ZPR72TZP3UHXBMHANCNFSM5FUWAG4A&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=nV9hbaeC-Dl3o-Vb62u3O5KruL-kwICaKKSUCjaHFDI&s=_OD-spgj1Q00GW15AHVidqY4ECI_f2I8l9vzzdo8EcA&e=>.
Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=nV9hbaeC-Dl3o-Vb62u3O5KruL-kwICaKKSUCjaHFDI&s=jIy9P-QR8M_fDh33kA0VLt4lr1zTw6KMBRl8006GqqA&e=> or Android<https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=nV9hbaeC-Dl3o-Vb62u3O5KruL-kwICaKKSUCjaHFDI&s=rcq0KfN03vTp1ur9ZZlzoK9bPF15QBger8lZ05g1rMk&e=>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #9235: [Op] Do not override specified layout in pooling
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-946311616
Ah please rebase against to the latest commit. This PR shouldn't have 9k changes...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #9235: [Op] Do not override specified layout in pooling
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-946321611
Please use rebase instead of merge. We need to see the correct changes of this PR, and it cannot include the commits from other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ccjoechou commented on pull request #9235: [Op] Do not override specified layout in pooling
Posted by GitBox <gi...@apache.org>.
ccjoechou commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-947065895
I did all those.
I think you are implying that I need to git push origin main as well as git push origin working.
Thanks and will do both to see what happens on github PR…
* Joe
From: Wuwei Lin ***@***.***>
Sent: Tuesday, October 19, 2021 1:00 PM
To: apache/tvm ***@***.***>
Cc: Joe Chou ***@***.***>; Author ***@***.***>
Subject: [EXT] Re: [apache/tvm] [Op] Do not override specified layout in pooling (#9235)
External Email
________________________________
git checkout main
git pull upstream main # this will update main branch locally
git checkout working
git rebase main
creating a new PR is ok but you still need to make sure you branch is clean (via cherry-pick or rebase)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_tvm_pull_9235-23issuecomment-2D947060998&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=1jdpxuqtRe1lSVYSzEEow9JA-FHQhJFAXln90WB1qlw&s=wAqiWqm4CUT9oCps5pvu8lNTgZiIuOGpQQ7apUj9qIY&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AM636PF5QPGW4W4HIZQ2RKLUHXE5ZANCNFSM5FUWAG4A&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=1jdpxuqtRe1lSVYSzEEow9JA-FHQhJFAXln90WB1qlw&s=ZcI5-MkNNzPjRZgl0XLeoQ7ZveE7a8GuWlupzLYivyo&e=>.
Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=1jdpxuqtRe1lSVYSzEEow9JA-FHQhJFAXln90WB1qlw&s=_21lGe5HBhQoQg5KN9_0fzgAe3Zirkbbmtja0hDnWnY&e=> or Android<https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=1jdpxuqtRe1lSVYSzEEow9JA-FHQhJFAXln90WB1qlw&s=ozzGhIB6c1shxVupA5YM6DfawTpIdMyS7Yh_SqaXCCg&e=>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi closed pull request #9235: [Op] Do not override specified layout in pooling
Posted by GitBox <gi...@apache.org>.
masahi closed pull request #9235:
URL: https://github.com/apache/tvm/pull/9235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ccjoechou commented on pull request #9235: [Op] Do not override specified layout in pooling
Posted by GitBox <gi...@apache.org>.
ccjoechou commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-947070219
Looks like those commands are not helping…
I will create a new PR (will make sure all files and changes are good over there).
If I need to amend again, will use git pull --rebase so no merging shows up…
Thanks for your help again.
* Joe
From: Joe Chou
Sent: Tuesday, October 19, 2021 1:07 PM
To: apache/tvm ***@***.***>; apache/tvm ***@***.***>
Cc: Author ***@***.***>
Subject: RE: [EXT] Re: [apache/tvm] [Op] Do not override specified layout in pooling (#9235)
I did all those.
I think you are implying that I need to git push origin main as well as git push origin working.
Thanks and will do both to see what happens on github PR…
* Joe
From: Wuwei Lin ***@***.******@***.***>>
Sent: Tuesday, October 19, 2021 1:00 PM
To: apache/tvm ***@***.******@***.***>>
Cc: Joe Chou ***@***.******@***.***>>; Author ***@***.******@***.***>>
Subject: [EXT] Re: [apache/tvm] [Op] Do not override specified layout in pooling (#9235)
External Email
________________________________
git checkout main
git pull upstream main # this will update main branch locally
git checkout working
git rebase main
creating a new PR is ok but you still need to make sure you branch is clean (via cherry-pick or rebase)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_tvm_pull_9235-23issuecomment-2D947060998&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=1jdpxuqtRe1lSVYSzEEow9JA-FHQhJFAXln90WB1qlw&s=wAqiWqm4CUT9oCps5pvu8lNTgZiIuOGpQQ7apUj9qIY&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AM636PF5QPGW4W4HIZQ2RKLUHXE5ZANCNFSM5FUWAG4A&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=1jdpxuqtRe1lSVYSzEEow9JA-FHQhJFAXln90WB1qlw&s=ZcI5-MkNNzPjRZgl0XLeoQ7ZveE7a8GuWlupzLYivyo&e=>.
Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=1jdpxuqtRe1lSVYSzEEow9JA-FHQhJFAXln90WB1qlw&s=_21lGe5HBhQoQg5KN9_0fzgAe3Zirkbbmtja0hDnWnY&e=> or Android<https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=1jdpxuqtRe1lSVYSzEEow9JA-FHQhJFAXln90WB1qlw&s=ozzGhIB6c1shxVupA5YM6DfawTpIdMyS7Yh_SqaXCCg&e=>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ccjoechou commented on pull request #9235: [Op] Do not override specified layout in pooling
Posted by GitBox <gi...@apache.org>.
ccjoechou commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-947032382
Thank you for your help !
Just to be sure that I understand your suggestion.
I should do git pull --rebase on my local machine?
On my local machine, I did the following instructions (see BLOD or search for Local-machine) but nothing happens…
I am using a working branch locally.
Local-machine$ git log
commit 781ebe18d0607438a7782dbcdeedb3bc132f0b67 (HEAD -> working, origin/working)
Author: Joe (Chien-Chun) Chou ***@***.***>
Date: Mon Oct 18 19:44:54 2021 -0700
updated format of two py files
commit 5e77c54c868ff6fef00a2bb53face303f76de8b1
Merge: 9319d90b6 961db913f
Author: Joe (Chien-Chun) Chou ***@***.***>
Date: Mon Oct 18 18:45:37 2021 -0700
Merge branch 'working' of https://github.com/ccjoechou/tvm into working
commit 9319d90b6b710489046504cef8aae3b1b9c0b77b
Author: Joe (Chien-Chun) Chou ***@***.***>
Date: Fri Oct 8 18:02:42 2021 -0700
[bug] pooling convert layout bug in pooling.cc and in test_pass_convert_op_layout.py
commit 75cf964b0b2d4f737b5cb25131a6c146b5edf22d (upstream/main, origin/main, origin/HEAD, main)
Author: Tianqi Chen ***@***.***>
Date: Mon Oct 18 17:31:33 2021 -0400
…
Local-machine$ git branch
main
* working
Local-machine$ git remote -v
origin https://github.com/ccjoechou/tvm.git (fetch)
origin https://github.com/ccjoechou/tvm.git (push)
upstream https://github.com/apache/tvm (fetch)
upstream https://github.com/apache/tvm (push)
And, I can do the following, right now:
Local-machine$ git pull –rebase
Already up to date.
Current branch working is up to date.
Local-machine$ git push origin working
Everything up-to-date
Thanks,
* Joe
From: Wuwei Lin ***@***.***>
Sent: Tuesday, October 19, 2021 11:22 AM
To: apache/tvm ***@***.***>
Cc: Joe Chou ***@***.***>; Author ***@***.***>
Subject: [EXT] Re: [apache/tvm] [Op] Do not override specified layout in pooling (#9235)
External Email
________________________________
You can force push to current branch, so that you don't need to create new PR. Usually you will use git pull --rebase
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_tvm_pull_9235-23issuecomment-2D946984950&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=d5mum7BVsrrnTBn14rIvmceQDCuuGeSNVfo_rGh1JX0&s=PwlB_OuOPE3WQQHHeTHPmnzTtHYcJHuhA0_CNnNWgN4&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AM636PB4OIDJWBNZ7Y5OUATUHWZNNANCNFSM5FUWAG4A&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=d5mum7BVsrrnTBn14rIvmceQDCuuGeSNVfo_rGh1JX0&s=FwKmhMQO-r9Nv44lywETobjwYV2eF-DnJJeoXBX0zDk&e=>.
Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=d5mum7BVsrrnTBn14rIvmceQDCuuGeSNVfo_rGh1JX0&s=LAZDprZQr8tYMANurXGNKh2lojIns09KVIW6-zJnbaw&e=> or Android<https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=d5mum7BVsrrnTBn14rIvmceQDCuuGeSNVfo_rGh1JX0&s=MtqEiI0CjktSccgtJe2ohwUUI_uEcX-yAtY8meUxmMg&e=>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org