[GitHub] [incubator-nuttx-apps] ptka commented on a change in pull request #1021: hello_rust: changes for target support

[GitBox <gi...@apache.org>]

ptka commented on a change in pull request #1021:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1021#discussion_r810813124



##########
File path: examples/hello_rust/hello_rust_main.rs
##########
@@ -33,6 +40,20 @@ extern "C"
     pub fn printf(format: *const u8, ...) -> i32;
 }
 
+/****************************************************************************
+ * Private functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Panic handler (needed for [no_std] compilation)

Review comment:
       Definitely a good point. I followed the NuttX style to have a starting point, knowing, that this is most likely no there best solution.
   
   May I ask you to provide more details, so we can go a step ahead on this point:
   
     - Is there a good official documentation on the Rust style, we can reference in NuttX?
     - Can we check this, similar to checkpatch.sh and can be used in CI?
     - Is the rust style compatible to current NuttX style, checked from checkpatch.sh?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org