You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/03/23 19:37:29 UTC

[GitHub] [nifi] bbende edited a comment on issue #4154: NIFI-7271 Make command timeout configurable for ShellUserGroupProvider

bbende edited a comment on issue #4154: NIFI-7271 Make command timeout configurable for ShellUserGroupProvider
URL: https://github.com/apache/nifi/pull/4154#issuecomment-602813340
 
 
   @alopresto thanks for reviewing! 
   
   During further testing, I found that we can't rely on calling `process.start()` and then calling `waitFor(...)` without ever trying to read the output from the process. So I've added another commit that adds an Executor to the ShellRunner so after calling start() we submit a task to start reading from the input stream, then back in the main thread we call waitFor().
   
   I also made the change from long to int.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services