You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/11/09 19:07:52 UTC

[GitHub] [kafka] cmccabe commented on pull request #12838: [DO NOT MERGE] SaslPlainSslEndToEndAuthorizationTest

cmccabe commented on PR #12838:
URL: https://github.com/apache/kafka/pull/12838#issuecomment-1309232726

   Hi @pprovenzano . Thanks for the PR.
   
   Before I can review this I'd like to understand the strategy here. Do you want to leave the `CONTROLLER` endpoint as `PLAINTEXT`? Or will it also be `SASL`? If it is plaintext, then our job will be simpler here, but we are testing less, of course. In general the main focus of the test is on brokers doing authorization, so perhaps the controller being plaintext is OK?
   
   As you noticed, there are some bootstrapping calls to AclCommand. What are we replacing the calls to AclCommand with? Are we going to be modifying the Authorizer objects directly? That is what we have done in other tests. We will need to modify all of the Authorizer objects though (each broker has one)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org