You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2023/10/10 12:56:43 UTC
[PR] [CELEBORN-1028][FOLLOWUP][DOCS] Make prometheus path configurable [incubator-celeborn]
cxzl25 opened a new pull request, #1974:
URL: https://github.com/apache/incubator-celeborn/pull/1974
### What changes were proposed in this pull request?
### Why are the changes needed?
https://github.com/apache/incubator-celeborn/pull/1965#issuecomment-1755345813
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
<img width="1410" alt="image" src="https://github.com/apache/incubator-celeborn/assets/3898450/6454133a-040b-4dde-84b7-dbf08fb15b13">
<img width="1418" alt="image" src="https://github.com/apache/incubator-celeborn/assets/3898450/6a0c259c-48fd-4bad-bb1f-7db5c3dcb73f">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1028][FOLLOWUP][DOCS] Make prometheus path configurable [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1974:
URL: https://github.com/apache/incubator-celeborn/pull/1974#issuecomment-1755403205
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1974?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1974](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1974?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c4a8230) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/bcf89da7ddb38756fe8a988ffb557cf65f1c7018?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bcf89da) will **decrease** coverage by `0.02%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head c4a8230 differs from pull request most recent head e5d5780. Consider uploading reports for the commit e5d5780 to get more accurate results
```diff
@@ Coverage Diff @@
## main #1974 +/- ##
==========================================
- Coverage 47.02% 46.99% -0.02%
==========================================
Files 164 164
Lines 10368 10368
Branches 957 957
==========================================
- Hits 4874 4871 -3
- Misses 5178 5179 +1
- Partials 316 318 +2
```
| [Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `87.56% <100.00%> (ø)` | |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1974/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1028][FOLLOWUP][DOCS] Make prometheus path configurable [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1974: [CELEBORN-1028][FOLLOWUP][DOCS] Make prometheus path configurable
URL: https://github.com/apache/incubator-celeborn/pull/1974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1028][FOLLOWUP][DOCS] Make prometheus path configurable [incubator-celeborn]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1974:
URL: https://github.com/apache/incubator-celeborn/pull/1974#discussion_r1352503717
##########
docs/monitoring.md:
##########
@@ -289,7 +289,7 @@ API path listed as below:
| Path | Meaning |
|-----------------------|-------------------------------------------------------------------------------------------------------------|
-| /metrics/prometheus | List the metrics data in prometheus format of the master. |
+| /metrics/prometheus | List the metrics data in prometheus format of the master.(Configure `celeborn.metrics.prometheus.path`) |
Review Comment:
List the metrics data in prometheus format of the master.(The url path is defined by configure `celeborn.metrics.prometheus.path`.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org