You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/03/05 18:12:45 UTC

[GitHub] reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel
URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172278443
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java
 ##########
 @@ -94,7 +94,7 @@ LedgerUnderreplicationManager newLedgerUnderreplicationManager()
      * @param lm
      *            Layout manager
      */
 
 Review comment:
   yes it is unrelated, but it is giving me compile time error in eclipse. So its needs to be fixed. Someone needs to be fixed. I'm trying to fix it in my other PR. If that PR goes first then this is not needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services