You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by jean-frederic clere <jf...@gmail.com> on 2025/02/13 15:59:18 UTC

Re: svn commit: r1923754 - in /httpd/httpd/trunk: changes-entries/pr69579.txt include/ap_mmn.h include/scoreboard.h modules/http2/h2_mplx.c server/scoreboard.c

On 2/12/25 10:43 AM, icing@apache.org wrote:
> +    worker_score* const ws =
> +	&ap_scoreboard_image->servers[sbh->child_num][sbh->thread_num];

that gives:
+++
scoreboard.c:663:5: error: ISO C90 forbids mixed declarations and code 
[-Werror=declaration-after-statement]
   663 |     worker_score* const ws =
       |     ^~~~~~~~~~~~
cc1: all warnings being treated as errors
+++
In my tests :-(

-- 
Cheers

Jean-Frederic

Re: svn commit: r1923754 - in /httpd/httpd/trunk: changes-entries/pr69579.txt include/ap_mmn.h include/scoreboard.h modules/http2/h2_mplx.c server/scoreboard.c

Posted by Vladimir Chlup <vc...@redhat.com>.
It also broke several jobs in CI. The fix is very simple
https://github.com/apache/httpd/pull/516

On Thu, Feb 13, 2025 at 5:08 PM jean-frederic clere <jf...@gmail.com>
wrote:

> On 2/12/25 10:43 AM, icing@apache.org wrote:
> > +    worker_score* const ws =
> > +     &ap_scoreboard_image->servers[sbh->child_num][sbh->thread_num];
>
> that gives:
> +++
> scoreboard.c:663:5: error: ISO C90 forbids mixed declarations and code
> [-Werror=declaration-after-statement]
>    663 |     worker_score* const ws =
>        |     ^~~~~~~~~~~~
> cc1: all warnings being treated as errors
> +++
> In my tests :-(
>
> --
> Cheers
>
> Jean-Frederic
>
>