[GitHub] [incubator-tvm] masahi commented on a change in pull request #6828: [CI] Torch 1.7 update to mainline

[GitBox <gi...@apache.org>]

masahi commented on a change in pull request #6828:
URL: https://github.com/apache/incubator-tvm/pull/6828#discussion_r516526502



##########
File path: tutorials/frontend/deploy_object_detection_pytorch.py
##########
@@ -27,16 +27,16 @@
 
 .. code-block:: bash
 
-    pip install torch==1.4.0
-    pip install torchvision==0.5.0
+    pip install torch==1.7.0
+    pip install torchvision==0.8.1
 
 or please refer to official site
 https://pytorch.org/get-started/locally/
 
 PyTorch versions should be backwards compatible but should be used
 with the proper TorchVision version.
 
-Currently, TVM supports PyTorch 1.4 and 1.3. Other versions may
+Currently, TVM supports PyTorch 1.7 and 1.4. Other versions may

Review comment:
       it's a good point, my reasoning is that since we've been testing with v1.4, and this upgrade doesn't break it (pytorch frontend tests pass on both 1.4 and 1.7), I think we can claim we still support 1.4.

##########
File path: tests/python/unittest/test_auto_scheduler_layout_rewrite.py
##########
@@ -166,5 +166,6 @@ def test_correctness_layout_rewrite_insert_transform_stage():
 
 if __name__ == "__main__":
     test_apply_steps_with_layout_rewrite()
-    test_correctness_layout_rewrite_rewrite_for_preTransformed()
-    test_correctness_layout_rewrite_insert_transform_stage()
+    # Disable for now due to being flaky on i386
+    # test_correctness_layout_rewrite_rewrite_for_preTransformed()
+    # test_correctness_layout_rewrite_insert_transform_stage()

Review comment:
       It's only a temporary measure, i386 tests should be fixed soon.

##########
File path: tests/python/unittest/test_auto_scheduler_layout_rewrite.py
##########
@@ -166,5 +166,6 @@ def test_correctness_layout_rewrite_insert_transform_stage():
 
 if __name__ == "__main__":
     test_apply_steps_with_layout_rewrite()
-    test_correctness_layout_rewrite_rewrite_for_preTransformed()
-    test_correctness_layout_rewrite_insert_transform_stage()
+    # Disable for now due to being flaky on i386
+    # test_correctness_layout_rewrite_rewrite_for_preTransformed()
+    # test_correctness_layout_rewrite_insert_transform_stage()

Review comment:
       It's only a temporary measure, i386 tests should be fixed soon. So I think this is ok for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org