You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/04/11 16:32:55 UTC

[kudu-CR] Add hms client-test to the IWYU filter 

Hello Alexey Serbin, Adar Dembo,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/9991

to review the following change.


Change subject: Add hms_client-test to the IWYU filter
......................................................................

Add hms_client-test to the IWYU filter

This is in keeping with the other HMS files that trigger many false
positives on the upstream gerrit. I've verified that the file does pass
IWYU on a local instance.

Change-Id: Icb281ec42ea2f7dafe2a3cf91a4e3a3d9ba5150b
---
M build-support/iwyu/iwyu-filter.awk
M src/kudu/hms/hms_client-test.cc
2 files changed, 7 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/9991/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9991
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb281ec42ea2f7dafe2a3cf91a4e3a3d9ba5150b
Gerrit-Change-Number: 9991
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] Add hms client-test to the IWYU filter

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9991 )

Change subject: Add hms_client-test to the IWYU filter
......................................................................

Add hms_client-test to the IWYU filter

This is in keeping with the other HMS files that trigger many false
positives on the upstream gerrit. I've verified that the file does pass
IWYU on a local instance.

Change-Id: Icb281ec42ea2f7dafe2a3cf91a4e3a3d9ba5150b
Reviewed-on: http://gerrit.cloudera.org:8080/9991
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M build-support/iwyu/iwyu-filter.awk
M src/kudu/hms/hms_client-test.cc
2 files changed, 7 insertions(+), 6 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/9991
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb281ec42ea2f7dafe2a3cf91a4e3a3d9ba5150b
Gerrit-Change-Number: 9991
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Add hms client-test to the IWYU filter

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9991 )

Change subject: Add hms_client-test to the IWYU filter
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9991
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb281ec42ea2f7dafe2a3cf91a4e3a3d9ba5150b
Gerrit-Change-Number: 9991
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 11 Apr 2018 17:24:54 +0000
Gerrit-HasComments: No