You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/17 03:25:55 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5764: procfs: Remove mallinfo from struct procfs_meminfo_entry_s

xiaoxiang781216 opened a new pull request #5764:
URL: https://github.com/apache/incubator-nuttx/pull/5764


   ## Summary
   let's call mm_mallinfo directly
   
   ## Impact
   Code refactor
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5764: procfs: Remove mallinfo from struct procfs_meminfo_entry_s

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5764:
URL: https://github.com/apache/incubator-nuttx/pull/5764#issuecomment-1070846212


   > Hi @xiaoxiang781216 what are the benefit of this modification? I think the code became simple/easier, but are other benefits doing this way?
   
   @acassis for consistence. You can see that meminfo_read already call mm_memdump directly, which make the abstraction through callback look very strange.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #5764: procfs: Remove mallinfo from struct procfs_meminfo_entry_s

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #5764:
URL: https://github.com/apache/incubator-nuttx/pull/5764


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #5764: procfs: Remove mallinfo from struct procfs_meminfo_entry_s

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5764:
URL: https://github.com/apache/incubator-nuttx/pull/5764#issuecomment-1070836521


   Hi @xiaoxiang781216 what are the benefit of this modification? I think the code became simple/easier, but are other benefits doing this way?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #5764: procfs: Remove mallinfo from struct procfs_meminfo_entry_s

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5764:
URL: https://github.com/apache/incubator-nuttx/pull/5764#issuecomment-1070836521


   Hi @xiaoxiang781216 what are the benefit of this modification? I think the code became simple/easier, but are other benefits doing this way?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5764: procfs: Remove mallinfo from struct procfs_meminfo_entry_s

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5764:
URL: https://github.com/apache/incubator-nuttx/pull/5764#issuecomment-1070846212


   > Hi @xiaoxiang781216 what are the benefit of this modification? I think the code became simple/easier, but are other benefits doing this way?
   
   @acassis for consistence. You can see that meminfo_read already call mm_memdump directly, which make the abstraction through callback look very strange.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #5764: procfs: Remove mallinfo from struct procfs_meminfo_entry_s

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #5764:
URL: https://github.com/apache/incubator-nuttx/pull/5764


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org