[GitHub] [airflow] DreamPearl commented on a change in pull request #13187: [AIRFLOW-3723] Add Gzip capability to mongo_to_S3 operator

[GitBox <gi...@apache.org>]

DreamPearl commented on a change in pull request #13187:
URL: https://github.com/apache/airflow/pull/13187#discussion_r546352146



##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -515,6 +515,7 @@ def load_string(
         encrypt: bool = False,
         encoding: Optional[str] = None,
         acl_policy: Optional[str] = None,
+        gzip: bool = False,

Review comment:
       As it is mentioned in the issue  [AIRFLOW-3723](https://issues.apache.org/jira/browse/AIRFLOW-3723) to use gzip. As well as I noticed that most of the people in nearby code are using gzip so to maintain consistency I used gzip.
   
   - https://github.com/apache/airflow/blob/master/airflow/providers/amazon/aws/hooks/s3.py#L495-L500
   - https://github.com/apache/airflow/search?q=gzip
   
   If you think changing the function parameter from `gzip` to `zip` would be better here in the same PR I will be happy to change it. Please let me know if you have more suggestions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org