You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2018/03/29 09:27:33 UTC
Review Request 66354: Remove forwarding of OpenSSL include dir.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66354/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
Setting 'OPENSSL_INCLUDE_DIR' doesn't provide enough information for
the 'FindOpenSSL' module to find library paths. Hence, nothing is gained
by forwarding this argument.
Diffs
-----
3rdparty/CMakeLists.txt 89d3e86199e771b922ff28b851b840efa190efaf
Diff: https://reviews.apache.org/r/66354/diff/1/
Testing
-------
Thanks,
Jan Schlicht
Re: Review Request 66354: Remove forwarding of OpenSSL include dir.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66354/#review200180
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66354']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66354
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66354/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (113 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1110 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (36 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (77 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (793 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (822 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (911 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (941 ms total)
[----------] Global test environment tear-down
[==========] 949 tests from 94 test cases ran. (447876 ms total)
[ PASSED ] 948 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 214 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66354/logs/mesos-tests-stderr.log):
```
I0329 10:36:15.673712 8084 executor.cpp:176] Received SUBSCRIBED event
I0329 10:36:15.679742 8084 executor.cpp:180] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0329 10:36:15.680743 8084 executor.cpp:176] Received LAUNCH event
I0329 10:36:15.687747 8084 executor.cpp:648] Starting task cac3041e-fa08-4daf-be67-2ab57cc7e0b2
I0329 10:36:15.815745 8084 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0329 10:36:15.847748 8084 executor.cpp:661] Forked command at 6908
I0329 10:36:15.876718 8684 exec.cpp:445] Executor asked to shutdown
I0329 10:36:15.876718 8448 executor.cpp:176] Received SHUTDOWN event
I0329 10:36:15.877719 8448 executor.cpp:758] Shutting down
I0329 10:36:15.877719 8448 executor.cpp:868] Sending SIGTERM to process tree at pid 63-5dd03c21f8fa-0000 (default) at scheduler-96057144-ed42-4b7f-9c56-fe17c58e2318@10.3.1.8:54332
I0329 10:36:15.874722 5520 hierarchical.cpp:405] Deactivated framework 27bb9072-8f3a-4dd0-8923-5dd03c21f8fa-0000
I0329 10:36:15.874722 7016 master.cpp:10446] Updating the state of task cac3041e-fa08-4daf-be67-2ab57cc7e0b2 of framework 27bb9072-8f3a-4dd0-8923-5dd03c21f8fa-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0329 10:36:15.874722 4368 slave.cpp:3877] Shutting down framework 27bb9072-8f3a-4dd0-8923-5dd03c21f8fa-0000
I0329 10:36:15.874722 4368 slave.cpp:6570] Shutting down executor 'cac3041e-fa08-4daf-be67-2ab57cc7e0b2' of framework 27bb9072-8f3a-4dd0-8923-5dd03c21f8fa-0000 at executor(1)@10.3.1.8:54353
I0329 10:36:15.875716 4368 slave.cpp:923] Agent terminating
W0329 10:36:15.875716 4368 slave.cpp:3873] Ignoring shutdown framework 27bb9072-8f3a-4dd0-8923-5dd03c21f8fa-0000 because it is terminating
I0329 10:36:15.877719 7016 master.cpp:10545] Removing task cac3041e-fa08-4daf-be67-2ab57cc7e0b2 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 27bb9072-8f3a-4dd0-8923-5dd03c21f8fa-0000 on agent 27bb9072-8f3a-4dd0-8923-5dd03c21f8fa-S0 at slave(418)@10.3.1.8:54332 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0329 10:36:15.879712 6716 containerizer.cpp:2338] Destroying container d0a34be6-becd-47e4-a6e5-2ac3b18dd756 in RUNNING state
I0329 10:36:15.879712 6716 containerizer.cpp:2952] Transitioning the state of container d0a34be6-becd-47e4-a6e5-2ac3b18dd756 from RUNNING to DESTROYING
I0329 10:36:15.880719 6716 launcher.cpp:156] Asked to destroy container d0a34be6-becd-47e4-a6e5-2ac3b18dd756
I0329 10:36:15.881717 7016 master.cpp:1295] Agent 27bb9072-8f3a-4dd0-8923-5dd03c21f8fa-S0 at slave(418)@10.3.1.8:54332 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0329 10:36:15.881717 7016 master.cpp:3283] Disconnecting agent 27bb9072-8f3a-4dd0-8923-5dd03c21f8fa-S0 at slave(418)@10.3.1.8:54332 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0329 10:36:15.881717 4368 hierarchical.cpp:344] Removed framework 27bb9072-8f3a-4dd0-8923-5dd03c21f8fa-0000
I0329 10:36:15.881717 7016 master.cpp:3302] Deactivating agent 27bb9072-8f3a-4dd0-8923-5dd03c21f8fa-S0 at slave(418)@10.3.1.8:54332 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0329 10:36:15.882730 1460 hierarchical.cpp:766] Agent 27bb9072-8f3a-4dd0-8923-5dd03c21f8fa-S0 deactivated
I0329 10:36:15.984998 6724 containerizer.cpp:2791] Container d0a34be6-becd-47e4-a6e5-2ac3b18dd756 has exited
I0329 10:36:16.018000 4476 master.cpp:1137] Master terminating
I0329 10:36:16.020982 8256 hierarchical.cpp:609] Removed agent 27bb9072-8f3a-4dd0-8923-5dd03c21f8fa-S0
I0329 10:36:16.337991 7728 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 29, 2018, 9:27 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66354/
> -----------------------------------------------------------
>
> (Updated March 29, 2018, 9:27 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Setting 'OPENSSL_INCLUDE_DIR' doesn't provide enough information for
> the 'FindOpenSSL' module to find library paths. Hence, nothing is gained
> by forwarding this argument.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 89d3e86199e771b922ff28b851b840efa190efaf
>
>
> Diff: https://reviews.apache.org/r/66354/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 66354: Remove forwarding of OpenSSL include dir.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66354/#review200182
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On March 29, 2018, 11:27 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66354/
> -----------------------------------------------------------
>
> (Updated March 29, 2018, 11:27 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Setting 'OPENSSL_INCLUDE_DIR' doesn't provide enough information for
> the 'FindOpenSSL' module to find library paths. Hence, nothing is gained
> by forwarding this argument.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 89d3e86199e771b922ff28b851b840efa190efaf
>
>
> Diff: https://reviews.apache.org/r/66354/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Schlicht
>
>