You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mumrah (via GitHub)" <gi...@apache.org> on 2024/09/05 19:02:47 UTC
[PR] MINOR Enable the GitHub build by default [kafka]
mumrah opened a new pull request, #17105:
URL: https://github.com/apache/kafka/pull/17105
Per the discussion in the [dev mailing list](https://lists.apache.org/thread/n4lwht8my06ydbzjrj0wxkj841r9t4ms), we should enable the new GitHub Actions workflows for all PRs.
This patch does just that, while leaving the `github-actions-opt-in` variable in place for future experiments.
Also included is a script that committers can use for approving workflow runs en-masse. Based on my experience, opening several tabs and clicking "Approve and Run" is rather tedious. The script utilizes the `gh` CLI which must be installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Enable the GitHub build by default [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #17105:
URL: https://github.com/apache/kafka/pull/17105#issuecomment-2336411494
@chia7712 WDYT, should we go ahead with this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Enable the GitHub build by default [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #17105:
URL: https://github.com/apache/kafka/pull/17105#issuecomment-2336721723
> so maybe we should do that?
+1, we can always add it back in future experiments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Enable the GitHub build by default [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #17105:
URL: https://github.com/apache/kafka/pull/17105#issuecomment-2332807287
We might want to wait on #17106 (and any follow-ups) to better utilize the build cache before turning this on for all PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Enable the GitHub build by default [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17105:
URL: https://github.com/apache/kafka/pull/17105#discussion_r1749076212
##########
.github/workflows/build.yml:
##########
@@ -87,7 +87,6 @@ jobs:
fail-fast: false
matrix:
java: [ 17, 11 ]
- if: ${{ inputs.github-actions-opt-in == 'true' }}
Review Comment:
Should we update "Annotate checkstyle errors"? Removing the `inputs.github-actions-opt-in` or fix the "truthiness"
https://github.com/apache/kafka/blob/trunk/.github/workflows/build.yml#L78
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Enable the GitHub build by default [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah merged PR #17105:
URL: https://github.com/apache/kafka/pull/17105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Enable the GitHub build by default [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #17105:
URL: https://github.com/apache/kafka/pull/17105#issuecomment-2338655030
@chia7712 lmk if there's anything remaining on this one. Otherwise lets merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Enable the GitHub build by default [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #17105:
URL: https://github.com/apache/kafka/pull/17105#issuecomment-2336696738
> maybe we should change the default value of github-actions-opt-in to true
If we do that, we could probably just remove the input parameter. As it stands, we don't have any use cases for it, so maybe we should do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org