You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/10 12:24:13 UTC
[GitHub] [pulsar] gaozhangmin opened a new pull request #14222: [Flaky Test] BrokerServiceLookupTest#testModularLoadManagerSplitBundle
gaozhangmin opened a new pull request #14222:
URL: https://github.com/apache/pulsar/pull/14222
Fixes #13102
### Motivation
Flaky test
### Modifications
Wait until pulsar2 becomes leader. Or ` checkNamespaceBundleSplit` will return none.
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #14222: [Flaky Test] BrokerServiceLookupTest#testModularLoadManagerSplitBundle
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #14222:
URL: https://github.com/apache/pulsar/pull/14222#discussion_r804183555
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/BrokerServiceLookupTest.java
##########
@@ -731,6 +731,9 @@ public void testModularLoadManagerSplitBundle() throws Exception {
// broker-2 loadManager is a leader and let it refresh load-report from all the brokers
pulsar.getLeaderElectionService().close();
+ Awaitility.await().atMost(5, TimeUnit.SECONDS)
Review comment:
We can even use the default timeout here
```suggestion
Awaitility.await()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #14222: [Flaky Test] BrokerServiceLookupTest#testModularLoadManagerSplitBundle
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #14222:
URL: https://github.com/apache/pulsar/pull/14222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14222: [Flaky Test] BrokerServiceLookupTest#testModularLoadManagerSplitBundle
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14222:
URL: https://github.com/apache/pulsar/pull/14222#issuecomment-1034861768
@lhotari PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14222: [Flaky Test] BrokerServiceLookupTest#testModularLoadManagerSplitBundle
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14222:
URL: https://github.com/apache/pulsar/pull/14222#issuecomment-1034890650
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14222: [Flaky Test] BrokerServiceLookupTest#testModularLoadManagerSplitBundle
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14222:
URL: https://github.com/apache/pulsar/pull/14222#issuecomment-1034861644
@gaozhangmin:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14222: [Flaky Test] BrokerServiceLookupTest#testModularLoadManagerSplitBundle
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14222:
URL: https://github.com/apache/pulsar/pull/14222#issuecomment-1034861502
@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org