You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2022/04/29 22:55:30 UTC
[GitHub] [gobblin] Will-Lo commented on a diff in pull request #3476: [GOBBLIN-1618] log number of ingested records in AsynchronusFork
Will-Lo commented on code in PR #3476:
URL: https://github.com/apache/gobblin/pull/3476#discussion_r862247943
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/fork/AsynchronousFork.java:
##########
@@ -88,18 +90,25 @@ protected void processRecords() throws IOException, DataConversionException {
@Override
protected boolean putRecordImpl(Object record) throws InterruptedException {
+ if (record != Fork.SHUTDOWN_RECORD) {
+ this.recordsToProcess++;
+ }
return this.recordQueue.put(record);
}
boolean processRecord() throws IOException, DataConversionException {
try {
Object record = this.recordQueue.get();
if (record == null || record == Fork.SHUTDOWN_RECORD) {
+ if (record == null) {
+ log.info("Fork received a null record. isParentTaskDone=" + this.isParentTaskDone());
Review Comment:
Maybe doesn't have to be done in this PR, but we should explore emitting metrics on null records
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org