You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tajo.apache.org by "Hyunsik Choi (JIRA)" <ji...@apache.org> on 2014/01/06 13:06:50 UTC
[jira] [Commented] (TAJO-471) Extract ColumnPartitonUtils class for
ColumnPartition rewrite
[ https://issues.apache.org/jira/browse/TAJO-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862942#comment-13862942 ]
Hyunsik Choi commented on TAJO-471:
-----------------------------------
Here is my comment. In my opinion, ColumnPartitionUtils will have only few methods. For this purpose, we have used PlannerUtil which contains a bunch of methods about planning. I think that PlannerUtil is a nice place for _rewrite_ method. When you move rewrite method, please rename the method name to a proper name.
> Extract ColumnPartitonUtils class for ColumnPartition rewrite
> -------------------------------------------------------------
>
> Key: TAJO-471
> URL: https://issues.apache.org/jira/browse/TAJO-471
> Project: Tajo
> Issue Type: Improvement
> Components: physical operator
> Reporter: DaeMyung Kang
> Assignee: DaeMyung Kang
> Priority: Minor
> Attachments: TAJO-471.patch
>
>
> In ColumnPartitionedTableStoreExec.java and SeqScanExec.java
> They have similar rewriteColumnPartitionedTableSchema function.
> so we extract util class and should use this.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)