You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Justin Edelson (JIRA)" <ji...@apache.org> on 2010/10/20 21:32:24 UTC
[jira] Created: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
---------------------------------------------------------------------------------------------------------------------------
Key: SLING-1848
URL: https://issues.apache.org/jira/browse/SLING-1848
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Justin Edelson
Assignee: Justin Edelson
Priority: Blocker
Fix For: Scripting Core 2.0.12
ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
1) activate()
2) bindScriptEngineManager()
3) try adapting a script to a javax.servlet.Servlet
This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1848) registration (or unregistration) of
a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923129#action_12923129 ]
Justin Edelson commented on SLING-1848:
---------------------------------------
in r1025700, added a similar change which impacts bundleChanged()
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.12
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved SLING-1848.
-------------------------------------
Resolution: Fixed
This seems to be fixed now, patch looks good to me, therefore closing
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1848:
-------------------------------------
Attachment: (was: Plugin 3.js)
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Mike Müller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Müller updated SLING-1848:
-------------------------------
Attachment: (was: DreamWeaver CS5 Update.js)
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Charles L Fields (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles L Fields updated SLING-1848:
------------------------------------
Attachment: HugeInteger.jsp
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
> Attachments: HugeInteger.jsp, J Progress Bar.js, JFrame.asp, SearchForm.dwt.asp
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1848:
-------------------------------------
Attachment: (was: JFrame.asp)
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1848:
-------------------------------------
Attachment: (was: J Progress Bar.js)
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1848:
-------------------------------------
Attachment: (was: Plugin 2.js)
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Charles L Fields (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles L Fields updated SLING-1848:
------------------------------------
Attachment: SearchForm.dwt.asp
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
> Attachments: SearchForm.dwt.asp
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Charles L Fields (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles L Fields updated SLING-1848:
------------------------------------
Attachment: DreamWeaver CS5 Update.js
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
> Attachments: DreamWeaver CS5 Update.js
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Charles L Fields (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles L Fields updated SLING-1848:
------------------------------------
Attachment: Plugin 2.js
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
> Attachments: Plugin 2.js
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Charles L Fields (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles L Fields updated SLING-1848:
------------------------------------
Attachment: JFrame.asp
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
> Attachments: HugeInteger.jsp, J Progress Bar.js, JFrame.asp, SearchForm.dwt.asp
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1848:
-------------------------------------
Attachment: (was: HugeInteger.jsp)
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
> Attachments: J Progress Bar.js, JFrame.asp, Poker.asp, SearchForm.dwt.asp
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1848:
-------------------------------------
Attachment: (was: SearchForm.dwt.asp)
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1848) registration (or unregistration) of
a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923121#action_12923121 ]
Justin Edelson commented on SLING-1848:
---------------------------------------
done in r1025692.
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.12
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Charles L Fields (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles L Fields updated SLING-1848:
------------------------------------
Attachment: J Progress Bar.js
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
> Attachments: HugeInteger.jsp, J Progress Bar.js, JFrame.asp, SearchForm.dwt.asp
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Charles L Fields (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles L Fields updated SLING-1848:
------------------------------------
Attachment: Poker.asp
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
> Attachments: HugeInteger.jsp, J Progress Bar.js, JFrame.asp, Poker.asp, SearchForm.dwt.asp
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed SLING-1848.
-----------------------------------
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1848) registration (or unregistration) of
a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923139#action_12923139 ]
Justin Edelson commented on SLING-1848:
---------------------------------------
Felix - you're probably right about rewriting ScriptEngineManager. It is really unfortunate ScriptEngineManager is a concrete class, not an interface.
I don't see how the changes I made in r1025692 and r1025700 create new thread-safety issues. Am I missing something?
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.12
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1848:
-------------------------------------
Attachment: (was: Poker.asp)
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1848) registration (or unregistration) of
a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923126#action_12923126 ]
Felix Meschberger commented on SLING-1848:
------------------------------------------
I think this is fix is not along the intent of SLING- 1545 n but is probably ok for the short-term.
The problem with the SLING-1545 implementation is that the maneger is dropped but the registered service (which is dropped) is not unregistered....
I think it is about time to consider something completely different for the ScriptManager: We create our own implementation which allows us to unregister ScriptEngineFactory instances - something which is not foreseen in the standard ScriptManager. Thus we could setup the ScriptEngineManager once and for all and just add/remove ScriptEngineFactories as they come and go.
Another option would be to register a Proxy object as the service which in the back end accesses the real ScriptEngineManager on-demand thus forcing the ScriptEngineManager to be recreated should it be removed.
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.12
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1848) registration (or unregistration) of a
ScriptEngineFactory doesn't cause the ScriptEngineManager service to be
re-registered
Posted by "Charles L Fields (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles L Fields updated SLING-1848:
------------------------------------
Attachment: Plugin 3.js
> registration (or unregistration) of a ScriptEngineFactory doesn't cause the ScriptEngineManager service to be re-registered
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1848
> URL: https://issues.apache.org/jira/browse/SLING-1848
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Blocker
> Fix For: Scripting Core 2.0.14
>
> Attachments: Plugin 3.js
>
>
> ScriptEngineManagerFactory.refreshScriptEngineManager() handles the registration of an OSGi service of the ScriptEngineManager. This is used, amongst other places, by SlingScriptAdapterFactory.
> However, refreshScriptEngineManager() is *only* called from activate() and getScriptEngineManager() (and in the latter case, only if the scriptEngineManager is null). Although bindScriptEngineManager() (and unbind) null out scriptEngineManager, they do not call refreshScriptEngineManager(). As a result, new ScriptEngineFactory services are not effective with this call sequence:
> 1) activate()
> 2) bindScriptEngineManager()
> 3) try adapting a script to a javax.servlet.Servlet
> This can be worked around (albeit poorly IMHO) by going to the Configuration Status page in the web console because this causes getScriptEngineManager() to be called when scriptEngineManager is null, thus causing refreshScriptEngineManager() to be called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.