[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7088: cleanups as suggested by errorprone

["weizhouapache (via GitHub)" <gi...@apache.org>]

weizhouapache commented on code in PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#discussion_r1269040176


##########
utils/src/test/java/org/apache/cloudstack/utils/redfish/RedfishClientTest.java:
##########
@@ -87,15 +87,15 @@ public void validateAddressAndPrepareForUrlTestIpv6() {
     public void buildRequestUrlTestHttpsGetSystemId() {
         RedfishClient redfishclient = new RedfishClient(USERNAME, PASSWORD, true, false, REDFISHT_REQUEST_RETRIES);
         String result = redfishclient.buildRequestUrl(oobAddress, RedfishClient.RedfishCmdType.GetSystemId, systemId);
-        String expected = String.format("https://%s/redfish/v1/Systems/", oobAddress, systemId);

Review Comment:
   should not `systemId` be a part of the string ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org