You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/06/02 09:50:26 UTC

[GitHub] [thrift] emmenlau opened a new pull request #2166: Added IsOpen() and GetPort() for netstd transports

emmenlau opened a new pull request #2166:
URL: https://github.com/apache/thrift/pull/2166


   This PR adds implementations of `IsOpen()` and `GetPort()` to C# NetStd transports. The implementation is not extensively tested, but results look promising. Feedback about where (in which file) to add this in automatic testing for netstd would be welcome.
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2166: Added IsOpen() and GetPort() for netstd transports

Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2166:
URL: https://github.com/apache/thrift/pull/2166#issuecomment-638647949


   +1 so far. 
   
   You want to add the tests to this PR or plan to open another one?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2166: Added IsOpen() and GetPort() for netstd transports

Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2166:
URL: https://github.com/apache/thrift/pull/2166#issuecomment-637485656


   > Feedback about where (in which file) to add this in automatic testing for netstd would be welcome.
   
   There is lib\netstd\Tests\Thrift.Tests\Thrift.Tests.csproj where I added mine lately as well. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G closed pull request #2166: Added IsOpen() and GetPort() for netstd transports

Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2166:
URL: https://github.com/apache/thrift/pull/2166


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org