[jira] [Commented] (STANBOL-1270) Improve Enhancement Engine Archetype

["Rupert Westenthaler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STANBOL-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882800#comment-13882800 ] 

Rupert Westenthaler commented on STANBOL-1270:
----------------------------------------------

with http://svn.apache.org/r1561664 the above improvements are present in the trunk. However there are still some minor issues that should be addressed.

(1) The maven-archetype-plugin adds an relative path to the declared parent resulting in a WARNING like 

[WARNING] 
[WARNING] Some problems were encountered while building the effective model for eu.micoproject:stanbol-test-engine:bundle:1.0-SNAPSHOT
[WARNING] 'parent.relativePath' points at {users-parent-or-reactor} instead of org.apache.stanbol:stanbol-parent, please verify your project structure @ line 6, column 11
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING] 

To solve this one would need to find an option to tell the Archetype to NOT add a relativePath element to the generated pom.xml


(2) OSGI ServiceProperties do only include the engine name, but not the service ranking properties.


In addition the Archetype should be extended to also include a custom property to show how to

* define them as constants in the engine
* add a @property annotation
* read them form the properties within the activate method
* reset them in the deactivate method



> Improve Enhancement Engine Archetype
> ------------------------------------
>
>                 Key: STANBOL-1270
>                 URL: https://issues.apache.org/jira/browse/STANBOL-1270
>             Project: Stanbol
>          Issue Type: Improvement
>            Reporter: Rupert Westenthaler
>            Assignee: Rupert Westenthaler
>
> Here the initial list of planed improvements
> * add metatype.properties file for the engine
> * add @Component properties for multiple service instances, configuration policy and also provide some comments about their meanings
> * add logging and comments to activate/deactivate method
> * improve canEnhance and processEnhancements to better use available Helper methods
> * add bundle plugin configuration that imports servicesapi [0.11,1.1) and does not export any packages (keep engine impl private)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)