You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Simone Tripodi <si...@apache.org> on 2011/04/08 10:38:22 UTC

[discovery] help on last 2 open issues

Hi all guys,
I'm here to ask you a kind help/suggestions to close the last 2 open
issues on Discovery:

DISCOVERY-6: release 0.5 is targeted for Java5, I don't know if this
issue is still valid - I mean, if there are Java5 implementations
where ClassLoader.getResource() is not supported... I googled a little
and didn't find anything useful, I'm tempted to resolve it with a
"Won't fix" but I'm sure anyone here can tell me more.

DISCOVERY-7: I'd postpone, 0.5 was initially in my mind a maintenance
release, I wouldn't add any new behavior not supported before... WDYT?

Many thanks in advance, have a nice day!
Simo

http://people.apache.org/~simonetripodi/
http://www.99soft.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [discovery] help on last 2 open issues

Posted by Jochen Wiedmann <jo...@gmail.com>.
On Fri, Apr 8, 2011 at 1:23 PM, Simone Tripodi <si...@apache.org> wrote:

> Last and least: what about DISCOVERY-11? Can we consider "WONTFIX" too?

The bug report is not particularly clear. IMO, we should distinguish
between the following cases:

- The methods Service.providers throws an Exception, due to linkage
errors and the like. That would mean that it is completely useless in
such cases and we should consider to fix that. The desire should be to
return at least one usable provider, if any.
- The method Enumeration.hasNextElement() fails. That's a problem,
because it means the user cannot skip to a usable element.
- The method Enumeration.next() fails. That's not particularly well,
but if the user can catch the error and still skip to the next element
afterwards, it is acceptable. I agree that exceptions should not be
hidden here and we ought to keep compatibility in mind.
- The object returned by Enumeration.next() fails: That's not a
problem of discovery.


Jochen




-- 
I Am What I Am And That's All What I Yam (Popeye)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [discovery] help on last 2 open issues

Posted by Simone Tripodi <si...@apache.org>.
Last and least: what about DISCOVERY-11? Can we consider "WONTFIX" too?
Simo

http://people.apache.org/~simonetripodi/
http://www.99soft.org/



On Fri, Apr 8, 2011 at 1:00 PM, Simone Tripodi <si...@apache.org> wrote:
> Hi all guys,
> thanks for the support! Can you please check my commit r1090196 to
> review if it could work as fix?
> Many thanks in advance!!!
> Simo
>
> http://people.apache.org/~simonetripodi/
> http://www.99soft.org/
>
>
>
> On Fri, Apr 8, 2011 at 11:30 AM, Jochen Wiedmann
> <jo...@gmail.com> wrote:
>> On Fri, Apr 8, 2011 at 11:26 AM, Jörg Schaible
>> <jo...@scalaris.com> wrote:
>>
>>>>> DISCOVERY-6: release 0.5 is targeted for Java5, I don't know if this
>>>>> issue is still valid - I mean, if there are Java5 implementations
>>>>> where ClassLoader.getResource() is not supported... I googled a little
>>>>> and didn't find anything useful, I'm tempted to resolve it with a
>>>>> "Won't fix" but I'm sure anyone here can tell me more.
>>>>
>>>> If ClassLoader.getResource() is unsupported then almost everything
>>>> will break. I doubt the validity. And in that case, it would be a JVM
>>>> bug and not a discovery bug. WONTFIX sounds sensible.
>>>
>>> You cannot blame necessarily the JVM for a custom classloader. Why not
>>> simply use Emmanuel's suggestion?
>>
>> Sorry for misunderstanding that. I though that "Java5 implementations"
>> meant a JVM classloader. Fix my words to say "it would be a
>> classloader bug", but the result stays the same.
>>
>> Jochen
>>
>>>
>>>>> DISCOVERY-7: I'd postpone, 0.5 was initially in my mind a maintenance
>>>>> release, I wouldn't add any new behavior not supported before... WDYT?
>>>>
>>>> I'd close this as WONTFIX as well with the note that the user should
>>>> indeed have used '$' as a separator for inner classes.
>>>
>>> +1
>>>
>>> - Jörg
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>>
>>
>> --
>> I Am What I Am And That's All What I Yam (Popeye)
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [discovery] help on last 2 open issues

Posted by Simone Tripodi <si...@apache.org>.
Hi all guys,
thanks for the support! Can you please check my commit r1090196 to
review if it could work as fix?
Many thanks in advance!!!
Simo

http://people.apache.org/~simonetripodi/
http://www.99soft.org/



On Fri, Apr 8, 2011 at 11:30 AM, Jochen Wiedmann
<jo...@gmail.com> wrote:
> On Fri, Apr 8, 2011 at 11:26 AM, Jörg Schaible
> <jo...@scalaris.com> wrote:
>
>>>> DISCOVERY-6: release 0.5 is targeted for Java5, I don't know if this
>>>> issue is still valid - I mean, if there are Java5 implementations
>>>> where ClassLoader.getResource() is not supported... I googled a little
>>>> and didn't find anything useful, I'm tempted to resolve it with a
>>>> "Won't fix" but I'm sure anyone here can tell me more.
>>>
>>> If ClassLoader.getResource() is unsupported then almost everything
>>> will break. I doubt the validity. And in that case, it would be a JVM
>>> bug and not a discovery bug. WONTFIX sounds sensible.
>>
>> You cannot blame necessarily the JVM for a custom classloader. Why not
>> simply use Emmanuel's suggestion?
>
> Sorry for misunderstanding that. I though that "Java5 implementations"
> meant a JVM classloader. Fix my words to say "it would be a
> classloader bug", but the result stays the same.
>
> Jochen
>
>>
>>>> DISCOVERY-7: I'd postpone, 0.5 was initially in my mind a maintenance
>>>> release, I wouldn't add any new behavior not supported before... WDYT?
>>>
>>> I'd close this as WONTFIX as well with the note that the user should
>>> indeed have used '$' as a separator for inner classes.
>>
>> +1
>>
>> - Jörg
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
>
> --
> I Am What I Am And That's All What I Yam (Popeye)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [discovery] help on last 2 open issues

Posted by Jochen Wiedmann <jo...@gmail.com>.
On Fri, Apr 8, 2011 at 11:26 AM, Jörg Schaible
<jo...@scalaris.com> wrote:

>>> DISCOVERY-6: release 0.5 is targeted for Java5, I don't know if this
>>> issue is still valid - I mean, if there are Java5 implementations
>>> where ClassLoader.getResource() is not supported... I googled a little
>>> and didn't find anything useful, I'm tempted to resolve it with a
>>> "Won't fix" but I'm sure anyone here can tell me more.
>>
>> If ClassLoader.getResource() is unsupported then almost everything
>> will break. I doubt the validity. And in that case, it would be a JVM
>> bug and not a discovery bug. WONTFIX sounds sensible.
>
> You cannot blame necessarily the JVM for a custom classloader. Why not
> simply use Emmanuel's suggestion?

Sorry for misunderstanding that. I though that "Java5 implementations"
meant a JVM classloader. Fix my words to say "it would be a
classloader bug", but the result stays the same.

Jochen

>
>>> DISCOVERY-7: I'd postpone, 0.5 was initially in my mind a maintenance
>>> release, I wouldn't add any new behavior not supported before... WDYT?
>>
>> I'd close this as WONTFIX as well with the note that the user should
>> indeed have used '$' as a separator for inner classes.
>
> +1
>
> - Jörg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>



-- 
I Am What I Am And That's All What I Yam (Popeye)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [discovery] help on last 2 open issues

Posted by Jörg Schaible <jo...@scalaris.com>.
Jochen Wiedmann wrote:

> On Fri, Apr 8, 2011 at 10:38 AM, Simone Tripodi
> <si...@apache.org> wrote:
> 
>> DISCOVERY-6: release 0.5 is targeted for Java5, I don't know if this
>> issue is still valid - I mean, if there are Java5 implementations
>> where ClassLoader.getResource() is not supported... I googled a little
>> and didn't find anything useful, I'm tempted to resolve it with a
>> "Won't fix" but I'm sure anyone here can tell me more.
> 
> If ClassLoader.getResource() is unsupported then almost everything
> will break. I doubt the validity. And in that case, it would be a JVM
> bug and not a discovery bug. WONTFIX sounds sensible.

You cannot blame necessarily the JVM for a custom classloader. Why not 
simply use Emmanuel's suggestion?

>> DISCOVERY-7: I'd postpone, 0.5 was initially in my mind a maintenance
>> release, I wouldn't add any new behavior not supported before... WDYT?
> 
> I'd close this as WONTFIX as well with the note that the user should
> indeed have used '$' as a separator for inner classes.

+1

- Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [discovery] help on last 2 open issues

Posted by Jochen Wiedmann <jo...@gmail.com>.
On Fri, Apr 8, 2011 at 10:38 AM, Simone Tripodi
<si...@apache.org> wrote:

> DISCOVERY-6: release 0.5 is targeted for Java5, I don't know if this
> issue is still valid - I mean, if there are Java5 implementations
> where ClassLoader.getResource() is not supported... I googled a little
> and didn't find anything useful, I'm tempted to resolve it with a
> "Won't fix" but I'm sure anyone here can tell me more.

If ClassLoader.getResource() is unsupported then almost everything
will break. I doubt the validity. And in that case, it would be a JVM
bug and not a discovery bug. WONTFIX sounds sensible.


> DISCOVERY-7: I'd postpone, 0.5 was initially in my mind a maintenance
> release, I wouldn't add any new behavior not supported before... WDYT?

I'd close this as WONTFIX as well with the note that the user should
indeed have used '$' as a separator for inner classes.

Jochen

-- 
I Am What I Am And That's All What I Yam (Popeye)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org