You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/02 13:54:42 UTC

[GitHub] [flink] leonardBang opened a new pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

leonardBang opened a new pull request #13307:
URL: https://github.com/apache/flink/pull/13307


   ## What is the purpose of the change
   
   * This pull request import rowtime temporal join operator.  
   Temporal TableFunction join (LATERAL TemporalTableFunction(o.proctime)) will support by `LegacyTemporalRowTimeJoinOperator`,
   Temporal table join (FOR SYSTEM_TIME AS OF) will support by `TemporalRowTimeJoinOperator`
   
   ## Brief change log
   
     - Import `TemporalRowTimeJoinOperator` which supports changelog on both left input and right input
     - Move the primary key condition validation from physical phase to logical phase
   
   ## Verifying this change
   
   - Add ITCase in `TemporalJoinITCase`
   - Add unit test in `TemporalJoinTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): ( no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on a change in pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13307:
URL: https://github.com/apache/flink/pull/13307#discussion_r513259441



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -260,6 +390,152 @@ class TemporalJoinITCase(state: StateBackendMode)
     tEnv.executeSql(sql).await()
   }
 
+  @Test
+  def testEventTimeTemporalJoin(): Unit = {
+    val sql = "INSERT INTO rowtime_default_sink " +
+      " SELECT o.order_id, o.currency, o.amount, o.order_time, r.rate, r.currency_time " +
+      " FROM orders_rowtime AS o JOIN versioned_currency_with_single_key " +
+      " FOR SYSTEM_TIME AS OF o.order_time as r " +
+      " ON o.currency = r.currency"
+
+    tEnv.executeSql(sql).await()
+    val rawResult = getRawResults("rowtime_default_sink")
+    val expected = List(
+      "+I(1,Euro,12,2020-08-15T00:01,114,2020-08-15T00:00)",
+      "+I(2,US Dollar,1,2020-08-15T00:02,102,2020-08-15T00:00)",
+      "+I(3,RMB,40,2020-08-15T00:03,702,2020-08-15T00:00)",
+      "+I(4,Euro,14,2020-08-16T00:02,118,2020-08-16T00:01)",
+      "+U(5,US Dollar,18,2020-08-16T00:03,106,2020-08-16T00:02)")
+    assertEquals(expected.sorted, rawResult.sorted)
+  }
+
+  @Test
+  def testEventTimeTemporalJoinWithFilter(): Unit = {
+    tEnv.executeSql("CREATE VIEW v1 AS" +
+      " SELECT * FROM versioned_currency_with_single_key WHERE rate > 114")

Review comment:
       I think this is not a good case, because there is no updates in the source that changing from matching condition to not matching. Maybe `rate < 115` is better. 

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -59,10 +64,68 @@ class TemporalJoinITCase(state: StateBackendMode)
     changelogRow("+I","Euro", "no1", toJLong(118)),
     changelogRow("+I","US Dollar", "no2", toJLong(106)))
 
+  // test data for Event-Time temporal table join
+  val rowTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12),
+      toDateTime("2020-08-15T00:01:00")),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:02:00")),
+    changelogRow("+I", toJLong(3), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-15T00:03:00")),
+    changelogRow("+I", toJLong(4), "Euro", "no1", toJLong(14),
+      toDateTime("2020-08-16T00:02:00")),
+    // test left stream could be changelog,
+    // -U or -D message may retract fail in collection connector sink implementation

Review comment:
       I would suggest to add full events, it's weird to have only +U but no -U in a non-upsert source. 
   
   For event-time temporal join, I think it's safe to retract rows in sink. 

##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperator.java
##########
@@ -236,21 +253,30 @@ private long emitResultAndCleanUpState(long timerTimestamp) throws Exception {
 			}
 		}
 
-		cleanupState(timerTimestamp, rightRowsSorted);
+		cleanupExpiredVersionInState(currentWatermark, rightRowsSorted);
 		return lastUnprocessedTime;
 	}
 
+	private void collectJoinedRow(RowData leftSideRow, RowData rightRow) {
+		outRow.setRowKind(leftSideRow.getRowKind());
+		outRow.replace(leftSideRow, rightRow);
+		collector.collect(outRow);
+	}
+
 	/**
-	 * Removes all right entries older then the watermark, except the latest one. For example with:
-	 * rightState = [1, 5, 9]
-	 * and
-	 * watermark = 6
-	 * we can not remove "5" from rightState, because left elements with rowtime of 7 or 8 could
-	 * be joined with it later
+	 * Removes all expired version in the versioned table's state according to current watermark.
+	 * For example with: rightState = [1(+I), 4(-U), 4(+U), 7(-U), 7(+U), 9(-D), 12(I)],
+	 *
+	 * <p>If watermark = 6 we can not remove "4(+U)" from rightState because accumulate message means
+	 * the start of version, the left elements with row time of 5 or 6 could be joined with (+U,4) later.
+	 *
+	 * <p>If watermark = 10 we can remove "9(-D)" from rightState because retract message means the
+	 * end of version, a trick is we do not remove it but do not correlate it if it is a retract message.

Review comment:
       I don't think this is a trick...

##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperator.java
##########
@@ -294,6 +320,13 @@ private int indexOfFirstElementNewerThanTimer(long timerTimestamp, List<RowData>
 	/**
 	 * Binary search {@code rightRowsSorted} to find the latest right row to join with {@code leftTime}.
 	 * Latest means a right row with largest time that is still smaller or equal to {@code leftTime}.
+	 * For example with: rightState = [1(+I), 4(-U), 4(+U), 7(-U), 7(+U), 9(-D), 12(I)],

Review comment:
       I think we can't store both `4(-U)` and `4(+U)` in state, because they have the same map key `4`. 
   
   An improvement here is we don't store the `RowData` into state for retraction, but just store `null`. This can be better for performance if the `RowData` is large. We can use `TreeMap<Long, RowData>` or `List<Tuple2<Long, RowData>` to replace the current `List<RowData>`.

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -18,232 +18,555 @@
 
 package org.apache.flink.table.planner.runtime.stream.sql
 
-import org.apache.flink.api.scala._
-import org.apache.flink.streaming.api.TimeCharacteristic
-import org.apache.flink.streaming.api.functions.timestamps.BoundedOutOfOrdernessTimestampExtractor
-import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
-import org.apache.flink.streaming.api.windowing.time.Time
-import org.apache.flink.table.api._
-import org.apache.flink.table.api.bridge.scala._
+import org.apache.flink.table.api.TableException
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.changelogRow
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.getRawResults
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.registerData
 import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase.StateBackendMode
-import org.apache.flink.table.planner.runtime.utils.{StreamingWithStateTestBase, TestingAppendSink}
-import org.apache.flink.table.planner.utils.TableTestUtil
-import org.apache.flink.types.Row
+import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase
 
-import org.junit.Assert.assertEquals
 import org.junit._
+import org.junit.Assert.assertEquals
 import org.junit.runner.RunWith
 import org.junit.runners.Parameterized
 
-import java.sql.Timestamp
+import java.lang.{Long => JLong}
+import java.time.LocalDateTime
 
-import scala.collection.mutable
+import scala.collection.JavaConversions._
 
 @RunWith(classOf[Parameterized])
 class TemporalJoinITCase(state: StateBackendMode)
   extends StreamingWithStateTestBase(state) {
 
+  // test data for Processing-Time temporal table join
+  val procTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12)),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(14)),
+    changelogRow("+I", toJLong(3), "US Dollar", "no2", toJLong(18)),
+    changelogRow("+I", toJLong(4), "RMB", "no1", toJLong(40)))
+
+  val procTimeCurrencyData = List(
+    changelogRow("+I","Euro", "no1", toJLong(114)),
+    changelogRow("+I","US Dollar", "no1", toJLong(102)),
+    changelogRow("+I","Yen", "no1", toJLong(1)),
+    changelogRow("+I","RMB", "no1", toJLong(702)),
+    changelogRow("+I","Euro", "no1", toJLong(118)),
+    changelogRow("+I","US Dollar", "no2", toJLong(106)))
+
+  val procTimeCurrencyChangelogData = List(
+    changelogRow("+I","Euro", "no1", toJLong(114)),
+    changelogRow("+I","US Dollar", "no1", toJLong(102)),
+    changelogRow("+I","Yen", "no1", toJLong(1)),
+    changelogRow("+I","RMB", "no1", toJLong(702)),
+    changelogRow("-U","RMB", "no1", toJLong(702)),
+    changelogRow("+U","RMB", "no1", toJLong(802)),
+    changelogRow("+I","Euro", "no1", toJLong(118)),
+    changelogRow("+I","US Dollar", "no2", toJLong(106)))
+
+  // test data for Event-Time temporal table join
+  val rowTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12),
+      toDateTime("2020-08-15T00:01:00")),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:02:00")),
+    changelogRow("+I", toJLong(3), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-15T00:03:00")),
+    changelogRow("+I", toJLong(4), "Euro", "no1", toJLong(14),
+      toDateTime("2020-08-16T00:02:00")),
+    // test left stream could be changelog,
+    // -U or -D message may retract fail in collection connector sink implementation
+    changelogRow("+U", toJLong(5), "US Dollar", "no1", toJLong(18),
+      toDateTime("2020-08-16T00:03:00")),
+    changelogRow("+I", toJLong(6), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-16T00:03:00")))
+
+  val rowTimeCurrencyDataUsingMetaTime = List(
+    changelogRow("+I", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "Yen", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "RMB", "no1", toJLong(702),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("-U", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("+U", "Euro",  "no1", toJLong(118),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("-U", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("+U", "US Dollar",  "no1", toJLong(106),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("-D","RMB", "no1", toJLong(708),
+      toDateTime("2020-08-16T00:02:00")))
+
+  val rowTimeCurrencyDataUsingInsertTime = List(
+    changelogRow("+I", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "Yen", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "RMB", "no1", toJLong(702),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("-U", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("+U", "Euro",  "no1", toJLong(118),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("-U", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+U", "US Dollar",  "no1", toJLong(106),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("-D","RMB", "no1", toJLong(708),
+      toDateTime("2020-08-15T00:00:00")))
+
+  @Before
+  def prepare(): Unit = {
+    env.setParallelism(4)

Review comment:
       We don't need this, because default is 4.

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -18,232 +18,555 @@
 
 package org.apache.flink.table.planner.runtime.stream.sql
 
-import org.apache.flink.api.scala._
-import org.apache.flink.streaming.api.TimeCharacteristic
-import org.apache.flink.streaming.api.functions.timestamps.BoundedOutOfOrdernessTimestampExtractor
-import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
-import org.apache.flink.streaming.api.windowing.time.Time
-import org.apache.flink.table.api._
-import org.apache.flink.table.api.bridge.scala._
+import org.apache.flink.table.api.TableException
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.changelogRow
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.getRawResults
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.registerData
 import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase.StateBackendMode
-import org.apache.flink.table.planner.runtime.utils.{StreamingWithStateTestBase, TestingAppendSink}
-import org.apache.flink.table.planner.utils.TableTestUtil
-import org.apache.flink.types.Row
+import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase
 
-import org.junit.Assert.assertEquals
 import org.junit._
+import org.junit.Assert.assertEquals
 import org.junit.runner.RunWith
 import org.junit.runners.Parameterized
 
-import java.sql.Timestamp
+import java.lang.{Long => JLong}
+import java.time.LocalDateTime
 
-import scala.collection.mutable
+import scala.collection.JavaConversions._
 
 @RunWith(classOf[Parameterized])
 class TemporalJoinITCase(state: StateBackendMode)
   extends StreamingWithStateTestBase(state) {
 
+  // test data for Processing-Time temporal table join
+  val procTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12)),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(14)),
+    changelogRow("+I", toJLong(3), "US Dollar", "no2", toJLong(18)),
+    changelogRow("+I", toJLong(4), "RMB", "no1", toJLong(40)))
+
+  val procTimeCurrencyData = List(
+    changelogRow("+I","Euro", "no1", toJLong(114)),
+    changelogRow("+I","US Dollar", "no1", toJLong(102)),
+    changelogRow("+I","Yen", "no1", toJLong(1)),
+    changelogRow("+I","RMB", "no1", toJLong(702)),
+    changelogRow("+I","Euro", "no1", toJLong(118)),
+    changelogRow("+I","US Dollar", "no2", toJLong(106)))
+
+  val procTimeCurrencyChangelogData = List(
+    changelogRow("+I","Euro", "no1", toJLong(114)),
+    changelogRow("+I","US Dollar", "no1", toJLong(102)),
+    changelogRow("+I","Yen", "no1", toJLong(1)),
+    changelogRow("+I","RMB", "no1", toJLong(702)),
+    changelogRow("-U","RMB", "no1", toJLong(702)),
+    changelogRow("+U","RMB", "no1", toJLong(802)),
+    changelogRow("+I","Euro", "no1", toJLong(118)),
+    changelogRow("+I","US Dollar", "no2", toJLong(106)))
+
+  // test data for Event-Time temporal table join
+  val rowTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12),
+      toDateTime("2020-08-15T00:01:00")),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:02:00")),
+    changelogRow("+I", toJLong(3), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-15T00:03:00")),
+    changelogRow("+I", toJLong(4), "Euro", "no1", toJLong(14),
+      toDateTime("2020-08-16T00:02:00")),
+    // test left stream could be changelog,
+    // -U or -D message may retract fail in collection connector sink implementation
+    changelogRow("+U", toJLong(5), "US Dollar", "no1", toJLong(18),
+      toDateTime("2020-08-16T00:03:00")),
+    changelogRow("+I", toJLong(6), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-16T00:03:00")))
+
+  val rowTimeCurrencyDataUsingMetaTime = List(
+    changelogRow("+I", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "Yen", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "RMB", "no1", toJLong(702),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("-U", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("+U", "Euro",  "no1", toJLong(118),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("-U", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("+U", "US Dollar",  "no1", toJLong(106),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("-D","RMB", "no1", toJLong(708),
+      toDateTime("2020-08-16T00:02:00")))
+
+  val rowTimeCurrencyDataUsingInsertTime = List(

Review comment:
       It is never used? Besides, I think "InsertTime" is not very accurate (maybe previous updated time). What about "BeforeTime"?

##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperator.java
##########
@@ -153,28 +161,30 @@ public void open() throws Exception {
 
 		timerService = getInternalTimerService(
 			TIMERS_STATE_NAME, VoidNamespaceSerializer.INSTANCE, this);
-		collector = new TimestampedCollector<>(output);
+
 		outRow = new JoinedRowData();
-		// all the output records should be INSERT only,
-		// because current temporal join only supports INSERT only left stream
-		outRow.setRowKind(RowKind.INSERT);
+		rightNullRow = new GenericRowData(rightType.toRowType().getFieldCount());
+		collector = new TimestampedCollector<>(output);
 	}
 
 	@Override
 	public void processElement1(StreamRecord<RowData> element) throws Exception {
 		RowData row = element.getValue();
-		checkNotRetraction(row);
-
 		leftState.put(getNextLeftIndex(), row);
 		registerSmallestTimer(getLeftTime(row)); // Timer to emit and clean up the state
 
 		registerProcessingCleanupTimer();
 	}
 
+	/**
+	 * We skip all -U message here, currently -U message is useless in versioned table.
+	 * case 1: the -U message may use update message's time, for example: rightState = [1(+I), 4(-U), 4(+U)],
+	 * case 2: the -U message may use insert message's time, for example: rightState = [1(+I), 1(-U), 4(+U)],
+	 * the valid period of them should be [1, 4) and [4, Long.MaxValue).

Review comment:
       This comment is not correct any more, remove them?

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -129,6 +192,73 @@ class TemporalJoinITCase(state: StateBackendMode)
 
     createSinkTable("proctime_default_sink", None)
 
+
+    val rowTimeOrderDataId = registerData(rowTimeOrderData)
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE orders_rowtime (
+         |  order_id BIGINT,
+         |  currency STRING,
+         |  currency_no STRING,
+         |  amount BIGINT,
+         |  order_time TIMESTAMP(3),
+         |  WATERMARK FOR order_time AS order_time
+         |) WITH (
+         |  'connector' = 'values',
+         |  'changelog-mode' = 'I,UA,UB,D',
+         |  'data-id' = '$rowTimeOrderDataId'
+         |)
+         |""".stripMargin)
+
+    val rowTimeCurrencyDataId = registerData(rowTimeCurrencyDataUsingMetaTime)
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE versioned_currency_with_single_key (
+         |  currency STRING,
+         |  currency_no STRING,
+         |  rate  BIGINT,
+         |  currency_time TIMESTAMP(3),
+         |  WATERMARK FOR currency_time AS currency_time - interval '10' SECOND,
+         |  PRIMARY KEY(currency) NOT ENFORCED
+         |) WITH (
+         |  'connector' = 'values',
+         |  'changelog-mode' = 'I,UA,UB,D',
+         |  'data-id' = '$rowTimeCurrencyDataId'
+         |)
+         |""".stripMargin)
+
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE changelog_currency_using_insert_time (

Review comment:
       This table is not using insertion time. 

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -260,6 +390,152 @@ class TemporalJoinITCase(state: StateBackendMode)
     tEnv.executeSql(sql).await()
   }
 
+  @Test
+  def testEventTimeTemporalJoin(): Unit = {
+    val sql = "INSERT INTO rowtime_default_sink " +
+      " SELECT o.order_id, o.currency, o.amount, o.order_time, r.rate, r.currency_time " +
+      " FROM orders_rowtime AS o JOIN versioned_currency_with_single_key " +
+      " FOR SYSTEM_TIME AS OF o.order_time as r " +
+      " ON o.currency = r.currency"

Review comment:
       Could you add a test that the join key contains not only the primary key? For example `ON o.currency_no = r.currency_no AND o.currency = r.currency`.

##########
File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperatorTest.java
##########
@@ -85,31 +101,28 @@ public void testRowTimeTemporalJoin() throws Exception {
 		testHarness.processWatermark1(new Watermark(2));
 		testHarness.processWatermark2(new Watermark(2));
 
-		testHarness.processElement1(insertRecord(1L, "k1", "2a1"));
-		testHarness.processElement1(insertRecord(3L, "k1", "2a3"));
+		testHarness.processElement1(insertRecord(1L, "k1", "1a1"));
+		testHarness.processElement1(insertRecord(3L, "k1", "1a3"));
 		testHarness.processElement2(insertRecord(4L, "k2", "2a4"));
 
 		testHarness.processWatermark1(new Watermark(5));
 		testHarness.processWatermark2(new Watermark(5));
 
-		testHarness.processElement1(insertRecord(6L, "k2", "5a6"));
-		testHarness.processElement2(insertRecord(8L, "k2", "5a8"));
-		testHarness.processElement1(insertRecord(11L, "k2", "5a11"));
-		testHarness.processElement1(insertRecord(7L, "k2", "5a7"));
+		testHarness.processElement1(insertRecord(6L, "k2", "2a3"));
+		testHarness.processElement2(updateBeforeRecord(7L, "k2", "2a4"));
+		testHarness.processElement2(updateBeforeRecord(7L, "k2", "2a5"));

Review comment:
       Two UB for the same key `k2`? Should this be UA?

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -260,6 +390,152 @@ class TemporalJoinITCase(state: StateBackendMode)
     tEnv.executeSql(sql).await()
   }
 
+  @Test
+  def testEventTimeTemporalJoin(): Unit = {
+    val sql = "INSERT INTO rowtime_default_sink " +
+      " SELECT o.order_id, o.currency, o.amount, o.order_time, r.rate, r.currency_time " +
+      " FROM orders_rowtime AS o JOIN versioned_currency_with_single_key " +
+      " FOR SYSTEM_TIME AS OF o.order_time as r " +
+      " ON o.currency = r.currency"
+
+    tEnv.executeSql(sql).await()
+    val rawResult = getRawResults("rowtime_default_sink")
+    val expected = List(
+      "+I(1,Euro,12,2020-08-15T00:01,114,2020-08-15T00:00)",
+      "+I(2,US Dollar,1,2020-08-15T00:02,102,2020-08-15T00:00)",
+      "+I(3,RMB,40,2020-08-15T00:03,702,2020-08-15T00:00)",
+      "+I(4,Euro,14,2020-08-16T00:02,118,2020-08-16T00:01)",
+      "+U(5,US Dollar,18,2020-08-16T00:03,106,2020-08-16T00:02)")
+    assertEquals(expected.sorted, rawResult.sorted)
+  }
+
+  @Test
+  def testEventTimeTemporalJoinWithFilter(): Unit = {
+    tEnv.executeSql("CREATE VIEW v1 AS" +
+      " SELECT * FROM versioned_currency_with_single_key WHERE rate > 114")
+    val sql = "INSERT INTO rowtime_default_sink " +
+      " SELECT o.order_id, o.currency, o.amount, o.order_time, r.rate, r.currency_time " +
+      " FROM orders_rowtime AS o " +
+      " JOIN v1 FOR SYSTEM_TIME AS OF o.order_time as r " +
+      " ON o.currency = r.currency"
+    tEnv.executeSql(sql).await()
+    val rawResult = getRawResults("rowtime_default_sink")
+    val expected = List(
+      "+I(3,RMB,40,2020-08-15T00:03,702,2020-08-15T00:00)",
+      "+I(4,Euro,14,2020-08-16T00:02,118,2020-08-16T00:01)")
+    assertEquals(expected.sorted, rawResult.sorted)
+  }
+
+  @Test
+  def tesEventTimeLeftTemporalJoin(): Unit = {
+    val sql = "INSERT INTO rowtime_default_sink " +
+      " SELECT o.order_id, o.currency, o.amount, o.order_time, r.rate, r.currency_time " +
+      " FROM orders_rowtime AS o LEFT JOIN versioned_currency_with_single_key " +
+      " FOR SYSTEM_TIME AS OF o.order_time as r " +
+      " ON o.currency = r.currency"
+    tEnv.executeSql(sql).await()
+
+    val rawResult = getRawResults("rowtime_default_sink")
+    val expected = List(
+      "+I(1,Euro,12,2020-08-15T00:01,114,2020-08-15T00:00)",
+      "+I(2,US Dollar,1,2020-08-15T00:02,102,2020-08-15T00:00)",
+      "+I(3,RMB,40,2020-08-15T00:03,702,2020-08-15T00:00)",
+      "+I(4,Euro,14,2020-08-16T00:02,118,2020-08-16T00:01)",
+      "+I(6,RMB,40,2020-08-16T00:03,null,null)",
+      "+U(5,US Dollar,18,2020-08-16T00:03,106,2020-08-16T00:02)")
+    assertEquals(expected.sorted, rawResult.sorted)
+  }
+
+  @Test
+  def tesEventTimeLeftTemporalJoinChangelogUsingInsertTime(): Unit = {

Review comment:
       I think this case doesn't cover the case we want to verify that the deletion in temporal table is a late event which doesn't affect the previous joined RMB order. 

##########
File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperatorTest.java
##########
@@ -85,31 +101,28 @@ public void testRowTimeTemporalJoin() throws Exception {
 		testHarness.processWatermark1(new Watermark(2));
 		testHarness.processWatermark2(new Watermark(2));
 
-		testHarness.processElement1(insertRecord(1L, "k1", "2a1"));
-		testHarness.processElement1(insertRecord(3L, "k1", "2a3"));
+		testHarness.processElement1(insertRecord(1L, "k1", "1a1"));
+		testHarness.processElement1(insertRecord(3L, "k1", "1a3"));
 		testHarness.processElement2(insertRecord(4L, "k2", "2a4"));
 
 		testHarness.processWatermark1(new Watermark(5));
 		testHarness.processWatermark2(new Watermark(5));
 
-		testHarness.processElement1(insertRecord(6L, "k2", "5a6"));
-		testHarness.processElement2(insertRecord(8L, "k2", "5a8"));
-		testHarness.processElement1(insertRecord(11L, "k2", "5a11"));
-		testHarness.processElement1(insertRecord(7L, "k2", "5a7"));
+		testHarness.processElement1(insertRecord(6L, "k2", "2a3"));
+		testHarness.processElement2(updateBeforeRecord(7L, "k2", "2a4"));
+		testHarness.processElement2(updateBeforeRecord(7L, "k2", "2a5"));

Review comment:
       Two UB for the same key `k2`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b9f1d43f8e46a0c79d2741c4d6061443ef9be599 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230) 
   * 7dc326d54c5ac31c352ac06c35d918f444d9bd40 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483",
       "triggerID" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a558cb0fd984dc5f256d7710f67239d0851204b3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7ad79c6528d529ebd03e87a78f92d79d8cb6d91f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126) 
   * 62bb7f7e511775b0b65003e65aa13b27c760da27 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on a change in pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13307:
URL: https://github.com/apache/flink/pull/13307#discussion_r511843228



##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Table.java
##########
@@ -168,7 +168,9 @@
 	 *        It takes one single argument, the {@code timeAttribute}, for which it returns
 	 *        matching version of the {@link Table}, from which {@link TemporalTableFunction}
 	 *        was created.
+	 * @deprecated please temporal DDL to define a temporal table.

Review comment:
       I would suggest not deprecate this interface for now, as we don't provide equivalent functionality yet. 

##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkChangelogModeInferenceProgram.scala
##########
@@ -543,12 +543,16 @@ class FlinkChangelogModeInferenceProgram extends FlinkOptimizeProgram[StreamOpti
         }
         val newLeftOption = this.visit(left, leftRequiredTrait)
 
-        // currently temporal join support changelog stream as the right side
-        // so it requires beforeAfterOrNone UpdateKind
         val rightInputModifyKindSet = getModifyKindSet(right)
-        val beforeAndAfter = beforeAfterOrNone(rightInputModifyKindSet)
-
-        val newRightOption = this.visit(right, beforeAndAfter)
+        // currently temporal join support changelog stream as the right side
+        // so it supports both ONLY_AFTER and BEFORE_AFTER, but prefer ONLY_AFTER
+        val onlyAfter = onlyAfterOrNone(rightInputModifyKindSet)
+        val newRightOption = this.visit(right, onlyAfter) match {
+          case Some(newRight) => Some(newRight)
+          case None =>
+            val beforeAfter = beforeAfterOrNone(rightInputModifyKindSet)
+            this.visit(right, beforeAfter)

Review comment:
       Can simplify to 
   
   ```suggestion
             case None => this.visit(right, beforeAfterOrNone(rightInputModifyKindSet))
   ```

##########
File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalTimeJoinOperatorTestBase.java
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.join.temporal;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.generated.GeneratedJoinCondition;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.runtime.util.BinaryRowDataKeySelector;
+import org.apache.flink.table.runtime.util.RowDataHarnessAssertor;
+import org.apache.flink.table.types.logical.BigIntType;
+import org.apache.flink.table.types.logical.VarCharType;
+
+/**
+ * Base test class for TemporalJoinOperator.
+ */
+public class TemporalTimeJoinOperatorTestBase {

Review comment:
       Convert this class to an abstract class. 

##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperator.java
##########
@@ -0,0 +1,437 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.join.temporal;
+
+import org.apache.flink.api.common.state.MapState;
+import org.apache.flink.api.common.state.MapStateDescriptor;
+import org.apache.flink.api.common.state.ValueState;
+import org.apache.flink.api.common.state.ValueStateDescriptor;
+import org.apache.flink.api.common.typeinfo.Types;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.runtime.state.VoidNamespace;
+import org.apache.flink.runtime.state.VoidNamespaceSerializer;
+import org.apache.flink.streaming.api.operators.InternalTimer;
+import org.apache.flink.streaming.api.operators.InternalTimerService;
+import org.apache.flink.streaming.api.operators.TimestampedCollector;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.table.data.GenericRowData;
+import org.apache.flink.table.data.JoinedRowData;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.data.util.RowDataUtil;
+import org.apache.flink.table.runtime.generated.GeneratedJoinCondition;
+import org.apache.flink.table.runtime.generated.JoinCondition;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.types.RowKind;
+
+import java.io.IOException;
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Comparator;
+import java.util.Iterator;
+import java.util.List;
+import java.util.ListIterator;
+import java.util.Map;
+import java.util.Optional;
+
+/**
+ * The operator for temporal join (FOR SYSTEM_TIME AS OF o.rowtime) on row time, it has no limitation
+ * about message types of the left input and right input, this means the operator deals changelog well.
+ *
+ * <p>For Event-time temporal join, its probe side is a regular table, its build side is a versioned
+ * table, the version of versioned table can extract from the build side state. This operator works by
+ * keeping on the state collection of probe and build records to process on next watermark. The idea
+ * is that between watermarks we are collecting those elements and once we are sure that there will be
+ * no updates we emit the correct result and clean up the expired data in state.
+ *
+ * <p>Cleaning up the state drops all of the "old" values from the probe side, where "old" is defined
+ * as older then the current watermark. Build side is also cleaned up in the similar fashion,
+ * we sort all "old" values with row time and row kind and then clean up the old values, when clean up
+ * the "old" values, if the latest record of all "old" values is retract message which means the version
+ * end, we clean all "old" values, if the the latest record is accumulate message which means the version
+ * start, we keep the latest one, and clear other "old" values.
+ *
+ * <p>One more trick is how the emitting results and cleaning up is triggered. It is achieved
+ * by registering timers for the keys. We could register a timer for every probe and build
+ * side element's event time (when watermark exceeds this timer, that's when we are emitting and/or
+ * cleaning up the state). However this would cause huge number of registered timers. For example
+ * with following evenTimes of probe records accumulated: {1, 2, 5, 8, 9}, if we
+ * had received Watermark(10), it would trigger 5 separate timers for the same key. To avoid that
+ * we always keep only one single registered timer for any given key, registered for the minimal
+ * value. Upon triggering it, we process all records with event times older then or equal to
+ * currentWatermark.
+ */
+public class TemporalRowTimeJoinOperator
+	extends BaseTwoInputStreamOperatorWithStateRetention {
+
+	private static final long serialVersionUID = 1L;
+
+	private static final String NEXT_LEFT_INDEX_STATE_NAME = "next-index";
+	private static final String LEFT_STATE_NAME = "left";
+	private static final String RIGHT_STATE_NAME = "right";
+	private static final String REGISTERED_TIMER_STATE_NAME = "timer";
+	private static final String TIMERS_STATE_NAME = "timers";
+
+	private final boolean isLeftOuterJoin;
+	private final InternalTypeInfo<RowData> leftType;
+	private final InternalTypeInfo<RowData> rightType;
+	private final GeneratedJoinCondition generatedJoinCondition;
+	private final int leftTimeAttribute;
+	private final int rightTimeAttribute;
+
+	/**
+	 * The comparator to get ordered elements of right state.
+	 */
+	private final ChangelogOrderComparator rightChangelogOrderComparator;
+
+	/**
+	 * Incremental index generator for {@link #leftState}'s keys.
+	 */
+	private transient ValueState<Long> nextLeftIndex;
+
+	/**
+	 * Mapping from artificial row index (generated by `nextLeftIndex`) into the left side `Row`.
+	 * We can not use List to accumulate Rows, because we need efficient deletes of the oldest rows.
+	 */
+	private transient MapState<Long, RowData> leftState;
+
+	/**
+	 * Mapping from timestamp to right side `Row`.
+	 **/
+	private transient MapState<RowData, Long> rightState;
+
+	private transient ValueState<Long> registeredEventTimer;
+	private transient TimestampedCollector<RowData> collector;
+	private transient InternalTimerService<VoidNamespace> timerService;
+
+	private transient JoinCondition joinCondition;
+	private transient JoinedRowData outRow;
+	private transient GenericRowData rightNullRow;
+
+	public TemporalRowTimeJoinOperator(
+			InternalTypeInfo<RowData> leftType,
+			InternalTypeInfo<RowData> rightType,
+			GeneratedJoinCondition generatedJoinCondition,
+			int leftTimeAttribute,
+			int rightTimeAttribute,
+			long minRetentionTime,
+			long maxRetentionTime,
+			boolean isLeftOuterJoin) {
+		super(minRetentionTime, maxRetentionTime);
+		this.leftType = leftType;
+		this.rightType = rightType;
+		this.generatedJoinCondition = generatedJoinCondition;
+		this.leftTimeAttribute = leftTimeAttribute;
+		this.rightTimeAttribute = rightTimeAttribute;
+		this.rightChangelogOrderComparator = new ChangelogOrderComparator(rightTimeAttribute);
+		this.isLeftOuterJoin = isLeftOuterJoin;
+	}
+
+	@Override
+	public void open() throws Exception {
+		super.open();
+		joinCondition = generatedJoinCondition.newInstance(getRuntimeContext().getUserCodeClassLoader());
+		joinCondition.setRuntimeContext(getRuntimeContext());
+		joinCondition.open(new Configuration());
+
+		nextLeftIndex = getRuntimeContext().getState(
+			new ValueStateDescriptor<>(NEXT_LEFT_INDEX_STATE_NAME, Types.LONG));
+		leftState = getRuntimeContext().getMapState(
+			new MapStateDescriptor<>(LEFT_STATE_NAME, Types.LONG, leftType));
+		rightState = getRuntimeContext().getMapState(
+			new MapStateDescriptor<>(RIGHT_STATE_NAME, rightType, Types.LONG));
+		registeredEventTimer = getRuntimeContext().getState(
+			new ValueStateDescriptor<>(REGISTERED_TIMER_STATE_NAME, Types.LONG));
+
+		timerService = getInternalTimerService(
+			TIMERS_STATE_NAME, VoidNamespaceSerializer.INSTANCE, this);
+
+		outRow = new JoinedRowData();
+		rightNullRow = new GenericRowData(rightType.toRowType().getFieldCount());
+		collector = new TimestampedCollector<>(output);
+	}
+
+	@Override
+	public void processElement1(StreamRecord<RowData> element) throws Exception {
+		RowData row = element.getValue();
+		leftState.put(getNextLeftIndex(), row);
+		registerSmallestTimer(getLeftTime(row)); // Timer to emit and clean up the state
+
+		registerProcessingCleanupTimer();
+	}
+
+	/**
+	 * We skip all -U message here, currently -U message is useless in versioned table.
+	 * case 1: the -U message may use update message's time, for example: rightState = [1(+I), 4(-U), 4(+U)],
+	 * case 2: the -U message may use insert message's time, for example: rightState = [1(+I), 1(-U), 4(+U)],
+	 * the valid period of them should be [1, 4) and [4, Long.MaxValue).
+	 */
+	@Override
+	public void processElement2(StreamRecord<RowData> element) throws Exception {
+		RowData row = element.getValue();
+		if (row.getRowKind() == RowKind.UPDATE_BEFORE) {
+			return;

Review comment:
       I don't think we can skip all -U messages here, because the -U message might be useful. The optimizer has already  tried to not send -U to temporal join, if the temporal join still receives -U, that means the -U is necessary. For example, filter after changelog source. 
   
   You can add a test for temporal join a changelog source with filter, and having a currency whose currency changes from 90 to 110. E.g.
   
   ```
   SELECT *
   FROM orders  AS O
   LEFT JOIN (SELECT * FROM currency WHERE rate > 100)  FOR SYSTEM_TIME AS OF O.rowtime AS C
   ON O.currency_id = C.currency_id
   ```

##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperator.java
##########
@@ -0,0 +1,437 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.join.temporal;
+
+import org.apache.flink.api.common.state.MapState;
+import org.apache.flink.api.common.state.MapStateDescriptor;
+import org.apache.flink.api.common.state.ValueState;
+import org.apache.flink.api.common.state.ValueStateDescriptor;
+import org.apache.flink.api.common.typeinfo.Types;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.runtime.state.VoidNamespace;
+import org.apache.flink.runtime.state.VoidNamespaceSerializer;
+import org.apache.flink.streaming.api.operators.InternalTimer;
+import org.apache.flink.streaming.api.operators.InternalTimerService;
+import org.apache.flink.streaming.api.operators.TimestampedCollector;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.table.data.GenericRowData;
+import org.apache.flink.table.data.JoinedRowData;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.data.util.RowDataUtil;
+import org.apache.flink.table.runtime.generated.GeneratedJoinCondition;
+import org.apache.flink.table.runtime.generated.JoinCondition;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.types.RowKind;
+
+import java.io.IOException;
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Comparator;
+import java.util.Iterator;
+import java.util.List;
+import java.util.ListIterator;
+import java.util.Map;
+import java.util.Optional;
+
+/**
+ * The operator for temporal join (FOR SYSTEM_TIME AS OF o.rowtime) on row time, it has no limitation
+ * about message types of the left input and right input, this means the operator deals changelog well.
+ *
+ * <p>For Event-time temporal join, its probe side is a regular table, its build side is a versioned
+ * table, the version of versioned table can extract from the build side state. This operator works by
+ * keeping on the state collection of probe and build records to process on next watermark. The idea
+ * is that between watermarks we are collecting those elements and once we are sure that there will be
+ * no updates we emit the correct result and clean up the expired data in state.
+ *
+ * <p>Cleaning up the state drops all of the "old" values from the probe side, where "old" is defined
+ * as older then the current watermark. Build side is also cleaned up in the similar fashion,
+ * we sort all "old" values with row time and row kind and then clean up the old values, when clean up
+ * the "old" values, if the latest record of all "old" values is retract message which means the version
+ * end, we clean all "old" values, if the the latest record is accumulate message which means the version
+ * start, we keep the latest one, and clear other "old" values.
+ *
+ * <p>One more trick is how the emitting results and cleaning up is triggered. It is achieved
+ * by registering timers for the keys. We could register a timer for every probe and build
+ * side element's event time (when watermark exceeds this timer, that's when we are emitting and/or
+ * cleaning up the state). However this would cause huge number of registered timers. For example
+ * with following evenTimes of probe records accumulated: {1, 2, 5, 8, 9}, if we
+ * had received Watermark(10), it would trigger 5 separate timers for the same key. To avoid that
+ * we always keep only one single registered timer for any given key, registered for the minimal
+ * value. Upon triggering it, we process all records with event times older then or equal to
+ * currentWatermark.
+ */
+public class TemporalRowTimeJoinOperator
+	extends BaseTwoInputStreamOperatorWithStateRetention {
+
+	private static final long serialVersionUID = 1L;
+
+	private static final String NEXT_LEFT_INDEX_STATE_NAME = "next-index";
+	private static final String LEFT_STATE_NAME = "left";
+	private static final String RIGHT_STATE_NAME = "right";
+	private static final String REGISTERED_TIMER_STATE_NAME = "timer";
+	private static final String TIMERS_STATE_NAME = "timers";
+
+	private final boolean isLeftOuterJoin;
+	private final InternalTypeInfo<RowData> leftType;
+	private final InternalTypeInfo<RowData> rightType;
+	private final GeneratedJoinCondition generatedJoinCondition;
+	private final int leftTimeAttribute;
+	private final int rightTimeAttribute;
+
+	/**
+	 * The comparator to get ordered elements of right state.
+	 */
+	private final ChangelogOrderComparator rightChangelogOrderComparator;
+
+	/**
+	 * Incremental index generator for {@link #leftState}'s keys.
+	 */
+	private transient ValueState<Long> nextLeftIndex;
+
+	/**
+	 * Mapping from artificial row index (generated by `nextLeftIndex`) into the left side `Row`.
+	 * We can not use List to accumulate Rows, because we need efficient deletes of the oldest rows.
+	 */
+	private transient MapState<Long, RowData> leftState;
+
+	/**
+	 * Mapping from timestamp to right side `Row`.
+	 **/
+	private transient MapState<RowData, Long> rightState;

Review comment:
       This can be `MapState<Long, RowData>` to have better performance as we discussed. 

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -18,232 +18,453 @@
 
 package org.apache.flink.table.planner.runtime.stream.sql
 
-import org.apache.flink.api.scala._
-import org.apache.flink.streaming.api.TimeCharacteristic
-import org.apache.flink.streaming.api.functions.timestamps.BoundedOutOfOrdernessTimestampExtractor
-import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
-import org.apache.flink.streaming.api.windowing.time.Time
-import org.apache.flink.table.api._
-import org.apache.flink.table.api.bridge.scala._
 import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase.StateBackendMode
-import org.apache.flink.table.planner.runtime.utils.{StreamingWithStateTestBase, TestingAppendSink}
-import org.apache.flink.table.planner.utils.TableTestUtil
-import org.apache.flink.types.Row
-
+import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase
 import org.junit.Assert.assertEquals
 import org.junit._
 import org.junit.runner.RunWith
 import org.junit.runners.Parameterized
+import java.lang.{Long => JLong}
+import java.time.LocalDateTime
+
+import scala.collection.JavaConversions._
 
-import java.sql.Timestamp
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.changelogRow
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.getRawResults
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.registerData
 
-import scala.collection.mutable
 
 @RunWith(classOf[Parameterized])
 class TemporalJoinITCase(state: StateBackendMode)
   extends StreamingWithStateTestBase(state) {
 
+  // test data for Processing-Time temporal table join
+  val procTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12)),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(14)),
+    changelogRow("+I", toJLong(3), "US Dollar", "no2", toJLong(18)),
+    changelogRow("+I", toJLong(4), "RMB", "no1", toJLong(40)),
+    // simply test left stream could be changelog,
+    // -U or -D message may retract fail in COLLECTION sink check
+    changelogRow("+U", toJLong(4), "RMB", "no1", toJLong(60)))
+
+  val procTimeCurrencyData = List(
+    changelogRow("+I","Euro", "no1", toJLong(114)),
+    changelogRow("+I","US Dollar", "no1", toJLong(102)),
+    changelogRow("+I","Yen", "no1", toJLong(1)),
+    changelogRow("+I","RMB", "no1", toJLong(702)),
+    changelogRow("+I","Euro", "no1", toJLong(118)),
+    changelogRow("+I","US Dollar", "no2", toJLong(106)))
+
+  // test data for Event-Time temporal table join
+  val rowTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12),
+      toDateTime("2020-08-15T00:01:00")),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:02:00")),
+    changelogRow("+I", toJLong(3), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-15T00:03:00")),
+    changelogRow("+I", toJLong(4), "Euro", "no1", toJLong(14),
+      toDateTime("2020-08-16T00:02:00")),
+    // simply test left stream could be changelog,
+    // -U or -D message may retract fail in collection connector sink implementation
+    changelogRow("+U", toJLong(5), "US Dollar", "no1", toJLong(18),
+      toDateTime("2020-08-16T00:03:00")),
+    changelogRow("+I", toJLong(6), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-16T00:03:00")))
+
+  val rowTimeCurrencyData = List(
+    changelogRow("+I", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "Yen", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "RMB", "no1", toJLong(702),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("-U", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("+U", "Euro",  "no1", toJLong(118),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("-U", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("+U", "US Dollar",  "no1", toJLong(106),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("-D","RMB", "no1", toJLong(708),
+      toDateTime("2020-08-16T00:02:00")))

Review comment:
       Could you add a test that the rowtime in delete message is previous time in insert message?

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -18,232 +18,453 @@
 
 package org.apache.flink.table.planner.runtime.stream.sql
 
-import org.apache.flink.api.scala._
-import org.apache.flink.streaming.api.TimeCharacteristic
-import org.apache.flink.streaming.api.functions.timestamps.BoundedOutOfOrdernessTimestampExtractor
-import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
-import org.apache.flink.streaming.api.windowing.time.Time
-import org.apache.flink.table.api._
-import org.apache.flink.table.api.bridge.scala._
 import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase.StateBackendMode
-import org.apache.flink.table.planner.runtime.utils.{StreamingWithStateTestBase, TestingAppendSink}
-import org.apache.flink.table.planner.utils.TableTestUtil
-import org.apache.flink.types.Row
-
+import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase
 import org.junit.Assert.assertEquals
 import org.junit._
 import org.junit.runner.RunWith
 import org.junit.runners.Parameterized
+import java.lang.{Long => JLong}
+import java.time.LocalDateTime
+
+import scala.collection.JavaConversions._
 
-import java.sql.Timestamp
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.changelogRow
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.getRawResults
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.registerData
 
-import scala.collection.mutable
 
 @RunWith(classOf[Parameterized])
 class TemporalJoinITCase(state: StateBackendMode)
   extends StreamingWithStateTestBase(state) {
 
+  // test data for Processing-Time temporal table join
+  val procTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12)),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(14)),
+    changelogRow("+I", toJLong(3), "US Dollar", "no2", toJLong(18)),
+    changelogRow("+I", toJLong(4), "RMB", "no1", toJLong(40)),
+    // simply test left stream could be changelog,
+    // -U or -D message may retract fail in COLLECTION sink check
+    changelogRow("+U", toJLong(4), "RMB", "no1", toJLong(60)))
+
+  val procTimeCurrencyData = List(
+    changelogRow("+I","Euro", "no1", toJLong(114)),
+    changelogRow("+I","US Dollar", "no1", toJLong(102)),
+    changelogRow("+I","Yen", "no1", toJLong(1)),
+    changelogRow("+I","RMB", "no1", toJLong(702)),
+    changelogRow("+I","Euro", "no1", toJLong(118)),
+    changelogRow("+I","US Dollar", "no2", toJLong(106)))
+
+  // test data for Event-Time temporal table join
+  val rowTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12),
+      toDateTime("2020-08-15T00:01:00")),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:02:00")),
+    changelogRow("+I", toJLong(3), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-15T00:03:00")),
+    changelogRow("+I", toJLong(4), "Euro", "no1", toJLong(14),
+      toDateTime("2020-08-16T00:02:00")),
+    // simply test left stream could be changelog,
+    // -U or -D message may retract fail in collection connector sink implementation
+    changelogRow("+U", toJLong(5), "US Dollar", "no1", toJLong(18),
+      toDateTime("2020-08-16T00:03:00")),
+    changelogRow("+I", toJLong(6), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-16T00:03:00")))
+
+  val rowTimeCurrencyData = List(
+    changelogRow("+I", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "Yen", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "RMB", "no1", toJLong(702),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("-U", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("+U", "Euro",  "no1", toJLong(118),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("-U", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("+U", "US Dollar",  "no1", toJLong(106),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("-D","RMB", "no1", toJLong(708),
+      toDateTime("2020-08-16T00:02:00")))
+
+  @Before
+  def prepare(): Unit = {
+    env.setParallelism(2)
+
+    val procTimeOrderDataId = registerData(procTimeOrderData)
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE orders_proctime (
+         |  order_id BIGINT,
+         |  currency STRING,
+         |  currency_no STRING,
+         |  amount BIGINT,
+         |  proctime as PROCTIME()
+         |) WITH (
+         |  'connector' = 'values',
+         |  'bounded' = 'false',
+         |  'changelog-mode' = 'I,UA,UB,D',
+         |  'data-id' = '$procTimeOrderDataId'
+         |)
+         |""".stripMargin)
+
+    // register a non-lookup table
+    val procTimeCurrencyDataId = registerData(procTimeCurrencyData)
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE currency_proctime (
+         |  currency STRING,
+         |  currency_no STRING,
+         |  rate BIGINT,
+         |  proctime as PROCTIME()
+         |) WITH (
+         |  'connector' = 'values',
+         |  'bounded' = 'false',
+         |  'disable-lookup' = 'true',
+         |  'data-id' = '$procTimeCurrencyDataId'
+         |)
+         |""".stripMargin)
+
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE changelog_currency_proctime (
+         |  currency STRING,
+         |  currency_no STRING,
+         |  rate BIGINT,
+         |  proctime as PROCTIME()
+         |) WITH (
+         |  'connector' = 'values',
+         |  'bounded' = 'false',
+         |  'disable-lookup' = 'true',
+         |  'changelog-mode' = 'I,UA,UB,D',
+         |  'data-id' = '$procTimeCurrencyDataId'
+         |)
+         |""".stripMargin)
+
+    tEnv.executeSql(
+      s"""
+         |CREATE VIEW latest_rates AS
+         |SELECT
+         |  currency,
+         |  currency_no,
+         |  rate,
+         |  proctime FROM
+         |      ( SELECT *, ROW_NUMBER() OVER (PARTITION BY currency, currency_no
+         |        ORDER BY proctime DESC) AS rowNum
+         |        FROM currency_proctime) T
+         | WHERE rowNum = 1""".stripMargin)
+
+    val rowTimeOrderDataId = registerData(rowTimeOrderData)
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE orders_rowtime (
+         |  order_id BIGINT,
+         |  currency STRING,
+         |  currency_no STRING,
+         |  amount BIGINT,
+         |  order_time TIMESTAMP(3),
+         |  WATERMARK FOR order_time AS order_time
+         |) WITH (
+         |  'connector' = 'values',
+         |  'data-id' = '$rowTimeOrderDataId'

Review comment:
       The source is insert-only, however the data `rowTimeOrderData` contains updates. 

##########
File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperatorTest.java
##########
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.join.temporal;
+
+import org.apache.flink.streaming.api.watermark.Watermark;
+import org.apache.flink.streaming.util.KeyedTwoInputStreamOperatorTestHarness;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.types.RowKind;
+
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.apache.flink.table.runtime.util.StreamRecordUtils.insertRecord;
+import static org.apache.flink.table.runtime.util.StreamRecordUtils.record;
+
+/**
+ * Harness tests for {@link TemporalRowTimeJoinOperatorTest}.
+ */
+public class TemporalRowTimeJoinOperatorTest extends TemporalTimeJoinOperatorTestBase {
+	/**
+	 * Test rowtime temporal join.
+	 */
+	@Test
+	public void testRowTimeTemporalJoin() throws Exception {
+		List<Object> expectedOutput = new ArrayList<>();
+		expectedOutput.add(new Watermark(1));
+		expectedOutput.add(new Watermark(2));
+		expectedOutput.add(insertRecord(3L, "k1", "1a3", 2L, "k1", "1a2"));
+		expectedOutput.add(new Watermark(5));
+		expectedOutput.add(insertRecord(6L, "k2", "2a3", 4L, "k2", "2a4"));
+		expectedOutput.add(new Watermark(8));
+		expectedOutput.add(new Watermark(9));
+		expectedOutput.add(insertRecord(11L, "k2", "5a12", 10L, "k2", "2a6"));
+		expectedOutput.add(new Watermark(13));
+
+		testRowTimeTemporalJoin(false, expectedOutput);
+	}
+
+	/**
+	 * Test rowtime left temporal join.
+	 */
+	@Test
+	public void testRowTimeLeftTemporalJoin() throws Exception {
+		List<Object> expectedOutput = new ArrayList<>();
+		expectedOutput.add(new Watermark(1));
+		expectedOutput.add(insertRecord(1L, "k1", "1a1", null, null, null));
+		expectedOutput.add(new Watermark(2));
+		expectedOutput.add(insertRecord(1L, "k1", "1a1", null, null, null));
+		expectedOutput.add(insertRecord(3L, "k1", "1a3", 2L, "k1", "1a2"));
+		expectedOutput.add(new Watermark(5));
+		expectedOutput.add(insertRecord(6L, "k2", "2a3", 4L, "k2", "2a4"));
+		expectedOutput.add(new Watermark(8));
+		expectedOutput.add(insertRecord(9L, "k2", "5a11", null, null, null));
+		expectedOutput.add(new Watermark(9));
+		expectedOutput.add(insertRecord(11L, "k2", "5a12", 10L, "k2", "2a6"));
+		expectedOutput.add(new Watermark(13));
+
+		testRowTimeTemporalJoin(true, expectedOutput);
+	}
+
+	private void testRowTimeTemporalJoin(boolean isLeftOuterJoin, List<Object> expectedOutput) throws Exception {
+		TemporalRowTimeJoinOperator joinOperator = new TemporalRowTimeJoinOperator(
+				rowType,
+				rowType,
+				joinCondition,
+				0,
+				0,
+				0,
+				0,
+				isLeftOuterJoin);
+		KeyedTwoInputStreamOperatorTestHarness<RowData, RowData, RowData, RowData> testHarness = createTestHarness(
+				joinOperator);
+
+		testHarness.open();
+
+		testHarness.processWatermark1(new Watermark(1));
+		testHarness.processWatermark2(new Watermark(1));
+
+		testHarness.processElement1(insertRecord(1L, "k1", "1a1"));
+		testHarness.processElement2(record(RowKind.INSERT, 2L, "k1", "1a2"));

Review comment:
       It would be better to not mix `insertRecord` and `record(RowKind.INSERT, ...)`.

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -18,232 +18,453 @@
 
 package org.apache.flink.table.planner.runtime.stream.sql
 
-import org.apache.flink.api.scala._
-import org.apache.flink.streaming.api.TimeCharacteristic
-import org.apache.flink.streaming.api.functions.timestamps.BoundedOutOfOrdernessTimestampExtractor
-import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
-import org.apache.flink.streaming.api.windowing.time.Time
-import org.apache.flink.table.api._
-import org.apache.flink.table.api.bridge.scala._
 import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase.StateBackendMode
-import org.apache.flink.table.planner.runtime.utils.{StreamingWithStateTestBase, TestingAppendSink}
-import org.apache.flink.table.planner.utils.TableTestUtil
-import org.apache.flink.types.Row
-
+import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase
 import org.junit.Assert.assertEquals
 import org.junit._
 import org.junit.runner.RunWith
 import org.junit.runners.Parameterized
+import java.lang.{Long => JLong}
+import java.time.LocalDateTime
+
+import scala.collection.JavaConversions._
 
-import java.sql.Timestamp
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.changelogRow
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.getRawResults
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.registerData
 
-import scala.collection.mutable
 
 @RunWith(classOf[Parameterized])
 class TemporalJoinITCase(state: StateBackendMode)
   extends StreamingWithStateTestBase(state) {
 
+  // test data for Processing-Time temporal table join
+  val procTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12)),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(14)),
+    changelogRow("+I", toJLong(3), "US Dollar", "no2", toJLong(18)),
+    changelogRow("+I", toJLong(4), "RMB", "no1", toJLong(40)),
+    // simply test left stream could be changelog,
+    // -U or -D message may retract fail in COLLECTION sink check
+    changelogRow("+U", toJLong(4), "RMB", "no1", toJLong(60)))
+
+  val procTimeCurrencyData = List(
+    changelogRow("+I","Euro", "no1", toJLong(114)),
+    changelogRow("+I","US Dollar", "no1", toJLong(102)),
+    changelogRow("+I","Yen", "no1", toJLong(1)),
+    changelogRow("+I","RMB", "no1", toJLong(702)),
+    changelogRow("+I","Euro", "no1", toJLong(118)),
+    changelogRow("+I","US Dollar", "no2", toJLong(106)))
+
+  // test data for Event-Time temporal table join
+  val rowTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12),
+      toDateTime("2020-08-15T00:01:00")),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:02:00")),
+    changelogRow("+I", toJLong(3), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-15T00:03:00")),
+    changelogRow("+I", toJLong(4), "Euro", "no1", toJLong(14),
+      toDateTime("2020-08-16T00:02:00")),
+    // simply test left stream could be changelog,
+    // -U or -D message may retract fail in collection connector sink implementation
+    changelogRow("+U", toJLong(5), "US Dollar", "no1", toJLong(18),
+      toDateTime("2020-08-16T00:03:00")),
+    changelogRow("+I", toJLong(6), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-16T00:03:00")))
+
+  val rowTimeCurrencyData = List(
+    changelogRow("+I", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "Yen", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "RMB", "no1", toJLong(702),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("-U", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("+U", "Euro",  "no1", toJLong(118),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("-U", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("+U", "US Dollar",  "no1", toJLong(106),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("-D","RMB", "no1", toJLong(708),
+      toDateTime("2020-08-16T00:02:00")))
+
+  @Before
+  def prepare(): Unit = {
+    env.setParallelism(2)

Review comment:
       Why not use the default 4 parallelism? Can we remove this?

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -18,232 +18,453 @@
 
 package org.apache.flink.table.planner.runtime.stream.sql
 
-import org.apache.flink.api.scala._
-import org.apache.flink.streaming.api.TimeCharacteristic
-import org.apache.flink.streaming.api.functions.timestamps.BoundedOutOfOrdernessTimestampExtractor
-import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
-import org.apache.flink.streaming.api.windowing.time.Time
-import org.apache.flink.table.api._
-import org.apache.flink.table.api.bridge.scala._
 import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase.StateBackendMode
-import org.apache.flink.table.planner.runtime.utils.{StreamingWithStateTestBase, TestingAppendSink}
-import org.apache.flink.table.planner.utils.TableTestUtil
-import org.apache.flink.types.Row
-
+import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase
 import org.junit.Assert.assertEquals
 import org.junit._
 import org.junit.runner.RunWith
 import org.junit.runners.Parameterized
+import java.lang.{Long => JLong}
+import java.time.LocalDateTime
+
+import scala.collection.JavaConversions._
 
-import java.sql.Timestamp
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.changelogRow
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.getRawResults
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.registerData
 
-import scala.collection.mutable
 
 @RunWith(classOf[Parameterized])
 class TemporalJoinITCase(state: StateBackendMode)
   extends StreamingWithStateTestBase(state) {
 
+  // test data for Processing-Time temporal table join
+  val procTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12)),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(14)),
+    changelogRow("+I", toJLong(3), "US Dollar", "no2", toJLong(18)),
+    changelogRow("+I", toJLong(4), "RMB", "no1", toJLong(40)),
+    // simply test left stream could be changelog,
+    // -U or -D message may retract fail in COLLECTION sink check
+    changelogRow("+U", toJLong(4), "RMB", "no1", toJLong(60)))
+
+  val procTimeCurrencyData = List(
+    changelogRow("+I","Euro", "no1", toJLong(114)),
+    changelogRow("+I","US Dollar", "no1", toJLong(102)),
+    changelogRow("+I","Yen", "no1", toJLong(1)),
+    changelogRow("+I","RMB", "no1", toJLong(702)),
+    changelogRow("+I","Euro", "no1", toJLong(118)),
+    changelogRow("+I","US Dollar", "no2", toJLong(106)))
+
+  // test data for Event-Time temporal table join
+  val rowTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12),
+      toDateTime("2020-08-15T00:01:00")),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:02:00")),
+    changelogRow("+I", toJLong(3), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-15T00:03:00")),
+    changelogRow("+I", toJLong(4), "Euro", "no1", toJLong(14),
+      toDateTime("2020-08-16T00:02:00")),
+    // simply test left stream could be changelog,
+    // -U or -D message may retract fail in collection connector sink implementation
+    changelogRow("+U", toJLong(5), "US Dollar", "no1", toJLong(18),
+      toDateTime("2020-08-16T00:03:00")),
+    changelogRow("+I", toJLong(6), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-16T00:03:00")))
+
+  val rowTimeCurrencyData = List(
+    changelogRow("+I", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "Yen", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "RMB", "no1", toJLong(702),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("-U", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("+U", "Euro",  "no1", toJLong(118),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("-U", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("+U", "US Dollar",  "no1", toJLong(106),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("-D","RMB", "no1", toJLong(708),
+      toDateTime("2020-08-16T00:02:00")))
+
+  @Before
+  def prepare(): Unit = {
+    env.setParallelism(2)
+
+    val procTimeOrderDataId = registerData(procTimeOrderData)
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE orders_proctime (
+         |  order_id BIGINT,
+         |  currency STRING,
+         |  currency_no STRING,
+         |  amount BIGINT,
+         |  proctime as PROCTIME()
+         |) WITH (
+         |  'connector' = 'values',
+         |  'bounded' = 'false',
+         |  'changelog-mode' = 'I,UA,UB,D',
+         |  'data-id' = '$procTimeOrderDataId'
+         |)
+         |""".stripMargin)
+
+    // register a non-lookup table
+    val procTimeCurrencyDataId = registerData(procTimeCurrencyData)
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE currency_proctime (
+         |  currency STRING,
+         |  currency_no STRING,
+         |  rate BIGINT,
+         |  proctime as PROCTIME()
+         |) WITH (
+         |  'connector' = 'values',
+         |  'bounded' = 'false',
+         |  'disable-lookup' = 'true',
+         |  'data-id' = '$procTimeCurrencyDataId'
+         |)
+         |""".stripMargin)
+
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE changelog_currency_proctime (
+         |  currency STRING,
+         |  currency_no STRING,
+         |  rate BIGINT,
+         |  proctime as PROCTIME()
+         |) WITH (
+         |  'connector' = 'values',
+         |  'bounded' = 'false',
+         |  'disable-lookup' = 'true',
+         |  'changelog-mode' = 'I,UA,UB,D',
+         |  'data-id' = '$procTimeCurrencyDataId'
+         |)
+         |""".stripMargin)
+
+    tEnv.executeSql(
+      s"""
+         |CREATE VIEW latest_rates AS
+         |SELECT
+         |  currency,
+         |  currency_no,
+         |  rate,
+         |  proctime FROM
+         |      ( SELECT *, ROW_NUMBER() OVER (PARTITION BY currency, currency_no
+         |        ORDER BY proctime DESC) AS rowNum
+         |        FROM currency_proctime) T
+         | WHERE rowNum = 1""".stripMargin)
+
+    val rowTimeOrderDataId = registerData(rowTimeOrderData)
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE orders_rowtime (
+         |  order_id BIGINT,
+         |  currency STRING,
+         |  currency_no STRING,
+         |  amount BIGINT,
+         |  order_time TIMESTAMP(3),
+         |  WATERMARK FOR order_time AS order_time
+         |) WITH (
+         |  'connector' = 'values',
+         |  'data-id' = '$rowTimeOrderDataId'
+         |)
+         |""".stripMargin)
+
+    val rowTimeCurrencyDataId = registerData(rowTimeCurrencyData)
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE versioned_currency_with_single_key (
+         |  currency STRING,
+         |  currency_no STRING,
+         |  rate  BIGINT,
+         |  currency_time TIMESTAMP(3),
+         |  WATERMARK FOR currency_time AS currency_time - interval '10' SECOND,
+         |  PRIMARY KEY(currency) NOT ENFORCED
+         |) WITH (
+         |  'connector' = 'values',
+         |  'data-id' = '$rowTimeCurrencyDataId'

Review comment:
       The source is insert-only, however the data `rowTimeCurrencyData` contains updates.
   
   

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -18,232 +18,453 @@
 
 package org.apache.flink.table.planner.runtime.stream.sql
 
-import org.apache.flink.api.scala._
-import org.apache.flink.streaming.api.TimeCharacteristic
-import org.apache.flink.streaming.api.functions.timestamps.BoundedOutOfOrdernessTimestampExtractor
-import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
-import org.apache.flink.streaming.api.windowing.time.Time
-import org.apache.flink.table.api._
-import org.apache.flink.table.api.bridge.scala._
 import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase.StateBackendMode
-import org.apache.flink.table.planner.runtime.utils.{StreamingWithStateTestBase, TestingAppendSink}
-import org.apache.flink.table.planner.utils.TableTestUtil
-import org.apache.flink.types.Row
-
+import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase
 import org.junit.Assert.assertEquals
 import org.junit._
 import org.junit.runner.RunWith
 import org.junit.runners.Parameterized
+import java.lang.{Long => JLong}
+import java.time.LocalDateTime
+
+import scala.collection.JavaConversions._
 
-import java.sql.Timestamp
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.changelogRow
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.getRawResults
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.registerData
 
-import scala.collection.mutable
 
 @RunWith(classOf[Parameterized])
 class TemporalJoinITCase(state: StateBackendMode)
   extends StreamingWithStateTestBase(state) {
 
+  // test data for Processing-Time temporal table join
+  val procTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12)),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(14)),
+    changelogRow("+I", toJLong(3), "US Dollar", "no2", toJLong(18)),
+    changelogRow("+I", toJLong(4), "RMB", "no1", toJLong(40)),
+    // simply test left stream could be changelog,
+    // -U or -D message may retract fail in COLLECTION sink check
+    changelogRow("+U", toJLong(4), "RMB", "no1", toJLong(60)))
+
+  val procTimeCurrencyData = List(
+    changelogRow("+I","Euro", "no1", toJLong(114)),
+    changelogRow("+I","US Dollar", "no1", toJLong(102)),
+    changelogRow("+I","Yen", "no1", toJLong(1)),
+    changelogRow("+I","RMB", "no1", toJLong(702)),
+    changelogRow("+I","Euro", "no1", toJLong(118)),
+    changelogRow("+I","US Dollar", "no2", toJLong(106)))
+
+  // test data for Event-Time temporal table join
+  val rowTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12),
+      toDateTime("2020-08-15T00:01:00")),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:02:00")),
+    changelogRow("+I", toJLong(3), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-15T00:03:00")),
+    changelogRow("+I", toJLong(4), "Euro", "no1", toJLong(14),
+      toDateTime("2020-08-16T00:02:00")),
+    // simply test left stream could be changelog,
+    // -U or -D message may retract fail in collection connector sink implementation
+    changelogRow("+U", toJLong(5), "US Dollar", "no1", toJLong(18),
+      toDateTime("2020-08-16T00:03:00")),
+    changelogRow("+I", toJLong(6), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-16T00:03:00")))
+
+  val rowTimeCurrencyData = List(
+    changelogRow("+I", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "Yen", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "RMB", "no1", toJLong(702),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("-U", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("+U", "Euro",  "no1", toJLong(118),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("-U", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("+U", "US Dollar",  "no1", toJLong(106),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("-D","RMB", "no1", toJLong(708),
+      toDateTime("2020-08-16T00:02:00")))
+
+  @Before
+  def prepare(): Unit = {
+    env.setParallelism(2)
+
+    val procTimeOrderDataId = registerData(procTimeOrderData)
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE orders_proctime (
+         |  order_id BIGINT,
+         |  currency STRING,
+         |  currency_no STRING,
+         |  amount BIGINT,
+         |  proctime as PROCTIME()
+         |) WITH (
+         |  'connector' = 'values',
+         |  'bounded' = 'false',
+         |  'changelog-mode' = 'I,UA,UB,D',
+         |  'data-id' = '$procTimeOrderDataId'
+         |)
+         |""".stripMargin)
+
+    // register a non-lookup table
+    val procTimeCurrencyDataId = registerData(procTimeCurrencyData)
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE currency_proctime (
+         |  currency STRING,
+         |  currency_no STRING,
+         |  rate BIGINT,
+         |  proctime as PROCTIME()
+         |) WITH (
+         |  'connector' = 'values',
+         |  'bounded' = 'false',
+         |  'disable-lookup' = 'true',
+         |  'data-id' = '$procTimeCurrencyDataId'
+         |)
+         |""".stripMargin)
+
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE changelog_currency_proctime (
+         |  currency STRING,
+         |  currency_no STRING,
+         |  rate BIGINT,
+         |  proctime as PROCTIME()
+         |) WITH (
+         |  'connector' = 'values',
+         |  'bounded' = 'false',
+         |  'disable-lookup' = 'true',
+         |  'changelog-mode' = 'I,UA,UB,D',
+         |  'data-id' = '$procTimeCurrencyDataId'
+         |)
+         |""".stripMargin)
+
+    tEnv.executeSql(
+      s"""
+         |CREATE VIEW latest_rates AS
+         |SELECT
+         |  currency,
+         |  currency_no,
+         |  rate,
+         |  proctime FROM
+         |      ( SELECT *, ROW_NUMBER() OVER (PARTITION BY currency, currency_no
+         |        ORDER BY proctime DESC) AS rowNum
+         |        FROM currency_proctime) T
+         | WHERE rowNum = 1""".stripMargin)
+
+    val rowTimeOrderDataId = registerData(rowTimeOrderData)
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE orders_rowtime (
+         |  order_id BIGINT,
+         |  currency STRING,
+         |  currency_no STRING,
+         |  amount BIGINT,
+         |  order_time TIMESTAMP(3),
+         |  WATERMARK FOR order_time AS order_time
+         |) WITH (
+         |  'connector' = 'values',
+         |  'data-id' = '$rowTimeOrderDataId'
+         |)
+         |""".stripMargin)
+
+    val rowTimeCurrencyDataId = registerData(rowTimeCurrencyData)
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE versioned_currency_with_single_key (
+         |  currency STRING,
+         |  currency_no STRING,
+         |  rate  BIGINT,
+         |  currency_time TIMESTAMP(3),
+         |  WATERMARK FOR currency_time AS currency_time - interval '10' SECOND,
+         |  PRIMARY KEY(currency) NOT ENFORCED
+         |) WITH (
+         |  'connector' = 'values',
+         |  'data-id' = '$rowTimeCurrencyDataId'
+         |)
+         |""".stripMargin)
+
+    tEnv.executeSql(
+      s"""
+         |CREATE TABLE versioned_currency_with_multi_key (
+         |  currency STRING,
+         |  currency_no STRING,
+         |  rate  BIGINT,
+         |  currency_time TIMESTAMP(3),
+         |  WATERMARK FOR currency_time AS currency_time - interval '10' SECOND,
+         |  PRIMARY KEY(currency, currency_no) NOT ENFORCED
+         |) WITH (
+         |  'connector' = 'values',
+         |  'data-id' = '$rowTimeCurrencyDataId'

Review comment:
       ditto.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee9ebd0a1947e6580064910a0dace6f5e349c52 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4174635af1c0de52685df1ffb1b2adc869256d18 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820) 
   * 7ad79c6528d529ebd03e87a78f92d79d8cb6d91f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 62bb7f7e511775b0b65003e65aa13b27c760da27 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236) 
   * 0edbb09cea1b10a677b91c17b889ec74ef8dfbed Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7ad79c6528d529ebd03e87a78f92d79d8cb6d91f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126) 
   * 62bb7f7e511775b0b65003e65aa13b27c760da27 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-719126981


   Build is passed: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=8611&view=results
   Merging...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f148274d5bcdf7177561a2f659ba9fc718af0054 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483",
       "triggerID" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525",
       "triggerID" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8546",
       "triggerID" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f8a62099663b658669488af7f0ecd5087d1e5da6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525) 
   * 9f912a17d777463b856a19b64a03c16adadb8a73 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8546) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 62bb7f7e511775b0b65003e65aa13b27c760da27 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4174635af1c0de52685df1ffb1b2adc869256d18 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820) 
   * 7ad79c6528d529ebd03e87a78f92d79d8cb6d91f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] leonardBang commented on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-718031512


   @wuchong  I've addressed your comments and rebase master, appreciate if you have time to review again.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483",
       "triggerID" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525",
       "triggerID" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a558cb0fd984dc5f256d7710f67239d0851204b3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483) 
   * f8a62099663b658669488af7f0ecd5087d1e5da6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] leonardBang commented on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-718031172


   address your comment and rebase master, appreciate if you have time to review again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7dc326d54c5ac31c352ac06c35d918f444d9bd40 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812) 
   * 3aae457c54d028a1c526a32e059b0836df8105c7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3aae457c54d028a1c526a32e059b0836df8105c7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813) 
   * 4174635af1c0de52685df1ffb1b2adc869256d18 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f148274d5bcdf7177561a2f659ba9fc718af0054 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483",
       "triggerID" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525",
       "triggerID" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8546",
       "triggerID" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a45a5a527afc2aae477c89ebf0dc047cc45a201d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8583",
       "triggerID" : "a45a5a527afc2aae477c89ebf0dc047cc45a201d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "896661af5940a86cd9fba9526aaf57a553d388cb",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8601",
       "triggerID" : "896661af5940a86cd9fba9526aaf57a553d388cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "896661af5940a86cd9fba9526aaf57a553d388cb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8611",
       "triggerID" : "718808063",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 896661af5940a86cd9fba9526aaf57a553d388cb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8601) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8611) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] leonardBang commented on a change in pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #13307:
URL: https://github.com/apache/flink/pull/13307#discussion_r513556517



##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperator.java
##########
@@ -294,6 +320,13 @@ private int indexOfFirstElementNewerThanTimer(long timerTimestamp, List<RowData>
 	/**
 	 * Binary search {@code rightRowsSorted} to find the latest right row to join with {@code leftTime}.
 	 * Latest means a right row with largest time that is still smaller or equal to {@code leftTime}.
+	 * For example with: rightState = [1(+I), 4(-U), 4(+U), 7(-U), 7(+U), 9(-D), 12(I)],

Review comment:
       Got your point, maybe this performance improvement is minor because (1) it only saves retraction records storage not all records (2) many retraction records between two watermarks  is not common, So I tend to improve it later if it's very important for performance




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483",
       "triggerID" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525",
       "triggerID" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8546",
       "triggerID" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a45a5a527afc2aae477c89ebf0dc047cc45a201d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8583",
       "triggerID" : "a45a5a527afc2aae477c89ebf0dc047cc45a201d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "896661af5940a86cd9fba9526aaf57a553d388cb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8601",
       "triggerID" : "896661af5940a86cd9fba9526aaf57a553d388cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "896661af5940a86cd9fba9526aaf57a553d388cb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8611",
       "triggerID" : "718808063",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * a45a5a527afc2aae477c89ebf0dc047cc45a201d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8583) 
   * 896661af5940a86cd9fba9526aaf57a553d388cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8601) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8611) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483",
       "triggerID" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525",
       "triggerID" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8546",
       "triggerID" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a45a5a527afc2aae477c89ebf0dc047cc45a201d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8583",
       "triggerID" : "a45a5a527afc2aae477c89ebf0dc047cc45a201d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9f912a17d777463b856a19b64a03c16adadb8a73 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8546) 
   * a45a5a527afc2aae477c89ebf0dc047cc45a201d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8583) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b9f1d43f8e46a0c79d2741c4d6061443ef9be599 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230) 
   * 7dc326d54c5ac31c352ac06c35d918f444d9bd40 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812) 
   * 3aae457c54d028a1c526a32e059b0836df8105c7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on a change in pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13307:
URL: https://github.com/apache/flink/pull/13307#discussion_r514126666



##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperator.java
##########
@@ -212,45 +217,63 @@ public void close() throws Exception {
 	 * @return a row time of the oldest unprocessed probe record or Long.MaxValue, if all records
 	 *         have been processed.
 	 */
-	private long emitResultAndCleanUpState(long timerTimestamp) throws Exception {
+	private long emitResultAndCleanUpState(long currentWatermark) throws Exception {
 		List<RowData> rightRowsSorted = getRightRowSorted(rightRowtimeComparator);
 		long lastUnprocessedTime = Long.MAX_VALUE;
 
 		Iterator<Map.Entry<Long, RowData>> leftIterator = leftState.entries().iterator();
+		// the output records's  order should keep same with left input records order
+		Map<Long, RowData> orderedLeftRecords = new TreeMap<>();

Review comment:
       nit: would be better to declare it as `final TreeMap<Long, RowData> orderedLeftRecords` to guarantee it must be a `TreeMap` and not changed. 

##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperator.java
##########
@@ -212,45 +217,63 @@ public void close() throws Exception {
 	 * @return a row time of the oldest unprocessed probe record or Long.MaxValue, if all records
 	 *         have been processed.
 	 */
-	private long emitResultAndCleanUpState(long timerTimestamp) throws Exception {
+	private long emitResultAndCleanUpState(long currentWatermark) throws Exception {
 		List<RowData> rightRowsSorted = getRightRowSorted(rightRowtimeComparator);
 		long lastUnprocessedTime = Long.MAX_VALUE;
 
 		Iterator<Map.Entry<Long, RowData>> leftIterator = leftState.entries().iterator();
+		// the output records's  order should keep same with left input records order
+		Map<Long, RowData> orderedLeftRecords = new TreeMap<>();
+
 		while (leftIterator.hasNext()) {
 			Map.Entry<Long, RowData> entry = leftIterator.next();
+			Long leftSeq = entry.getKey();
 			RowData leftRow = entry.getValue();
 			long leftTime = getLeftTime(leftRow);
-
-			if (leftTime <= timerTimestamp) {
-				Optional<RowData> rightRow = latestRightRowToJoin(rightRowsSorted, leftTime);
-				if (rightRow.isPresent()) {
-					if (joinCondition.apply(leftRow, rightRow.get())) {
-						outRow.replace(leftRow, rightRow.get());
-						collector.collect(outRow);
-					}
-				}
+			if (leftTime <= currentWatermark) {
+				orderedLeftRecords.put(leftSeq, leftRow);
 				leftIterator.remove();
 			} else {
 				lastUnprocessedTime = Math.min(lastUnprocessedTime, leftTime);
 			}
 		}
 
-		cleanupState(timerTimestamp, rightRowsSorted);
+		orderedLeftRecords.forEach((leftSeq, leftRow) -> {

Review comment:
       Add a comment that `iterator the triggered left records in the ascending order of the sequence key, i.e. the arrival order`. 

##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamExecTemporalJoin.scala
##########
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.plan.nodes.physical.stream
 
+import org.apache.flink.api.common.ExecutionConfig

Review comment:
       Remove useless imports.

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -260,6 +393,214 @@ class TemporalJoinITCase(state: StateBackendMode)
     tEnv.executeSql(sql).await()
   }
 
+  @Test
+  def testEventTimeTemporalJoin(): Unit = {
+    val sql = "INSERT INTO rowtime_default_sink " +
+      " SELECT o.order_id, o.currency, o.amount, o.order_time, r.rate, r.currency_time " +
+      " FROM orders_rowtime AS o JOIN versioned_currency_with_single_key " +
+      " FOR SYSTEM_TIME AS OF o.order_time as r " +
+      " ON o.currency = r.currency"
+
+    tEnv.executeSql(sql).await()
+    val rawResult = getRawResults("rowtime_default_sink")
+    val expected = List(
+      "+I(1,Euro,12,2020-08-15T00:01,114,2020-08-15T00:00:01)",
+      "+I(2,US Dollar,1,2020-08-15T00:02,102,2020-08-15T00:00:02)",
+      "+I(3,RMB,40,2020-08-15T00:03,702,2020-08-15T00:00:04)",
+      "+I(4,Euro,14,2020-08-16T00:04,118,2020-08-16T00:01)",
+      "-U(2,US Dollar,1,2020-08-16T00:03,106,2020-08-16T00:02)",
+      "+U(2,US Dollar,18,2020-08-16T00:03,106,2020-08-16T00:02)")
+    assertEquals(expected.sorted, rawResult.sorted)
+  }
+
+  @Test
+  def testEventTimeTemporalJoinThatJoinkeyContainsPk(): Unit = {
+    val sql = "INSERT INTO rowtime_default_sink " +
+      " SELECT o.order_id, o.currency, o.amount, o.order_time, r.rate, r.currency_time " +
+      " FROM orders_rowtime AS o JOIN versioned_currency_with_single_key " +
+      " FOR SYSTEM_TIME AS OF o.order_time as r " +
+      " ON o.currency = r.currency AND o.currency_no = r.currency_no"
+
+    tEnv.executeSql(sql).await()
+    val rawResult = getRawResults("rowtime_default_sink")
+    val expected = List(
+      "+I(1,Euro,12,2020-08-15T00:01,114,2020-08-15T00:00:01)",
+      "+I(2,US Dollar,1,2020-08-15T00:02,102,2020-08-15T00:00:02)",
+      "+I(3,RMB,40,2020-08-15T00:03,702,2020-08-15T00:00:04)",
+      "+I(4,Euro,14,2020-08-16T00:04,118,2020-08-16T00:01)",
+      "-U(2,US Dollar,1,2020-08-16T00:03,106,2020-08-16T00:02)",
+      "+U(2,US Dollar,18,2020-08-16T00:03,106,2020-08-16T00:02)")
+    assertEquals(expected.sorted, rawResult.sorted)
+  }
+
+  @Test
+  def testEventTimeTemporalJoinWithFilter(): Unit = {
+    tEnv.executeSql("CREATE VIEW v1 AS" +
+      " SELECT * FROM versioned_currency_with_single_key WHERE rate < 115")
+    val sql = "INSERT INTO rowtime_default_sink " +
+      " SELECT o.order_id, o.currency, o.amount, o.order_time, r.rate, r.currency_time " +
+      " FROM orders_rowtime AS o " +
+      " JOIN v1 FOR SYSTEM_TIME AS OF o.order_time as r " +
+      " ON o.currency = r.currency"
+    tEnv.executeSql(sql).await()
+    val rawResult = getRawResults("rowtime_default_sink")
+    val expected = List(
+      "+I(1,Euro,12,2020-08-15T00:01,114,2020-08-15T00:00:01)",
+      "+I(2,US Dollar,1,2020-08-15T00:02,102,2020-08-15T00:00:02)",
+      "-U(2,US Dollar,1,2020-08-16T00:03,106,2020-08-16T00:02)",
+      "+U(2,US Dollar,18,2020-08-16T00:03,106,2020-08-16T00:02)")
+    assertEquals(expected.sorted, rawResult.sorted)
+  }
+
+  @Test
+  def testEventTimeLeftTemporalJoin(): Unit = {
+    val sql = "INSERT INTO rowtime_default_sink " +
+      " SELECT o.order_id, o.currency, o.amount, o.order_time, r.rate, r.currency_time " +
+      " FROM orders_rowtime AS o LEFT JOIN versioned_currency_with_single_key " +
+      " FOR SYSTEM_TIME AS OF o.order_time as r " +
+      " ON o.currency = r.currency"
+    tEnv.executeSql(sql).await()
+
+    val rawResult = getRawResults("rowtime_default_sink")
+    val expected = List(
+      "+I(1,Euro,12,2020-08-15T00:01,114,2020-08-15T00:00:01)",
+      "+I(2,US Dollar,1,2020-08-15T00:02,102,2020-08-15T00:00:02)",
+      "+I(3,RMB,40,2020-08-15T00:03,702,2020-08-15T00:00:04)",
+      "+I(4,Euro,14,2020-08-16T00:04,118,2020-08-16T00:01)",
+      "-U(2,US Dollar,1,2020-08-16T00:03,106,2020-08-16T00:02)",
+      "+U(2,US Dollar,18,2020-08-16T00:03,106,2020-08-16T00:02)",
+      "+I(5,RMB,40,2020-08-16T00:03,null,null)",
+      "+I(6,RMB,40,2020-08-16T00:04,null,null)",
+      "-D(6,RMB,40,2020-08-16T00:04,null,null)")
+    assertEquals(expected.sorted, rawResult.sorted)
+  }
+
+  @Test
+  def testEventTimeTemporalJoinChangelogUsingBeforeTime(): Unit = {
+    val sql = "INSERT INTO rowtime_default_sink " +
+      " SELECT o.order_id, o.currency, o.amount, o.order_time, r.rate, r.currency_time " +
+      " FROM orders_rowtime AS o LEFT JOIN currency_using_update_before_time " +
+      " FOR SYSTEM_TIME AS OF o.order_time as r " +
+      " ON o.currency = r.currency"
+    tEnv.executeSql(sql).await()
+
+    val rawResult = getRawResults("rowtime_default_sink")
+    val expected = List(
+      "+I(1,Euro,12,2020-08-15T00:01,null,null)",
+      "+I(2,US Dollar,1,2020-08-15T00:02,102,2020-08-15T00:00:02)",
+      "+I(3,RMB,40,2020-08-15T00:03,702,2020-08-15T00:00:04)",
+      "+I(4,Euro,14,2020-08-16T00:04,118,2020-08-16T00:01)",
+      "-U(2,US Dollar,1,2020-08-16T00:03,106,2020-08-16T00:02)",
+      "+U(2,US Dollar,18,2020-08-16T00:03,106,2020-08-16T00:02)",
+      "+I(5,RMB,40,2020-08-16T00:03,null,null)",
+      "+I(6,RMB,40,2020-08-16T00:04,null,null)",
+      "-D(6,RMB,40,2020-08-16T00:04,null,null)")
+    assertEquals(expected.sorted, rawResult.sorted)
+  }
+
+  @Test
+  def testEventTimeLeftTemporalJoinUpsertSource(): Unit = {
+    // Note: The WatermarkAssigner of upsertSource is followed after ChangelogNormalize,
+    // when the parallelism > 1 and test data doesn't cover all parallelisms, it returns
+    // Long.MaxValue as final watermark until all parallelism finished.
+    // This may leads the test failed because the test data doesn't cover every parallelism.

Review comment:
       Add a comment `// TODO: remove the single parallelism once FLINK-19878 is fixed.`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee9ebd0a1947e6580064910a0dace6f5e349c52 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460) 
   * a558cb0fd984dc5f256d7710f67239d0851204b3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on a change in pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13307:
URL: https://github.com/apache/flink/pull/13307#discussion_r513890085



##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamExecTemporalJoin.scala
##########
@@ -250,18 +251,16 @@ class StreamExecTemporalJoinToCoProcessTranslator private(
     val minRetentionTime = tableConfig.getMinIdleStateRetentionTime
     val maxRetentionTime = tableConfig.getMaxIdleStateRetentionTime
     if (rightRowTimeAttributeInputReference.isDefined) {
-      if (isTemporalFunctionJoin) {
-        new LegacyTemporalRowTimeJoinOperator(
-          InternalTypeInfo.of(leftInputType),
-          InternalTypeInfo.of(rightInputType),
-          generatedJoinCondition,
-          leftTimeAttributeInputReference,
-          rightRowTimeAttributeInputReference.get,
-          minRetentionTime,
-          maxRetentionTime)
-      } else {
-        throw new TableException("Event-time temporal join operator is not implemented yet.")
-      }
+      new TemporalRowTimeJoinOperator(
+        InternalTypeInfo.of(leftInputType),
+        InternalTypeInfo.of(rightInputType),
+        InternalTypeInfo.of(returnType).createSerializer(exeConfig),

Review comment:
       Use `InternalSerializers.create(returnType)` instead, then we don't need to pass in the `exeConfig`.

##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperator.java
##########
@@ -212,22 +221,32 @@ public void close() throws Exception {
 	 * @return a row time of the oldest unprocessed probe record or Long.MaxValue, if all records
 	 *         have been processed.
 	 */
-	private long emitResultAndCleanUpState(long timerTimestamp) throws Exception {
+	private long emitResultAndCleanUpState(long currentWatermark) throws Exception {
 		List<RowData> rightRowsSorted = getRightRowSorted(rightRowtimeComparator);
 		long lastUnprocessedTime = Long.MAX_VALUE;
 
 		Iterator<Map.Entry<Long, RowData>> leftIterator = leftState.entries().iterator();
+		// keep the the output records' order same with left input records order
+		Map<Long, RowData> orderedOutputs = new TreeMap<>();

Review comment:
       We can store left row data to avoid copy joined result. 

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -19,50 +19,100 @@
 package org.apache.flink.table.planner.runtime.stream.sql
 
 import org.apache.flink.table.api.TableException
-import org.apache.flink.table.planner.factories.TestValuesTableFactory.changelogRow
-import org.apache.flink.table.planner.factories.TestValuesTableFactory.registerData
-import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase.StateBackendMode
+import org.apache.flink.table.planner.factories.TestValuesTableFactory
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.{getRawResults, registerData}
 import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase
+import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase.StateBackendMode
+import org.apache.flink.types.Row
 
 import org.junit._
+import org.junit.Assert.assertEquals
 import org.junit.runner.RunWith
 import org.junit.runners.Parameterized
 
-import java.lang.{Long => JLong}
+import java.time.LocalDateTime
+import java.time.format.DateTimeParseException
+
+import scala.collection.JavaConversions._
 
 @RunWith(classOf[Parameterized])
 class TemporalJoinITCase(state: StateBackendMode)
   extends StreamingWithStateTestBase(state) {
 
   // test data for Processing-Time temporal table join
   val procTimeOrderData = List(
-    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12)),
-    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(14)),
-    changelogRow("+I", toJLong(3), "US Dollar", "no2", toJLong(18)),
-    changelogRow("+I", toJLong(4), "RMB", "no1", toJLong(40)))
+    changelogRow("+I", 1L, "Euro", "no1", 12L),
+    changelogRow("+I", 2L, "US Dollar", "no1", 14L),
+    changelogRow("+I", 3L, "US Dollar", "no2", 18L),
+    changelogRow("+I", 4L, "RMB", "no1", 40L))
 
   val procTimeCurrencyData = List(
-    changelogRow("+I","Euro", "no1", toJLong(114)),
-    changelogRow("+I","US Dollar", "no1", toJLong(102)),
-    changelogRow("+I","Yen", "no1", toJLong(1)),
-    changelogRow("+I","RMB", "no1", toJLong(702)),
-    changelogRow("+I","Euro", "no1", toJLong(118)),
-    changelogRow("+I","US Dollar", "no2", toJLong(106)))
+    changelogRow("+I", "Euro", "no1", 114L),
+    changelogRow("+I", "US Dollar", "no1", 102L),
+    changelogRow("+I", "Yen", "no1", 1L),
+    changelogRow("+I", "RMB", "no1", 702L),
+    changelogRow("+I", "Euro", "no1", 118L),
+    changelogRow("+I", "US Dollar", "no2", 106L))
 
   val procTimeCurrencyChangelogData = List(
-    changelogRow("+I","Euro", "no1", toJLong(114)),
-    changelogRow("+I","US Dollar", "no1", toJLong(102)),
-    changelogRow("+I","Yen", "no1", toJLong(1)),
-    changelogRow("+I","RMB", "no1", toJLong(702)),
-    changelogRow("-U","RMB", "no1", toJLong(702)),
-    changelogRow("+U","RMB", "no1", toJLong(802)),
-    changelogRow("+I","Euro", "no1", toJLong(118)),
-    changelogRow("+I","US Dollar", "no2", toJLong(106)))
+    changelogRow("+I", "Euro", "no1", 114L),
+    changelogRow("+I", "US Dollar", "no1", 102L),
+    changelogRow("+I", "Yen", "no1", 1L),
+    changelogRow("+I", "RMB", "no1", 702L),
+    changelogRow("-U", "RMB", "no1", 702L),
+    changelogRow("+U", "RMB", "no1", 802L),
+    changelogRow("+I", "Euro", "no1", 118L),
+    changelogRow("+I", "US Dollar", "no2", 106L))
+
+  // test data for Event-Time temporal table join
+  val rowTimeOrderData = List(
+    changelogRow("+I", 1L, "Euro", "no1", 12L, "2020-08-15T00:01:00"),
+    changelogRow("+I", 2L, "US Dollar", "no1", 1L, "2020-08-15T00:02:00"),
+    changelogRow("+I", 3L, "RMB", "no1", 40L, "2020-08-15T00:03:00"),
+    changelogRow("+I", 4L, "Euro", "no1", 14L, "2020-08-16T00:02:00"),
+    changelogRow("-U", 2L, "US Dollar", "no1", 1L, "2020-08-16T00:03:00"),
+    changelogRow("+U", 2L, "US Dollar", "no1", 18L, "2020-08-16T00:03:00"),
+    changelogRow("+I", 5L, "RMB", "no1", 40L, "2020-08-16T00:03:00"),
+    changelogRow("+I", 6L, "RMB", "no1", 40L, "2020-08-16T00:04:00"),
+    changelogRow("-D", 6L, "RMB", "no1", 40L, "2020-08-16T00:04:00"))
+
+  val rowTimeCurrencyDataUsingMetaTime = List(
+    changelogRow("+I", "Euro", "no1", 114L, "2020-08-15T00:00:00"),
+    changelogRow("+I", "US Dollar", "no1", 102L, "2020-08-15T00:00:00"),
+    changelogRow("+I", "Yen", "no1", 1L, "2020-08-15T00:00:00"),
+    changelogRow("+I", "RMB", "no1", 702L, "2020-08-15T00:00:00"),
+    changelogRow("-U", "Euro", "no1", 114L, "2020-08-16T00:01:00"),
+    changelogRow("+U", "Euro",  "no1", 118L, "2020-08-16T00:01:00"),
+    changelogRow("-U", "US Dollar", "no1", 102L, "2020-08-16T00:02:00"),
+    changelogRow("+U", "US Dollar",  "no1", 106L, "2020-08-16T00:02:00"),
+    changelogRow("-D", "RMB", "no1", 708L, "2020-08-16T00:02:00"))
+
+  val rowTimeCurrencyDataUsingUpdateBeforeTime = List(
+    changelogRow("+I", "Euro", "no1", 114L, "2020-08-15T00:00:00"),
+    changelogRow("+I", "US Dollar", "no1", 102L, "2020-08-15T00:00:00"),
+    changelogRow("+I", "Yen", "no1", 1L, "2020-08-15T00:00:00"),
+    changelogRow("+I", "RMB", "no1", 702L, "2020-08-15T00:00:00"),
+    changelogRow("+I", "RMB", "no1", 708L, "2020-08-16T00:00:00"),
+    changelogRow("-U", "Euro", "no1", 114L, "2020-08-16T00:01:00"),
+    changelogRow("+U", "Euro",  "no1", 118L, "2020-08-16T00:01:00"),
+    changelogRow("-U", "US Dollar", "no1", 102L, "2020-08-15T00:00:00"),
+    changelogRow("+U", "US Dollar",  "no1", 106L, "2020-08-16T00:02:00"),
+    changelogRow("-D", "RMB", "no1", 702L, "2020-08-15T00:00:00"))
+
+  val upsertSourceCurrencyData = List(
+    changelogRow("+U", "Euro", "no1", 114L, "2020-08-15T00:00:00"),
+    changelogRow("+U", "US Dollar", "no1", 102L, "2020-08-15T00:00:00"),
+    changelogRow("+U", "Yen", "no1", 1L, "2020-08-15T00:00:00"),
+    changelogRow("+U", "RMB", "no1", 702L, "2020-08-15T00:00:00"),
+    changelogRow("+U", "US Dollar", "no1", 104L, "2020-08-16T00:00:00"),
+    changelogRow("-D", "RMB", "no1", 702L, "2020-08-15T00:00:00"),
+    changelogRow("+U", "RMB", "no1", 712L, "2020-08-16T00:00:00"))

Review comment:
       Would be better to have the same history data, then the result of temporal join would be more predicable.

##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -18,232 +18,555 @@
 
 package org.apache.flink.table.planner.runtime.stream.sql
 
-import org.apache.flink.api.scala._
-import org.apache.flink.streaming.api.TimeCharacteristic
-import org.apache.flink.streaming.api.functions.timestamps.BoundedOutOfOrdernessTimestampExtractor
-import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
-import org.apache.flink.streaming.api.windowing.time.Time
-import org.apache.flink.table.api._
-import org.apache.flink.table.api.bridge.scala._
+import org.apache.flink.table.api.TableException
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.changelogRow
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.getRawResults
+import org.apache.flink.table.planner.factories.TestValuesTableFactory.registerData
 import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase.StateBackendMode
-import org.apache.flink.table.planner.runtime.utils.{StreamingWithStateTestBase, TestingAppendSink}
-import org.apache.flink.table.planner.utils.TableTestUtil
-import org.apache.flink.types.Row
+import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase
 
-import org.junit.Assert.assertEquals
 import org.junit._
+import org.junit.Assert.assertEquals
 import org.junit.runner.RunWith
 import org.junit.runners.Parameterized
 
-import java.sql.Timestamp
+import java.lang.{Long => JLong}
+import java.time.LocalDateTime
 
-import scala.collection.mutable
+import scala.collection.JavaConversions._
 
 @RunWith(classOf[Parameterized])
 class TemporalJoinITCase(state: StateBackendMode)
   extends StreamingWithStateTestBase(state) {
 
+  // test data for Processing-Time temporal table join
+  val procTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12)),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(14)),
+    changelogRow("+I", toJLong(3), "US Dollar", "no2", toJLong(18)),
+    changelogRow("+I", toJLong(4), "RMB", "no1", toJLong(40)))
+
+  val procTimeCurrencyData = List(
+    changelogRow("+I","Euro", "no1", toJLong(114)),
+    changelogRow("+I","US Dollar", "no1", toJLong(102)),
+    changelogRow("+I","Yen", "no1", toJLong(1)),
+    changelogRow("+I","RMB", "no1", toJLong(702)),
+    changelogRow("+I","Euro", "no1", toJLong(118)),
+    changelogRow("+I","US Dollar", "no2", toJLong(106)))
+
+  val procTimeCurrencyChangelogData = List(
+    changelogRow("+I","Euro", "no1", toJLong(114)),
+    changelogRow("+I","US Dollar", "no1", toJLong(102)),
+    changelogRow("+I","Yen", "no1", toJLong(1)),
+    changelogRow("+I","RMB", "no1", toJLong(702)),
+    changelogRow("-U","RMB", "no1", toJLong(702)),
+    changelogRow("+U","RMB", "no1", toJLong(802)),
+    changelogRow("+I","Euro", "no1", toJLong(118)),
+    changelogRow("+I","US Dollar", "no2", toJLong(106)))
+
+  // test data for Event-Time temporal table join
+  val rowTimeOrderData = List(
+    changelogRow("+I", toJLong(1), "Euro", "no1", toJLong(12),
+      toDateTime("2020-08-15T00:01:00")),
+    changelogRow("+I", toJLong(2), "US Dollar", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:02:00")),
+    changelogRow("+I", toJLong(3), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-15T00:03:00")),
+    changelogRow("+I", toJLong(4), "Euro", "no1", toJLong(14),
+      toDateTime("2020-08-16T00:02:00")),
+    // test left stream could be changelog,
+    // -U or -D message may retract fail in collection connector sink implementation
+    changelogRow("+U", toJLong(5), "US Dollar", "no1", toJLong(18),
+      toDateTime("2020-08-16T00:03:00")),
+    changelogRow("+I", toJLong(6), "RMB", "no1", toJLong(40),
+      toDateTime("2020-08-16T00:03:00")))
+
+  val rowTimeCurrencyDataUsingMetaTime = List(
+    changelogRow("+I", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "Yen", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "RMB", "no1", toJLong(702),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("-U", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("+U", "Euro",  "no1", toJLong(118),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("-U", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("+U", "US Dollar",  "no1", toJLong(106),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("-D","RMB", "no1", toJLong(708),
+      toDateTime("2020-08-16T00:02:00")))
+
+  val rowTimeCurrencyDataUsingInsertTime = List(
+    changelogRow("+I", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "Yen", "no1", toJLong(1),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+I", "RMB", "no1", toJLong(702),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("-U", "Euro", "no1", toJLong(114),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("+U", "Euro",  "no1", toJLong(118),
+      toDateTime("2020-08-16T00:01:00")),
+    changelogRow("-U", "US Dollar", "no1", toJLong(102),
+      toDateTime("2020-08-15T00:00:00")),
+    changelogRow("+U", "US Dollar",  "no1", toJLong(106),
+      toDateTime("2020-08-16T00:02:00")),
+    changelogRow("-D","RMB", "no1", toJLong(708),
+      toDateTime("2020-08-15T00:00:00")))
+
+  @Before
+  def prepare(): Unit = {
+    env.setParallelism(4)

Review comment:
       Remove this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b9f1d43f8e46a0c79d2741c4d6061443ef9be599 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230) 
   * 7dc326d54c5ac31c352ac06c35d918f444d9bd40 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong merged pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #13307:
URL: https://github.com/apache/flink/pull/13307


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * da1db6af426818bc3bd0224c244dd201bd81799a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f148274d5bcdf7177561a2f659ba9fc718af0054 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7ad79c6528d529ebd03e87a78f92d79d8cb6d91f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * da1db6af426818bc3bd0224c244dd201bd81799a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123) 
   * b9f1d43f8e46a0c79d2741c4d6061443ef9be599 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 62bb7f7e511775b0b65003e65aa13b27c760da27 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236) 
   * 0edbb09cea1b10a677b91c17b889ec74ef8dfbed UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] leonardBang removed a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
leonardBang removed a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-718031172


   address your comment and rebase master, appreciate if you have time to review again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] leonardBang commented on a change in pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #13307:
URL: https://github.com/apache/flink/pull/13307#discussion_r513547742



##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperator.java
##########
@@ -294,6 +320,13 @@ private int indexOfFirstElementNewerThanTimer(long timerTimestamp, List<RowData>
 	/**
 	 * Binary search {@code rightRowsSorted} to find the latest right row to join with {@code leftTime}.
 	 * Latest means a right row with largest time that is still smaller or equal to {@code leftTime}.
+	 * For example with: rightState = [1(+I), 4(-U), 4(+U), 7(-U), 7(+U), 9(-D), 12(I)],

Review comment:
       I did not get the improvement point, could you explain more ? other comments has addressed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] leonardBang commented on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-718808063


   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3aae457c54d028a1c526a32e059b0836df8105c7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483",
       "triggerID" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525",
       "triggerID" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f8a62099663b658669488af7f0ecd5087d1e5da6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483",
       "triggerID" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525",
       "triggerID" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8546",
       "triggerID" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a45a5a527afc2aae477c89ebf0dc047cc45a201d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8583",
       "triggerID" : "a45a5a527afc2aae477c89ebf0dc047cc45a201d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "896661af5940a86cd9fba9526aaf57a553d388cb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "896661af5940a86cd9fba9526aaf57a553d388cb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9f912a17d777463b856a19b64a03c16adadb8a73 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8546) 
   * a45a5a527afc2aae477c89ebf0dc047cc45a201d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8583) 
   * 896661af5940a86cd9fba9526aaf57a553d388cb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483",
       "triggerID" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525",
       "triggerID" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8546",
       "triggerID" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a45a5a527afc2aae477c89ebf0dc047cc45a201d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a45a5a527afc2aae477c89ebf0dc047cc45a201d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9f912a17d777463b856a19b64a03c16adadb8a73 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8546) 
   * a45a5a527afc2aae477c89ebf0dc047cc45a201d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f148274d5bcdf7177561a2f659ba9fc718af0054 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106) 
   * da1db6af426818bc3bd0224c244dd201bd81799a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0edbb09cea1b10a677b91c17b889ec74ef8dfbed Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483",
       "triggerID" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525",
       "triggerID" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8546",
       "triggerID" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a45a5a527afc2aae477c89ebf0dc047cc45a201d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8583",
       "triggerID" : "a45a5a527afc2aae477c89ebf0dc047cc45a201d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "896661af5940a86cd9fba9526aaf57a553d388cb",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8601",
       "triggerID" : "896661af5940a86cd9fba9526aaf57a553d388cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "896661af5940a86cd9fba9526aaf57a553d388cb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8611",
       "triggerID" : "718808063",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 896661af5940a86cd9fba9526aaf57a553d388cb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8601) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8611) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483",
       "triggerID" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a558cb0fd984dc5f256d7710f67239d0851204b3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483) 
   * f8a62099663b658669488af7f0ecd5087d1e5da6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 20fe41449f841cfbbb155c1f1c842c5d814ca934 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447) 
   * 85867d4ab920f571c1dcad56fea6a89c3b717b13 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3aae457c54d028a1c526a32e059b0836df8105c7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813) 
   * 4174635af1c0de52685df1ffb1b2adc869256d18 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483",
       "triggerID" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525",
       "triggerID" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f8a62099663b658669488af7f0ecd5087d1e5da6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525) 
   * 9f912a17d777463b856a19b64a03c16adadb8a73 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * da1db6af426818bc3bd0224c244dd201bd81799a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123) 
   * b9f1d43f8e46a0c79d2741c4d6061443ef9be599 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0edbb09cea1b10a677b91c17b889ec74ef8dfbed Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427) 
   * 20fe41449f841cfbbb155c1f1c842c5d814ca934 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b9f1d43f8e46a0c79d2741c4d6061443ef9be599 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f148274d5bcdf7177561a2f659ba9fc718af0054 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106) 
   * da1db6af426818bc3bd0224c244dd201bd81799a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 20fe41449f841cfbbb155c1f1c842c5d814ca934 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 85867d4ab920f571c1dcad56fea6a89c3b717b13 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453) 
   * dee9ebd0a1947e6580064910a0dace6f5e349c52 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483",
       "triggerID" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525",
       "triggerID" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8546",
       "triggerID" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a45a5a527afc2aae477c89ebf0dc047cc45a201d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8583",
       "triggerID" : "a45a5a527afc2aae477c89ebf0dc047cc45a201d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "896661af5940a86cd9fba9526aaf57a553d388cb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8601",
       "triggerID" : "896661af5940a86cd9fba9526aaf57a553d388cb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a45a5a527afc2aae477c89ebf0dc047cc45a201d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8583) 
   * 896661af5940a86cd9fba9526aaf57a553d388cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8601) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685754317


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit f148274d5bcdf7177561a2f659ba9fc718af0054 (Wed Sep 02 13:56:20 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8126",
       "triggerID" : "7ad79c6528d529ebd03e87a78f92d79d8cb6d91f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8236",
       "triggerID" : "62bb7f7e511775b0b65003e65aa13b27c760da27",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8427",
       "triggerID" : "0edbb09cea1b10a677b91c17b889ec74ef8dfbed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8447",
       "triggerID" : "20fe41449f841cfbbb155c1f1c842c5d814ca934",
       "triggerType" : "PUSH"
     }, {
       "hash" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8453",
       "triggerID" : "85867d4ab920f571c1dcad56fea6a89c3b717b13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8460",
       "triggerID" : "dee9ebd0a1947e6580064910a0dace6f5e349c52",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8483",
       "triggerID" : "a558cb0fd984dc5f256d7710f67239d0851204b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8525",
       "triggerID" : "f8a62099663b658669488af7f0ecd5087d1e5da6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8546",
       "triggerID" : "9f912a17d777463b856a19b64a03c16adadb8a73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9f912a17d777463b856a19b64a03c16adadb8a73 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8546) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13307:
URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6106",
       "triggerID" : "f148274d5bcdf7177561a2f659ba9fc718af0054",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6123",
       "triggerID" : "da1db6af426818bc3bd0224c244dd201bd81799a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6230",
       "triggerID" : "b9f1d43f8e46a0c79d2741c4d6061443ef9be599",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7812",
       "triggerID" : "7dc326d54c5ac31c352ac06c35d918f444d9bd40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7813",
       "triggerID" : "3aae457c54d028a1c526a32e059b0836df8105c7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820",
       "triggerID" : "4174635af1c0de52685df1ffb1b2adc869256d18",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4174635af1c0de52685df1ffb1b2adc869256d18 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7820) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org