Warnings [was: svn commit: r39805 - in trunk/subversion: svnlook tests/cmdline]

[Julian Foad <ju...@btopenworld.com>]

On Wed, 2009-10-07 at 08:41 -0400, C. Michael Pilato wrote:
> Julian Foad wrote:
> > I (Julian Foad) wrote:
> >> subversion/svnlook/main.c: In function 'do_filesize':
> >> subversion/svnlook/main.c:1402: warning: format '%ld' expects type 'long
> >> int', but argument 3 has type 'svn_filesize_t'
> >> subversion/svnlook/main.c:1390: warning: unused variable 'stdout_stream'
> >> subversion/svnlook/main.c:1390: warning: unused variable 'fstream'
> > 
> > Fixed in revision 39821.
> 
> Thanks, Julian.  We have so many build warnings these days (thanks to folks
> not seeing their deprecation work through to completion) that it's far too
> easy to miss the ones you care about.  :-(

I turn off the deprecation warnings and nonliteral-printf-format-string
warnings in my builds, with "CFLAGS="... -Wno-deprecated-declarations
-Wno-format-nonliteral", because it doesn't seem that we intend to avoid
those.

I get

  * 40-ish "casting away const" warnings which I'd like to eliminate
properly because such warnings are potentially very useful (quite often
pointing out real problems). I have a go at some of these from time to
time. The C language doesn't support some cases well, especially passing
a "pointer-to-anything" as a baton, or writing a function that operates
on a const-or-non-const target and wants to return the same kind of
pointer.

  * A bunch of "case not handled in switch" warnings, which have been
around for not too long and we could avoid.

  * Not too many others.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2404500

Re: Warnings [was: svn commit: r39805 - in trunk/subversion: svnlook tests/cmdline]

["Hyrum K. Wright" <hy...@hyrumwright.org>]

On Oct 7, 2009, at 7:59 AM, Julian Foad wrote:

> On Wed, 2009-10-07 at 08:41 -0400, C. Michael Pilato wrote:
>> Julian Foad wrote:
>>> I (Julian Foad) wrote:
>>>> subversion/svnlook/main.c: In function 'do_filesize':
>>>> subversion/svnlook/main.c:1402: warning: format '%ld' expects  
>>>> type 'long
>>>> int', but argument 3 has type 'svn_filesize_t'
>>>> subversion/svnlook/main.c:1390: warning: unused variable  
>>>> 'stdout_stream'
>>>> subversion/svnlook/main.c:1390: warning: unused variable 'fstream'
>>>
>>> Fixed in revision 39821.
>>
>> Thanks, Julian.  We have so many build warnings these days (thanks  
>> to folks
>> not seeing their deprecation work through to completion) that it's  
>> far too
>> easy to miss the ones you care about.  :-(
>
> I turn off the deprecation warnings and nonliteral-printf-format- 
> string
> warnings in my builds, with "CFLAGS="... -Wno-deprecated-declarations
> -Wno-format-nonliteral", because it doesn't seem that we intend to  
> avoid
> those.
>
> I get
>
>  * 40-ish "casting away const" warnings which I'd like to eliminate
> properly because such warnings are potentially very useful (quite  
> often
> pointing out real problems). I have a go at some of these from time to
> time. The C language doesn't support some cases well, especially  
> passing
> a "pointer-to-anything" as a baton, or writing a function that  
> operates
> on a const-or-non-const target and wants to return the same kind of
> pointer.
>
>  * A bunch of "case not handled in switch" warnings, which have been
> around for not too long and we could avoid.

These should be gone, as of r39824.

>  * Not too many others.
>
> - Julian
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2404500

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2404507