You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2019/09/27 10:49:26 UTC
Re: buildbot failure in on tomcat-7-trunk
On 26/09/2019 23:04, buildbot@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-7-trunk while building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-7-trunk/builds/1465
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: asf946_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-7-commit' triggered this build
> Build Source Stamp: [branch 7.0.x] d0685f927186da2e0be56c28371e5207ee09ed20
> Blamelist: Mark Thomas <ma...@apache.org>
>
> BUILD FAILED: failed compile_1
That was unexpected. This appears to have been triggered by:
https://github.com/apache/tomcat/commit/247c8c32c44f65ce7bf3035541eedb8ffc97d5d0
Why this is the case isn't immediately obvious to me. I'm currently
investigating.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: buildbot failure in on tomcat-7-trunk
Posted by Mark Thomas <ma...@apache.org>.
On 27/09/2019 13:02, Rémy Maucherat wrote:
> On Fri, Sep 27, 2019 at 12:49 PM Mark Thomas <markt@apache.org
> <ma...@apache.org>> wrote:
>
> On 26/09/2019 23:04, buildbot@apache.org
> <ma...@apache.org> wrote:
> > The Buildbot has detected a new failure on builder tomcat-7-trunk
> while building tomcat. Full details are available at:
> > https://ci.apache.org/builders/tomcat-7-trunk/builds/1465
> >
> > Buildbot URL: https://ci.apache.org/
> >
> > Buildslave for this Build: asf946_ubuntu
> >
> > Build Reason: The AnyBranchScheduler scheduler named
> 'on-tomcat-7-commit' triggered this build
> > Build Source Stamp: [branch 7.0.x]
> d0685f927186da2e0be56c28371e5207ee09ed20
> > Blamelist: Mark Thomas <markt@apache.org <ma...@apache.org>>
> >
> > BUILD FAILED: failed compile_1
>
> That was unexpected. This appears to have been triggered by:
> https://github.com/apache/tomcat/commit/247c8c32c44f65ce7bf3035541eedb8ffc97d5d0
>
> Why this is the case isn't immediately obvious to me. I'm currently
> investigating.
>
> The test seems to modify the listener array returned (it likely doesn't
> work now since it's a copy on write array following that commit), you
> apparently refactored that away in the new branches like 8.5 and the
> test looks much cleaner there.
> https://github.com/apache/tomcat/blob/master/test/org/apache/catalina/core/TestStandardContextResources.java#L128
> vs
> https://github.com/apache/tomcat/blob/7.0.x/test/org/apache/catalina/core/TestStandardContextResources.java#L132
Thanks. It hadn't even occurred to me to check what the test was doing.
I'll back-port the test refactoring from 8.5.x.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: buildbot failure in on tomcat-7-trunk
Posted by Rémy Maucherat <re...@apache.org>.
On Fri, Sep 27, 2019 at 12:49 PM Mark Thomas <ma...@apache.org> wrote:
> On 26/09/2019 23:04, buildbot@apache.org wrote:
> > The Buildbot has detected a new failure on builder tomcat-7-trunk while
> building tomcat. Full details are available at:
> > https://ci.apache.org/builders/tomcat-7-trunk/builds/1465
> >
> > Buildbot URL: https://ci.apache.org/
> >
> > Buildslave for this Build: asf946_ubuntu
> >
> > Build Reason: The AnyBranchScheduler scheduler named
> 'on-tomcat-7-commit' triggered this build
> > Build Source Stamp: [branch 7.0.x]
> d0685f927186da2e0be56c28371e5207ee09ed20
> > Blamelist: Mark Thomas <ma...@apache.org>
> >
> > BUILD FAILED: failed compile_1
>
> That was unexpected. This appears to have been triggered by:
>
> https://github.com/apache/tomcat/commit/247c8c32c44f65ce7bf3035541eedb8ffc97d5d0
>
> Why this is the case isn't immediately obvious to me. I'm currently
> investigating.
>
> The test seems to modify the listener array returned (it likely doesn't
work now since it's a copy on write array following that commit), you
apparently refactored that away in the new branches like 8.5 and the test
looks much cleaner there.
https://github.com/apache/tomcat/blob/master/test/org/apache/catalina/core/TestStandardContextResources.java#L128
vs
https://github.com/apache/tomcat/blob/7.0.x/test/org/apache/catalina/core/TestStandardContextResources.java#L132
Rémy