You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/17 19:14:41 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #13184: test: creates storybook and tests for Tooltip component
michael-s-molina opened a new pull request #13184:
URL: https://github.com/apache/superset/pull/13184
### SUMMARY
- Adds tests for the `Tooltip` component and a storybook entry with controls.
- `TooltipWrapper` wasn't adding any functionality on top of `Tooltip` so I updated all components to reference `Tooltip` and removed `TooltipWrapper`.
- Moves `Tooltip` component to its own folder
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1784" alt="Screen Shot 2021-02-17 at 3 57 02 PM" src="https://user-images.githubusercontent.com/70410625/108254798-35d31580-713a-11eb-8d55-e0ca58caf989.png">
### TEST PLAN
1 - Execute all tests
2 - All tests should pass
@geido @rusackas @yardz
Acceptance testing can be done using Storybook.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13184: test: creates storybook and tests for Tooltip component
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13184:
URL: https://github.com/apache/superset/pull/13184#issuecomment-780920148
yea @rusackas @ktmud please do merge test PRs soon if the code look alright. thanks for the PR and reviewing!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #13184: test: creates storybook and tests for Tooltip component
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #13184:
URL: https://github.com/apache/superset/pull/13184#issuecomment-780904005
@junlincc Tempted to just merge this, since it's basically safer than ever, but LMK if you want to poke around at some of the tooltips in the UI for signoff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #13184: test: creates storybook and tests for Tooltip component
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13184:
URL: https://github.com/apache/superset/pull/13184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org