You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/05/23 02:48:31 UTC
[PR] GH-46564: [C++] Export ARROW_VCPKG in ArrowConfig.cmake [arrow]
kou opened a new pull request, #46565:
URL: https://github.com/apache/arrow/pull/46565
### Rationale for this change
#46467 changed `FindBrotliAlt.cmake` and `Findutf8proc.cmake` to use `ARROW_VCPKG` instead of `ARROW_PACKAGE_KIND`. It works in Apache Arrow C++ build but doesn't work when users use `find_package(Arrow)` because `ARROW_VCPKG` isn't exported in `ArrowConfig.cmake`.
### What changes are included in this PR?
Export `ARROW_VCPKG` in `ArrowConfig.cmake` to use in `FindBrotliAlt.cmake` and `Findutf8proc.cmake`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46564: [C++] Export ARROW_VCPKG in ArrowConfig.cmake [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46565:
URL: https://github.com/apache/arrow/pull/46565#issuecomment-2903187427
Let's merge this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46564: [C++] Export ARROW_VCPKG in ArrowConfig.cmake [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46565:
URL: https://github.com/apache/arrow/pull/46565#issuecomment-2904153111
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1b7aed79c3de879bfe56d541460db58bce78f9f8.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/42779895439) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46564: [C++] Export ARROW_VCPKG in ArrowConfig.cmake [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #46565:
URL: https://github.com/apache/arrow/pull/46565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46564: [C++] Export ARROW_VCPKG in ArrowConfig.cmake [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46565:
URL: https://github.com/apache/arrow/pull/46565#issuecomment-2903099622
:warning: GitHub issue #46564 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org