[GitHub] [zeppelin] zjffdu commented on a change in pull request #3359: [ZEPPELIN-4131] Refactoring shell interpreter

[GitBox <gi...@apache.org>]

zjffdu commented on a change in pull request #3359: [ZEPPELIN-4131] Refactoring shell interpreter
URL: https://github.com/apache/zeppelin/pull/3359#discussion_r289746458
 
 

 ##########
 File path: shell/pom.xml
 ##########
 @@ -38,22 +38,79 @@
     <!--library versions -->
     <commons.lang3.version>3.4</commons.lang3.version>
     <commons.exec.version>1.3</commons.exec.version>
-    <interpreter.name>sh</interpreter.name>
+    <pty4j.version>0.9.3</pty4j.version>
+    <jinjava.version>2.4.0</jinjava.version>
+    <guava.version>20.0</guava.version>
   </properties>
 
+  <!-- pty4j library not in travis central (http://repo.maven.apache.org/maven2) -->
 
 Review comment:
   It is not travis central, it is maven central repository 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services