You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/22 21:25:50 UTC
[GitHub] [airflow] potiuk opened a new pull request #16604: Revert "Switch to GitHub Container Registry by default (#16586)"
potiuk opened a new pull request #16604:
URL: https://github.com/apache/airflow/pull/16604
This reverts commit f7aebeb8a1fb634ca7369a4455c7324f67a9deda.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #16604: Revert "Switch to GitHub Container Registry by default (#16586)"
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #16604:
URL: https://github.com/apache/airflow/pull/16604#issuecomment-866346945
Can you explain a bit on why we need to revert ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #16604: Revert "Switch to GitHub Container Registry by default (#16586)"
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #16604:
URL: https://github.com/apache/airflow/pull/16604#issuecomment-866351184
May not be needed -- if other PRs "Wait for Image" steps are passing then this is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16604: Revert "Switch to GitHub Container Registry by default (#16586)"
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16604:
URL: https://github.com/apache/airflow/pull/16604#issuecomment-866352073
Yeah. I just created it "in-case" we need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16604: Revert "Switch to GitHub Container Registry by default (#16586)"
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16604:
URL: https://github.com/apache/airflow/pull/16604#issuecomment-866354584
At least here the "wait for CI image" is green now, so it does look we might not need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #16604: Revert "Switch to GitHub Container Registry by default (#16586)"
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #16604:
URL: https://github.com/apache/airflow/pull/16604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16604: Revert "Switch to GitHub Container Registry by default (#16586)"
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16604:
URL: https://github.com/apache/airflow/pull/16604#issuecomment-866353103
This seems to be a likely permission issue with ghcr.io when I tested it this afternoon - it worked on "main" in my fork, and it still works after I merged the change but i seems to not work from PRs. I will need to investigate it more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #16604: Revert "Switch to GitHub Container Registry by default (#16586)"
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #16604:
URL: https://github.com/apache/airflow/pull/16604#issuecomment-866346945
Can you explain a bit more on why we need to revert ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16604: Revert "Switch to GitHub Container Registry by default (#16586)"
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16604:
URL: https://github.com/apache/airflow/pull/16604#issuecomment-866357198
Yep. Confirmed it in unrelated PR. We are back in business. Closing this one and I will test the GHCR.IO switch tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org