You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/10/28 13:34:09 UTC
[GitHub] [lucene] rmuir opened a new pull request, #11889: Allow building with java 18 now that gradle supports it
rmuir opened a new pull request, #11889:
URL: https://github.com/apache/lucene/pull/11889
Since #11886, java 18 actually works, so let's allow it. unfortunately java 19 still does not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
uschindler commented on PR #11889:
URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295789651
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11889:
URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295032948
unrelated to this PR, does anyone know what happened with the "run distribution test" check?
it hit connect timeout and failed, this isn't "our" downloading, there's no `org.apache.lucene` in the stacktraces. We already added retries to that piece. so i dont know how to make this more reliable...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
uschindler commented on PR #11889:
URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295040553
> @uschindler i know, but in order to prevent flaky builds, we should have backoff and retry to these type of requests.
Sometimes also Apache Git is down then Jenkins fails. Who cares? I don't want to modify Gradle's code just because 1 in 100 cases the gradle download fails. On Jenkins this is not an issue at all, as it is cached accross builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11889:
URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295046872
> This is gradle bootstrapping itself (new version). It's the gradle-wrapper that downloads the distribution. I'm not sure how we could retry it on network failures, unfortunately. The downloader script could try to do it/ ping the network but it seems like an unacceptable overhead for everyone just to detect a rare glitch.
I don't want to add anything crazy such as pings. it wouldn't help for cases like random connect-timeout/503/etc.
but if theres a way to add `try/catch` to some java code or even `download || (sleep 10 && download) || (sleep 10 && download)` to prevent builds from having annoyingly noisy fails, we should do it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
uschindler commented on PR #11889:
URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295048862
> but if theres a way to add `try/catch` to some java code or even `download || (sleep 10 && download) || (sleep 10 && download)` to prevent builds from having annoyingly noisy fails, we should do it :)
You would need to do that around each Maven Central call :-) This was just a bad incidence that it failed. I don't care if the build fails from time to time. It does it for other reasons, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #11889:
URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295041468
This is gradle bootstrapping itself (new version). It's the gradle-wrapper that downloads the distribution. I'm not sure how we could retry it on network failures, unfortunately. The downloader script could try to do it/ ping the network but it seems like an unacceptable overhead for everyone just to detect a rare glitch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11889:
URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295022832
> Based on the commit that added this check, [c897aac](https://github.com/apache/lucene/commit/c897aac0773d7c14fedceefa26511b97866ad587) gradlew and gradlew.bat should be updated as well.
>
> * https://github.com/apache/lucene/blob/main/gradlew#L127
> * https://github.com/apache/lucene/blob/main/gradlew.bat#L100
oh, thanks for the reminder, i forgot about the generic "something went wrong" message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11889:
URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295024717
i'm gonna fix that too. but for the future i wonder if we need that "generic" message anymore... or at least versions in it: that was kinda a previous workaround for gradle's confusing errors. but now if you use the wrong java version you get an explicit error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11889:
URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295050135
> You would need to do that around each Maven Central call :-) This was just a bad incidence that it failed. I don't care if the build fails from time to time. It does it for other reasons, too.
usually package managers have robust retry behavior like this already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
uschindler commented on PR #11889:
URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295033229
I restarted the Github actions. Was some timeout error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #11889:
URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295028109
>i'm gonna fix that too. but for the future i wonder if we need that "generic" message anymore... or at least versions in it: that was kinda a previous workaround for gradle's confusing errors. but now if you use the wrong java version you get an explicit error.
I agree - the message should be printed by the downloader script. If somebody is using a REALLY old Java then so be it - it'll fail to interpret the script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11889:
URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295038154
@uschindler i know, but in order to prevent flaky builds, we should have backoff and retry to these type of requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #11889:
URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295163562
> usually package managers have robust retry behavior like this already.
It's something that would have to be fixed in the gradle wrapper, I think. :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11889:
URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295051733
ok, ill ignore it. but i'm not happy about flaky builds because someone used the network naively!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir merged pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
rmuir merged PR #11889:
URL: https://github.com/apache/lucene/pull/11889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #11889: Allow building with java 18 now that gradle supports it
Posted by GitBox <gi...@apache.org>.
uschindler commented on PR #11889:
URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295036904
> I restarted the Github actions. Was some timeout error.
Was a temporary problem with Gradle's sörvers. 2nd try worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org