You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Timothy A. Bish (Jira)" <ji...@apache.org> on 2025/05/29 13:23:00 UTC

[jira] [Resolved] (ARTEMIS-4967) store.commit(txDeleteCursorOnReload); may not be reachable in processReload() method

     [ https://issues.apache.org/jira/browse/ARTEMIS-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy A. Bish resolved ARTEMIS-4967.
--------------------------------------
    Fix Version/s: 2.42.0
       Resolution: Fixed

> store.commit(txDeleteCursorOnReload); may not be reachable in processReload() method
> ------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-4967
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4967
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Suhov Roman
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.42.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> File: [https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java]
> Line: 700 - 702
> store.commit(txDeleteCursorOnReload); may be unreachable in this processReload() method, especially if the txDeleteCursorOnReload variable remains at -1 after the loop and never changes to a value >= 0.
> The code did not detect a change in the value of the txDeleteCursorOnReload variable. It is possible that the application logic does not require a transaction commit after loading data from recoveredACK.
> If the txDeleteCursorOnReload variable remains at -1 after the loop, then the call to store.commit(txDeleteCursorOnReload); in this method will indeed be unreachable.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@activemq.apache.org
For additional commands, e-mail: issues-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact