You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/09/01 15:33:12 UTC

[GitHub] [hadoop] slfan1989 commented on pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

slfan1989 commented on PR #4817:
URL: https://github.com/apache/hadoop/pull/4817#issuecomment-1234447386

   @goiri Please help to review the code again, thank you very much!
   
   I have refactored the code as follows:
   1. Use field names instead of index to improve code readability
   2. Refactor the test code(TestSQLFederationStateStore.java)
   2.1 General test to ensure that the definition can be executed normally in FederationStateStoreBaseTest.
   2.2 Test all procedures, including writing and reading, and verify the content of the data.
   2.3 Unit test for exceptions of add, update, and delete data.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org