[jira] [Commented] (BEAM-498) Make DoFnWithContext the new DoFn

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398675#comment-15398675 ] 

ASF GitHub Bot commented on BEAM-498:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/758

    [BEAM-498] Rename DoFn to OldDoFn, DoFnWithContext to DoFn, and port some examples

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @bjchambers. Since there was general approval on the mailing list and these changes are mostly trivial, I'm mostly just asking Ben for a double-check since he has the most technical depth on this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam DoFnWithContext

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/758.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #758
    
----
commit a29447cd338825ac056dfe04d2eeadd8fb4a3171
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-07-22T20:00:10Z

    Rename DoFn to OldDoFn

commit 20d6217cf2db355febc637ebe14e113fbef0ce05
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-07-26T04:27:02Z

    Rename NoOpDoFn to NoOpOldDoFn

commit 9026589010efcdb29543d551a6e8ed9117ea20a7
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-07-22T21:10:01Z

    Rename DoFnWithContext to DoFn

commit 93fab04cc9dc6c93e3080ba5ebbc4aba18851758
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-07-22T21:28:28Z

    Port WordCount example from OldDoFn to DoFn

commit a0d40c6eece48231df2247faec8008bb3abc5bb7
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-07-22T21:28:42Z

    Port MinimalWordCount example from OldDoFn to DoFn

commit 0d4a470af28177af9e8956ddc74f05f52b0fb05b
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-07-22T21:29:01Z

    Port WindowedWordCount example from OldDoFn to DoFn

commit cabea9d4241cfd44996f1d58e8032c60f6413dae
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-07-22T21:29:18Z

    Port DebuggingWordCount example from OldDoFn to DoFn

commit 8f0ce4f1edbdd25fe4c408cb1215190806d874ba
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-07-22T21:29:37Z

    Port AutoComplete example from OldDoFn to DoFn

commit 343d3bc75d04cac554d858c238bb21f0df982c9a
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-07-22T21:29:51Z

    Port microbenchmarks to new vocabulary

----


> Make DoFnWithContext the new DoFn
> ---------------------------------
>
>                 Key: BEAM-498
>                 URL: https://issues.apache.org/jira/browse/BEAM-498
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)