[GitHub] [spark] zhenlineo commented on a diff in pull request #40160: [SPARK-41725][CONNECT] Eager Execution of DF.sql()

["zhenlineo (via GitHub)" <gi...@apache.org>]

zhenlineo commented on code in PR #40160:
URL: https://github.com/apache/spark/pull/40160#discussion_r1136726276


##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/RemoteSparkSession.scala:
##########
@@ -69,6 +69,10 @@ object SparkConnectServerUtils {
         jar,
         "--conf",
         s"spark.connect.grpc.binding.port=$port",
+        "--conf",
+        "spark.sql.catalog.testcat=org.apache.spark.sql.connect.catalog.InMemoryTableCatalog",

Review Comment:
   @LuciferYang Yes, this config is not picked up. We can delete these two lines.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org