You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org> on 2019/05/22 23:55:34 UTC
[kudu-CR] kudu kubernetes statefulset manifesto
Sandish Kumar HN has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13407
Change subject: kudu kubernetes statefulset manifesto
......................................................................
kudu kubernetes statefulset manifesto
Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
---
A kubernetes/kudu-statefulset.yaml
1 file changed, 188 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/13407/1
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 1
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifest
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13407 )
Change subject: KUDU-2398: Kudu kubernetes statefulset manifest
......................................................................
KUDU-2398: Kudu kubernetes statefulset manifest
it builds kubernetes statefulset kudu cluster, statefulset manages the
deployment and scaling of kudu server pods.
creating kubernetes kudu cluster: kubectl create -f kudu-statefulset.yaml
to destroy: kubectl delete -f kudu-statefulset.yaml
scale: kubectl scale statefulset kudu-tserver --replicas=5
Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Reviewed-on: http://gerrit.cloudera.org:8080/13407
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
A kubernetes/kudu-statefulset.yaml
1 file changed, 212 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 9
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifest
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/13407 )
Change subject: KUDU-2398: Kudu kubernetes statefulset manifest
......................................................................
Patch Set 8:
> (1 comment)
Sorry! my mistake. made changes accordingly
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 8
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Wed, 29 May 2019 23:22:28 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifest
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13407
to look at the new patch set (#7).
Change subject: KUDU-2398: Kudu kubernetes statefulset manifest
......................................................................
KUDU-2398: Kudu kubernetes statefulset manifest
it builds kubernetes statefulset kudu cluster, statefulset manages the deployment and scaling of kudu server pods,
creating kubernetes kudu cluster : kubectl create -f kudu-statefulset.yaml
to destroy: kubectl delete -f kudu-statefulset.yaml
scale: kubectl scale statefulset kudu-tserver --replicas=5
Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
---
A kubernetes/kudu-statefulset.yaml
1 file changed, 212 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/13407/7
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 7
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifesto
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13407 )
Change subject: KUDU-2398: Kudu kubernetes statefulset manifesto
......................................................................
Patch Set 1:
(6 comments)
Thanks for this contribution!
http://gerrit.cloudera.org:8080/#/c/13407/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13407/1//COMMIT_MSG@8
PS1, Line 8:
> Do you mind adding more detailed description on what this manifesto allows
Agee that it would be useful to provide a detailed description or example of how this should be used.
Instead of adding it to the commit message, adding a README.adoc (similar to the one in the docker directory) would be preferred.
http://gerrit.cloudera.org:8080/#/c/13407/1/kubernetes/kudu-statefulset.yaml
File kubernetes/kudu-statefulset.yaml:
http://gerrit.cloudera.org:8080/#/c/13407/1/kubernetes/kudu-statefulset.yaml@31
PS1, Line 31: type: LoadBalancer
Is this making the master web UI load balanced? Users need to be able to hit each ui instance as needed.
http://gerrit.cloudera.org:8080/#/c/13407/1/kubernetes/kudu-statefulset.yaml@35
PS1, Line 35: apiVersion: apps/v1beta1
Can we use apps/v1?
http://gerrit.cloudera.org:8080/#/c/13407/1/kubernetes/kudu-statefulset.yaml@69
PS1, Line 69: value: "kudu-master-0.kudu-masters.default.svc.cluster.local,kudu-master-1.kudu-masters.default.svc.cluster.local,kudu-master-2.kudu-masters.default.svc.cluster.local"
Is there a way for this to be generated? For example if someone wanted 1 or 5 masters and didn't update this.
http://gerrit.cloudera.org:8080/#/c/13407/1/kubernetes/kudu-statefulset.yaml@122
PS1, Line 122: apiVersion: apps/v1beta1
Can we use apps/v1?
http://gerrit.cloudera.org:8080/#/c/13407/1/kubernetes/kudu-statefulset.yaml@156
PS1, Line 156: value: "kudu-master-0.kudu-masters.default.svc.cluster.local,kudu-master-1.kudu-masters.default.svc.cluster.local,kudu-master-2.kudu-masters.default.svc.cluster.local"
Same question as above about this being generated.
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 1
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 23 May 2019 14:07:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifesto
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13407
to look at the new patch set (#2).
Change subject: KUDU-2398: Kudu kubernetes statefulset manifesto
......................................................................
KUDU-2398: Kudu kubernetes statefulset manifesto
it builds kuberenetes staefulset kudu cluster, statefulset manages the deployment and sclaing of kudu server pods,
example of launcing kubernetes kudu cluster : kubectl create -f kudu-statefulset.yaml
to destroy: kubectl delete -f kudu-statefulset.yaml
scale: kubectl scale statefulset kudu-tserver --replicas=5
Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
---
A kubernetes/kudu-statefulset.yaml
1 file changed, 216 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/13407/2
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 2
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifest
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13407
to look at the new patch set (#8).
Change subject: KUDU-2398: Kudu kubernetes statefulset manifest
......................................................................
KUDU-2398: Kudu kubernetes statefulset manifest
it builds kubernetes statefulset kudu cluster, statefulset manages the
deployment and scaling of kudu server pods.
creating kubernetes kudu cluster: kubectl create -f kudu-statefulset.yaml
to destroy: kubectl delete -f kudu-statefulset.yaml
scale: kubectl scale statefulset kudu-tserver --replicas=5
Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
---
A kubernetes/kudu-statefulset.yaml
1 file changed, 212 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/13407/8
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 8
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifesto
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13407 )
Change subject: KUDU-2398: Kudu kubernetes statefulset manifesto
......................................................................
Patch Set 5:
(6 comments)
Just passing through and wanted to call out a few typos.
http://gerrit.cloudera.org:8080/#/c/13407/5//COMMIT_MSG
Commit Message:
PS5:
Please wrap the lines in the commit message to 80 chars or less.
http://gerrit.cloudera.org:8080/#/c/13407/5//COMMIT_MSG@7
PS5, Line 7: manifesto
manifest (I think that's what you meant)
http://gerrit.cloudera.org:8080/#/c/13407/5//COMMIT_MSG@9
PS5, Line 9: kuberenetes
kubernetes
http://gerrit.cloudera.org:8080/#/c/13407/5//COMMIT_MSG@9
PS5, Line 9: sclaing
scaling
http://gerrit.cloudera.org:8080/#/c/13407/5//COMMIT_MSG@10
PS5, Line 10: launcing
launching
http://gerrit.cloudera.org:8080/#/c/13407/5/kubernetes/kudu-statefulset.yaml
File kubernetes/kudu-statefulset.yaml:
http://gerrit.cloudera.org:8080/#/c/13407/5/kubernetes/kudu-statefulset.yaml@41
PS5, Line 41: master's
masters
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 5
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Wed, 29 May 2019 22:03:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifesto
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13407 )
Change subject: KUDU-2398: Kudu kubernetes statefulset manifesto
......................................................................
Patch Set 3:
(3 comments)
Just a few small requests and this looks good to be committed as a starting point. I will follow up with a documentation patch that adds a readme.
http://gerrit.cloudera.org:8080/#/c/13407/3/docker/kudu-entrypoint.sh
File docker/kudu-entrypoint.sh:
http://gerrit.cloudera.org:8080/#/c/13407/3/docker/kudu-entrypoint.sh@56
PS3, Line 56: # TODO: Remove use_hybrid_clock=false when ntpd is setup.
Just as an FYI, this TODO is important for production environments. I will open a few docker related jiras to track this stuff.
http://gerrit.cloudera.org:8080/#/c/13407/3/docker/kudu-entrypoint.sh@86
PS3, Line 86: function get_k8s_kudu_masters() {
I think I prefer hard coding in the manifest as opposed to putting K8s stuff in the entrypoint. Thanks for trying to solve my request though. Mind reverting?
http://gerrit.cloudera.org:8080/#/c/13407/3/kubernetes/kudu-statefulset.yaml
File kubernetes/kudu-statefulset.yaml:
http://gerrit.cloudera.org:8080/#/c/13407/3/kubernetes/kudu-statefulset.yaml@18
PS3, Line 18: # This docker file defines a multistage build that supports creating
I think this docker line is a copy paste error.
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 3
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Wed, 29 May 2019 14:01:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] kudu kubernetes statefulset manifesto
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13407 )
Change subject: kudu kubernetes statefulset manifesto
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13407/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13407/1//COMMIT_MSG@8
PS1, Line 8:
Do you mind adding more detailed description on what this manifesto allows to achieve and what's the use case it was designed for?
I think that a simplified example of how you would usually use this manifest is helpful as well.
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 1
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 23 May 2019 00:59:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifesto
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13407
to look at the new patch set (#4).
Change subject: KUDU-2398: Kudu kubernetes statefulset manifesto
......................................................................
KUDU-2398: Kudu kubernetes statefulset manifesto
it builds kuberenetes staefulset kudu cluster, statefulset manages the deployment and sclaing of kudu server pods,
example of launcing kubernetes kudu cluster : kubectl create -f kudu-statefulset.yaml
to destroy: kubectl delete -f kudu-statefulset.yaml
scale: kubectl scale statefulset kudu-tserver --replicas=5
Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
---
D docker/kudu-entrypoint.sh
A kubernetes/kudu-statefulset.yaml
2 files changed, 212 insertions(+), 116 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/13407/4
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 4
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifest
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13407 )
Change subject: KUDU-2398: Kudu kubernetes statefulset manifest
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13407/6//COMMIT_MSG
Commit Message:
PS6:
I wrote:
> Please wrap the lines in the commit message to 80 chars or less.
What I meant was "for each line in the commit message that exceeds 80 characters, please push the excess characters to the next line, and so on."
See https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines for more information on how to format commit messages in a way that improves readability.
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 7
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Wed, 29 May 2019 22:58:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifest
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/13407 )
Change subject: KUDU-2398: Kudu kubernetes statefulset manifest
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13407/6//COMMIT_MSG
Commit Message:
PS6:
> Hmm, why did you remove the bulk of the old commit message? It had some use
in previous patch, you had mentioned to limit commit message top 80 chars.
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 7
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Wed, 29 May 2019 22:43:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifesto
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/13407 )
Change subject: KUDU-2398: Kudu kubernetes statefulset manifesto
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13407/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13407/1//COMMIT_MSG@8
PS1, Line 8:
> If you prefer, I would be happy to add a readme in a follow up commit.
@grant sure, please feel free to add readme file and i will update .yaml file changes.
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 2
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Thu, 23 May 2019 16:08:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifesto
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13407
to look at the new patch set (#5).
Change subject: KUDU-2398: Kudu kubernetes statefulset manifesto
......................................................................
KUDU-2398: Kudu kubernetes statefulset manifesto
it builds kuberenetes staefulset kudu cluster, statefulset manages the deployment and sclaing of kudu server pods,
example of launcing kubernetes kudu cluster : kubectl create -f kudu-statefulset.yaml
to destroy: kubectl delete -f kudu-statefulset.yaml
scale: kubectl scale statefulset kudu-tserver --replicas=5
Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
---
A kubernetes/kudu-statefulset.yaml
1 file changed, 212 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/13407/5
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 5
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifesto
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13407 )
Change subject: KUDU-2398: Kudu kubernetes statefulset manifesto
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13407/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13407/1//COMMIT_MSG@8
PS1, Line 8:
> Agee that it would be useful to provide a detailed description or example o
If you prefer, I would be happy to add a readme in a follow up commit.
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 2
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 23 May 2019 15:48:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifest
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13407 )
Change subject: KUDU-2398: Kudu kubernetes statefulset manifest
......................................................................
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13407/6//COMMIT_MSG
Commit Message:
PS6:
Hmm, why did you remove the bulk of the old commit message? It had some useful stuff in it.
http://gerrit.cloudera.org:8080/#/c/13407/6//COMMIT_MSG@9
PS6, Line 9: staefulset
Still got a typo here.
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 6
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Wed, 29 May 2019 22:14:45 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifest
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13407
to look at the new patch set (#6).
Change subject: KUDU-2398: Kudu kubernetes statefulset manifest
......................................................................
KUDU-2398: Kudu kubernetes statefulset manifest
it builds kubernetes staefulset kudu cluster
Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
---
A kubernetes/kudu-statefulset.yaml
1 file changed, 212 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/13407/6
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 6
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifesto
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13407
to look at the new patch set (#3).
Change subject: KUDU-2398: Kudu kubernetes statefulset manifesto
......................................................................
KUDU-2398: Kudu kubernetes statefulset manifesto
it builds kuberenetes staefulset kudu cluster, statefulset manages the deployment and sclaing of kudu server pods,
example of launcing kubernetes kudu cluster : kubectl create -f kudu-statefulset.yaml
to destroy: kubectl delete -f kudu-statefulset.yaml
scale: kubectl scale statefulset kudu-tserver --replicas=5
Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
---
M docker/kudu-entrypoint.sh
A kubernetes/kudu-statefulset.yaml
2 files changed, 229 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/13407/3
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 3
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifest
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13407 )
Change subject: KUDU-2398: Kudu kubernetes statefulset manifest
......................................................................
Patch Set 8: Code-Review+2
I think this is a good start. It will surely evolve. I will add a readme in a follow up.
--
To view, visit http://gerrit.cloudera.org:8080/13407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 8
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Fri, 31 May 2019 00:15:51 +0000
Gerrit-HasComments: No