You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/22 00:54:49 UTC

[GitHub] [airflow] jlazarevicm opened a new issue #8507: ZendeskHook call for Ticket Tags endpoint

jlazarevicm opened a new issue #8507:
URL: https://github.com/apache/airflow/issues/8507


   <!--
   
   Each zendesk call expects to have next_page in response:
           `next_page = results['next_page']`
   This is not true for endpoint like this:
   `https://{subdomain}.zendesk.com/api/v2/tickets/{ticket_id}/tags.json` 
   So I got error when I tried to call this error with zendesk call function.
   -->
   
   <!--
   
   IMPORTANT!!!
   
   Please complete the next sections or the issue will be closed.
   This questions are the first thing we need to know to understand the context.
   
   -->
   
   **Apache Airflow version**: 1.10.3
   
   **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): -
   
   **Environment**: local
   
   - **Cloud provider or hardware configuration**: 2.5Ghz Intel Core i7, 16GB
   - **OS** (e.g. from /etc/os-release): macOS Mojave
   - **Kernel** (e.g. `uname -a`):
   - **Install tools**:
   - **Others**:
   
   **What happened**:
   
   <!-- 
     File "workspace/lumos_airflow/dags/extensions/hooks/lumos_zendesk_hook.py"
       response = self.call(end_point)
     File "workspace/lumos_airflow/venv/lib/python3.5/site-packages/airflow/hooks/zendesk_hook.py", line 79, in call
       next_page = results['next_page']
   KeyError: 'next_page'
    -->
   
   **What you expected to happen**:
   
   <!-- What do you think went wrong? -->
   
   **How to reproduce it**:
   <!---
   
   Invoke call function for zendesk ticket comments endpoint. 
   
   ## Install minikube/kind
   
   - Minikube https://minikube.sigs.k8s.io/docs/start/
   - Kind https://kind.sigs.k8s.io/docs/user/quick-start/
   
   If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
   
   You can include images using the .md sytle of
   ![alt text](http://url/to/img.png)
   
   To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
   
   --->
   
   
   **Anything else we need to know**:
   
   <!--
   Every time .
   
   Any relevant logs to include? Put them here in side a detail tag:
   <details><summary>x.log</summary> lots of stuff </details>
   
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jlazarevicm commented on issue #8507: ZendeskHook call for Ticket Tags endpoint

Posted by GitBox <gi...@apache.org>.
jlazarevicm commented on issue #8507:
URL: https://github.com/apache/airflow/issues/8507#issuecomment-623627672


   @jeffolsi I think you are not right. Event though if we set `get_all_pages=False` it doesn't change the fact that this line (prior than checking if `get_all_pages` is set to `False`): https://github.com/apache/airflow/blob/caa60b1141ac02cdde1c33464be9adca114c2ed5/airflow/providers/zendesk/hooks/zendesk.py#L81
   expects result to have `next_page`. You should probably change it to: `results.get('next_page')`  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jeffolsi commented on issue #8507: ZendeskHook call for Ticket Tags endpoint

Posted by GitBox <gi...@apache.org>.
jeffolsi commented on issue #8507:
URL: https://github.com/apache/airflow/issues/8507#issuecomment-619832181


   This is not a bug
   You need to set `get_all_pages=False`
   https://github.com/apache/airflow/blob/master/airflow/providers/zendesk/hooks/zendesk.py#L60
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jlazarevicm edited a comment on issue #8507: ZendeskHook call for Ticket Tags endpoint

Posted by GitBox <gi...@apache.org>.
jlazarevicm edited a comment on issue #8507:
URL: https://github.com/apache/airflow/issues/8507#issuecomment-623627672


   @potiuk, @jeffolsi I think you are not right. Event though if we set `get_all_pages=False` it doesn't change the fact that this line (prior than checking if `get_all_pages` is set to `False`): https://github.com/apache/airflow/blob/caa60b1141ac02cdde1c33464be9adca114c2ed5/airflow/providers/zendesk/hooks/zendesk.py#L81
   expects `result` to have `next_page`. You should probably change it to: `results.get('next_page')`  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jlazarevicm edited a comment on issue #8507: ZendeskHook call for Ticket Tags endpoint

Posted by GitBox <gi...@apache.org>.
jlazarevicm edited a comment on issue #8507:
URL: https://github.com/apache/airflow/issues/8507#issuecomment-623627672


   @potiuk, @jeffolsi I think you are not right. Event though if we set `get_all_pages=False` it doesn't change the fact that this line (prior than checking if `get_all_pages` is set to `False`): https://github.com/apache/airflow/blob/caa60b1141ac02cdde1c33464be9adca114c2ed5/airflow/providers/zendesk/hooks/zendesk.py#L81
   expects result to have `next_page`. You should probably change it to: `results.get('next_page')`  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8507: ZendeskHook call for Ticket Tags endpoint

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #8507:
URL: https://github.com/apache/airflow/issues/8507#issuecomment-617485324


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #8507: ZendeskHook call for Ticket Tags endpoint

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8507:
URL: https://github.com/apache/airflow/issues/8507#issuecomment-619853877


   Closing as it is invalid as explained by @jeffolsi  (thanks!)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org