You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "pivotal-jbarrett (GitHub)" <gi...@apache.org> on 2018/11/28 19:10:05 UTC
[GitHub] [geode] pivotal-jbarrett opened pull request #2911:
GEODE-6101: Builds module for consumption by Java 9+ modules project.
- Produces a merged jar with contents from
geode-common
geode-json
geode-core
geode-cq
- Module uses automatic naming for name org.apache.geode
Co-authored-by: Jacob Barrett <jb...@pivotal.io>
Co-authored-by: Owen Nichols <on...@pivotal.io>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2911 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-jbarrett closed pull request #2911:
GEODE-6101: Builds module for consumption by Java 9+ modules project.
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode/pull/2911 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] metatype commented on issue #2911: GEODE-6101:
Builds module for consumption by Java 9+ modules project.
Posted by "metatype (GitHub)" <gi...@apache.org>.
Are you planning to merge this PR? I think the jar version changes are fine (good!) but I'd rather not merge the `geode-module` stuff until you've finished exploring the other approaches you identified and we get consensus that this approach is the right one.
[ Full content available at: https://github.com/apache/geode/pull/2911 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-jbarrett commented on issue #2911:
GEODE-6101: Builds module for consumption by Java 9+ modules project.
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
@metatype what is the harm in merging a solution? I see it as a way to give others the ability to experiment and provide feedback.
[ Full content available at: https://github.com/apache/geode/pull/2911 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-jbarrett commented on issue #2911:
GEODE-6101: Builds module for consumption by Java 9+ modules project.
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Closing for #2915
[ Full content available at: https://github.com/apache/geode/pull/2911 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-jbarrett commented on issue #2911:
GEODE-6101: Builds module for consumption by Java 9+ modules project.
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
See https://github.com/pivotal-jbarrett/geode-example-java-11 as an example application using this module. This is an iterative work in progress.
[ Full content available at: https://github.com/apache/geode/pull/2911 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org