You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/20 05:02:22 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24637:
[SPARK-27707][SQL] Prune unnecessary nested fields from Generate to address
performance issue in explode
dongjoon-hyun commented on a change in pull request #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate to address performance issue in explode
URL: https://github.com/apache/spark/pull/24637#discussion_r285429248
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##########
@@ -32,9 +32,7 @@ object NestedColumnAliasing {
def unapply(plan: LogicalPlan)
: Option[(Map[GetStructField, Alias], Map[ExprId, Seq[Alias]])] = plan match {
- case Project(projectList, child)
- if SQLConf.get.nestedSchemaPruningEnabled && canProjectPushThrough(child) =>
- getAliasSubMap(projectList)
+ case Project(projectList, child) => getAliasSubMap(projectList)
Review comment:
@viirya . Sorry, but this is a regression on all the existing code. We should avoid `getAliasSubMap` invocation. https://github.com/apache/spark/pull/24637/files#diff-a636a87d8843eeccca90140be91d4fafR635 doesn't prevent `getAliasSubMap` invocation inside `unapply`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org