You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "RussellSpitzer (via GitHub)" <gi...@apache.org> on 2024/11/04 19:22:53 UTC
[I] Flink: TestMetadataTableReadableMetrics relies on Hardcoded File Sizes [iceberg]
RussellSpitzer opened a new issue, #11465:
URL: https://github.com/apache/iceberg/issues/11465
### Feature Request / Improvement
TestMetadataTableReadableMetrics currently hardcodes in the expected size into the metrics rows rather than actually checking the sizes from the underlying data. This means every time the Parquet version changes (or compression or what not) the test needs to be updated. See
https://github.com/apache/iceberg/commit/b8c2b20237bc9309d34dc96c473e9941d1b2ad58
Ideally we would change this so the expected values we check are only those which are not dependent on parquet version or change the test to check against the actual values.
See https://github.com/apache/iceberg/pull/11462 for an instance where this is complicating things
### Query engine
None
### Willingness to contribute
- [ ] I can contribute this improvement/feature independently
- [ ] I would be willing to contribute this improvement/feature with guidance from the Iceberg community
- [ ] I cannot contribute this improvement/feature at this time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Flink: TestMetadataTableReadableMetrics relies on Hardcoded File Sizes [iceberg]
Posted by "davidyuan1223 (via GitHub)" <gi...@apache.org>.
davidyuan1223 commented on issue #11465:
URL: https://github.com/apache/iceberg/issues/11465#issuecomment-2456694669
can we use the sql `select column_sizes from table.files` to get the reight size?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Flink: TestMetadataTableReadableMetrics relies on Hardcoded File Sizes [iceberg]
Posted by "davidyuan1223 (via GitHub)" <gi...@apache.org>.
davidyuan1223 commented on issue #11465:
URL: https://github.com/apache/iceberg/issues/11465#issuecomment-2456889163
> > can we use the sql `select column_sizes from table.files` to get the right size?
>
> I would prefer @RussellSpitzer's suggestion to directly check the parquet file sizes. Otherwise we might end up using the same abstraction to get the expected data and the test data.
Maybe your are right, i have some question about this link [https://iceberg.apache.org/docs/1.6.0/spark-queries/?h=readable_metrics#files](https://iceberg.apache.org/docs/1.6.0/spark-queries/?h=readable_metrics#files). At the tag Inspecting tables -- Files, the SQL `SELECT * FROM prod.db.table.files;` , the result show the parquet file maybe contains multiple column, if we get the file size, how do we know the column level size?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Flink: TestMetadataTableReadableMetrics relies on Hardcoded File Sizes [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #11465: Flink: TestMetadataTableReadableMetrics relies on Hardcoded File Sizes
URL: https://github.com/apache/iceberg/issues/11465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Flink: TestMetadataTableReadableMetrics relies on Hardcoded File Sizes [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #11465:
URL: https://github.com/apache/iceberg/issues/11465#issuecomment-2953283492
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Flink: TestMetadataTableReadableMetrics relies on Hardcoded File Sizes [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on issue #11465:
URL: https://github.com/apache/iceberg/issues/11465#issuecomment-2456782288
> can we use the sql `select column_sizes from table.files` to get the right size?
I would prefer @RussellSpitzer's suggestion to directly check the parquet file sizes. Otherwise we might end up using the same abstraction to get the expected data and the test data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Flink: TestMetadataTableReadableMetrics relies on Hardcoded File Sizes [iceberg]
Posted by "ajreid21 (via GitHub)" <gi...@apache.org>.
ajreid21 commented on issue #11465:
URL: https://github.com/apache/iceberg/issues/11465#issuecomment-2529437365
This was fixed/updated with: https://github.com/apache/iceberg/pull/11502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Flink: TestMetadataTableReadableMetrics relies on Hardcoded File Sizes [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #11465:
URL: https://github.com/apache/iceberg/issues/11465#issuecomment-2993835621
This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org