You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/10/29 00:10:00 UTC
[jira] [Commented] (SOLR-13783) NamedList.toString() ought to be
consistent with AbstractMap
[ https://issues.apache.org/jira/browse/SOLR-13783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961569#comment-16961569 ]
ASF subversion and git services commented on SOLR-13783:
--------------------------------------------------------
Commit 74333c3af2b71c90098f9e746b839b15d4d14038 in lucene-solr's branch refs/heads/master from Chris Hennick
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=74333c3 ]
SOLR-13783: Add space after comma in NamedList.toString() (#979)
> NamedList.toString() ought to be consistent with AbstractMap
> ------------------------------------------------------------
>
> Key: SOLR-13783
> URL: https://issues.apache.org/jira/browse/SOLR-13783
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Priority: Minor
> Labels: newdev
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> NamedList.toString() does not put a space after the joining commas, whereas AbstractMap does. I think it ought to be consistent. This can matter if you write tests that toString() a piece of a SolrResponse that varies in its use of EmbeddedSolrServer versus other SolrClients that serialize the response. Some custom SearchComponents or whatever might prefer to use a Map and that should ultimately be consistent. I know the assumption is a little brittle but still.
> I think 9.0 without a back-port is safe.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org