You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2018/12/06 16:11:50 UTC

[Bug 7665] New: Optimize extract of body rules during sa-compile

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7665

            Bug ID: 7665
           Summary: Optimize extract of body rules during sa-compile
           Product: Spamassassin
           Version: 3.4.2
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: sa-compile
          Assignee: dev@spamassassin.apache.org
          Reporter: nicolas.rochelemagne@cpanel.net
  Target Milestone: Undefined

Created attachment 5634
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5634&action=edit
Patch for Mail::SpamAssassin::Plugin::BodyRuleBaseExtractor

This is an improvement in BodyRuleBaseExtractor module to extract rules.

can be read online at https://github.com/atoomic/Mail-SpamAssassin/pull/1

Note: I also provided a GitHub pull request to my personal git repo, so it's
easier to comment on any part if you have any questions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7665] Optimize extract of body rules during sa-compile

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7665

J. Nick Koston <ni...@cpanel.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick@cpanel.net

--- Comment #3 from J. Nick Koston <ni...@cpanel.net> ---
Before Patch

Base extraction time: 183s

After Patch

Base extraction time: 21s

This is with ~5300 bases

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7665] Optimize extract of body rules during sa-compile

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7665

Kevin A. McGrail <km...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Kevin A. McGrail <km...@apache.org> ---
Sending        3.4/lib/Mail/SpamAssassin/Plugin/BodyRuleBaseExtractor.pm
Sending        trunk/lib/Mail/SpamAssassin/Plugin/BodyRuleBaseExtractor.pm
Transmitting file data ..
Committed revision 1848970.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7665] Optimize extract of body rules during sa-compile

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7665

Kevin A. McGrail <km...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@apache.org

--- Comment #5 from Kevin A. McGrail <km...@apache.org> ---
Nice.  Working on building this into 3.4.3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7665] Optimize extract of body rules during sa-compile

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7665

--- Comment #4 from Nicolas R. <ni...@cpanel.net> ---
I've updated the results from the benchmark test with some more accurate values
but Nick comment is probably more accurate about the performance win there as
this was using some production data.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7665] Optimize extract of body rules during sa-compile

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7665

Henrik Krohns <he...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hege@hege.li

--- Comment #1 from Henrik Krohns <he...@hege.li> ---
Is this purely speed optimization? Could you provide benchmarks to show the
change?

-- 
You are receiving this mail because:
You are the assignee for the bug.