[GitHub] [accumulo] ctubbsii commented on a change in pull request #2499: Move Test jars and update their ITs

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2499:
URL: https://github.com/apache/accumulo/pull/2499#discussion_r807293314



##########
File path: test/src/main/java/org/apache/accumulo/test/ShellServerIT.java
##########
@@ -2115,9 +2099,8 @@ private void setupRealContextPath() throws IOException {
   private void setupFakeContextPath() throws IOException {
     // Copy the test iterators jar to tmp
     Path baseDir = new Path(System.getProperty("user.dir"));
-    Path targetDir = new Path(baseDir, "target");
-    Path classesDir = new Path(targetDir, "classes");
-    Path jarPath = new Path(classesDir, "ShellServerIT-iterators.jar");
+    Path jarPath = new Path(baseDir + "/src/main/resources/org/apache/accumulo/test",
+        "ShellServerIT-iterators.jar");

Review comment:
       Since resources are copied to `target/classes/`, you could also do:
   
   ```suggestion
       Path jarPath = new Path(baseDir + "/target/classes/org/apache/accumulo/test",
           "ShellServerIT-iterators.jar");
   ```
   
   However, I'm wondering if this should be in a different directory entirely, instead of `src/main/resources/`, since it does not appear to be needed inside the test jar itself. The same is true for any others... if they're not strictly needed inside the test jar, it's probably fine to take them out of `src/main/resources` and put them in a directory like `src/main/testjars` that won't get bundled into the built jar.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org