You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by vi...@apache.org on 2020/01/03 05:44:40 UTC

[incubator-superset] branch master updated: [Fix], Correct read in Jinja configuration and update docs of SupersetAppInitializer (#8908)

This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 1dbf17b  [Fix],Correct read in Jinja configuration and update docs of SupersetAppInitializer (#8908)
1dbf17b is described below

commit 1dbf17bebb4bce0ff960612d1a67ea312e8d5583
Author: zuodong <48...@users.noreply.github.com>
AuthorDate: Fri Jan 3 13:44:25 2020 +0800

    [Fix],Correct read in Jinja configuration and update docs of SupersetAppInitializer (#8908)
---
 superset/app.py        | 4 ++--
 superset/extensions.py | 4 +---
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/superset/app.py b/superset/app.py
index a037e64..e69377c 100644
--- a/superset/app.py
+++ b/superset/app.py
@@ -81,7 +81,7 @@ class SupersetAppInitializer:
 
     def pre_init(self) -> None:
         """
-        Called after all other init tasks are complete
+        Called before all other init tasks are complete
         """
         wtforms_json.init()
 
@@ -90,7 +90,7 @@ class SupersetAppInitializer:
 
     def post_init(self) -> None:
         """
-        Called before any other init tasks
+        Called after any other init tasks
         """
         pass
 
diff --git a/superset/extensions.py b/superset/extensions.py
index 4cff3b4..3e3d4e8 100644
--- a/superset/extensions.py
+++ b/superset/extensions.py
@@ -44,9 +44,7 @@ class JinjaContextManager:
         }
 
     def init_app(self, app):
-        self._base_context = self._base_context.update(
-            app.config["JINJA_CONTEXT_ADDONS"]
-        )
+        self._base_context.update(app.config["JINJA_CONTEXT_ADDONS"])
 
     @property
     def base_context(self):