You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2003/02/25 01:54:17 UTC

DO NOT REPLY [Bug 17353] New: - java code created by jspc uses flushBuffer() instead of flush()

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17353>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17353

java code created by jspc uses flushBuffer() instead of flush()

           Summary: java code created by jspc uses flushBuffer() instead of
                    flush()
           Product: Tomcat 3
           Version: 3.3.1 Final
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Minor
          Priority: Other
         Component: Jasper
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: welsh@cisco.com


Version jakarta-tomcat-3.3.1a

PROBLEM
When compiling jsp code, the generated java code uses flushBuffer(), but Method 
flushBuffer() has protected access in org.apache.jasper.runtime.JspWriterImpl

Some of the news articles recommend using flush() instead of flushBuffer()

Typical Output from jspc....
finally {
  if (out instanceof org.apache.jasper.runtime.JspWriterImpl) {
    ((org.apache.jasper.runtime.JspWriterImpl)out).flushBuffer();
  }
  if (_jspxFactory != null) _jspxFactory.releasePageContext(pageContext);
  }

FIX
Edit org.apache.jasper.runtime.JspWriterImpl
change line 382 from:
  writer.println("    ((" +
    Constants.JSP_RUNTIME_PACKAGE +
    ".JspWriterImpl)out).flushBuffer();");

change line 38 to:
  writer.println("    ((" +
    Constants.JSP_RUNTIME_PACKAGE +
    ".JspWriterImpl)out).flush();");

then rebuild jasper.jar

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org