You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2026/09/21 06:29:32 UTC
[PR] Support parenthesized WITH queries and qualified PL/SQL collection types in Oracle parser [shardingsphere]
FlyingZC opened a new pull request, #39914:
URL: https://github.com/apache/shardingsphere/pull/39914
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support parenthesized WITH queries and qualified PL/SQL collection types in Oracle parser [shardingsphere]
Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC commented on PR #39914:
URL: https://github.com/apache/shardingsphere/pull/39914#issuecomment-5758446666
### Result
**Review Result: Mergeable**
最新 HEAD 已修复上一轮两个边界问题,未发现新的代码正确性阻塞项。
### Evidence
- `OracleDMLStatementVisitor.java:773-778` 在外层 `ORDER BY` 重建后保留 parameter markers、variables 和 comments;对应 bind marker 测试已覆盖。
- `PLSQL.g4:581-594` 将 `%TYPE` 恢复为原有 `typeName` 路径,三段式名称仅用于普通集合类型。
- `OracleDDLStatementVisitor.java:2383-2389` 正确区分直接 `typeName` 与集合类型中的嵌套 `typeName`。
- Oracle Visitor `3/3`、Parser IT `1966/1966`、Rewrite IT `1019/1019` 均通过。
### Coverage
- Reviewed head:`1c7d3605e5f673b69850dc1f21d513122418ddf6`
- Base:`master` at `1bcf1101ad8bef3059674a463b740bda562887ee`
- GitHub 与本地 triple-dot 文件清单一致,共 9 个文件。
- 已完整审查 parenthesized WITH 与 qualified PL/SQL collection type 两个行为集群,以及最新 4 文件修复增量。
- 已覆盖 grammar、visitor、参数状态、元数据提取、兼容性、测试及 parser 内存风险。
- 本次为 Code Correctness Review;未查询或评价 CI。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support parenthesized WITH queries and qualified PL/SQL collection types in Oracle parser [shardingsphere]
Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC commented on PR #39914:
URL: https://github.com/apache/shardingsphere/pull/39914#issuecomment-5758455668
### Result
**Review Result: Mergeable**
The latest HEAD resolves both previously identified edge cases. No new code-correctness blockers were found.
### Evidence
- `OracleDMLStatementVisitor.java:773-778` preserves parameter markers, variables, and comments after rebuilding the statement for an outer `ORDER BY`; a focused
bind-marker test covers this behavior.
- `PLSQL.g4:581-594` restores `%TYPE` to the original `typeName` path and limits three-part names to ordinary collection types.
- `OracleDDLStatementVisitor.java:2383-2389` correctly distinguishes a direct `typeName` from the nested `typeName` in a collection type.
- Oracle Visitor tests `3/3`, Parser IT `1966/1966`, and Rewrite IT `1019/1019` all passed.
### Coverage
- Reviewed head: `1c7d3605e5f673b69850dc1f21d513122418ddf6`
- Base: `master` at `1bcf1101ad8bef3059674a463b740bda562887ee`
- The GitHub and local triple-dot file lists match, covering nine files.
- Reviewed both behavior clusters—parenthesized `WITH` queries and qualified PL/SQL collection types—including the latest four-file fix delta.
- Covered grammar, visitor behavior, parameter state, metadata extraction, compatibility, tests, and parser memory risks.
- This was a Code Correctness Review; CI was not queried or evaluated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support parenthesized WITH queries and qualified PL/SQL collection types in Oracle parser [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #39914:
URL: https://github.com/apache/shardingsphere/pull/39914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org