You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "lunda1 (GitHub)" <gi...@apache.org> on 2018/11/29 08:45:42 UTC

[GitHub] [incubator-dubbo] lunda1 opened pull request #2849: fix stub bug in multi registries

## What is the purpose of the change

api启动consumer时,如果配置了多个registry,stub参数无法获取到,进而导致stub逻辑无法执行,根本原因在于构造StaticDirectory时传递的url参数的refer参数并没有解析为map并添加到parameters中导致。

## Brief changelog

由于RegistryProtocol在refer方法中已经将refer参数解析为了map,所以改为直接获取返回的invoker的url对象即可,而不是原始的urls变量中的值。

## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2849 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 commented on issue #2849: [Dubbo-2850] Fix consumer stub bug in multi registries

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
@lunda1, I submit a pull request #2887 to fix this issue with an alternative solution. Would you mind to take a look?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2849 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] beiwei30 closed pull request #2849: [Dubbo-2850] Fix consumer stub bug in multi registries

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2849 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org