You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Oleg Ignatenko (JIRA)" <ji...@apache.org> on 2018/09/25 13:34:00 UTC

[jira] [Assigned] (IGNITE-9691) AuthenticationProcessorNodeRestartTest.testConcurrentAuthorize uses outdated assumption about exception message

     [ https://issues.apache.org/jira/browse/IGNITE-9691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Ignatenko reassigned IGNITE-9691:
--------------------------------------

    Assignee: Oleg Ignatenko

> AuthenticationProcessorNodeRestartTest.testConcurrentAuthorize uses outdated assumption about exception message
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-9691
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9691
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.6
>            Reporter: Oleg Ignatenko
>            Assignee: Oleg Ignatenko
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>             Fix For: 2.7
>
>
> Test {{AuthenticationProcessorNodeRestartTest.testConcurrentAuthorize}} that was introduced per IGNITE-7436 uses particular assumption about exception message thrown from method [GridIoManager.send|https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java]:
> {code}
>                     // Skip exception if server down.
>                     if (!e.getMessage().contains("Failed to send message (node may have left the grid or "
>                         + "TCP connection cannot be established due to firewall issues)")) {
>                         e.printStackTrace();
>                         fail("Unexpected exception: " + e.getMessage());
>                     }
>                     // ...{code}
> This expectation appears to be broken by changes introduced per IGNITE-4191 which added yet another exception message that may occur in above piece of test code:
> {code}
>                 if (!ctx.discovery().alive(node))
>                     throw new ClusterTopologyCheckedException("Failed to send message, node left: " + node.id(), e);{code}
> (above code was added at line 1664 in {{GridIoManager.java}})
> Regression wasn't immediately discovered because of indeterministic test scenario which made new failures appear randomly and mixed with passes when particular condition was missed in the course of test execution.
> Test needs to be updated to accommodate the changes in codebase.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)