You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by anilkumar gingade <ag...@pivotal.io> on 2015/08/11 22:27:03 UTC

Re: Review Request 36484: GEODE-105: Null value in Map causes NPE with Map Indexes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36484/#review94993
-----------------------------------------------------------



gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/MapRangeIndexMaintenanceJUnitTest.java (line 335)
<https://reviews.apache.org/r/36484/#comment149742>

    Reset after test?


- anilkumar gingade


On July 24, 2015, 7:16 p.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36484/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 7:16 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Jianxia Chen, Lynn Gallinat, and Qihong Chen.
> 
> 
> Bugs: GEODE-105
>     https://issues.apache.org/jira/browse/GEODE-105
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> We now handle non map objects isntead of throwing assertion errors.  We just ignore and do not try to index them for map indexes.
> Convert null to NULL tokens when saving to the map indexes
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/AbstractMapIndex.java 599e648 
>   gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/CompactMapRangeIndex.java 299ca4f 
>   gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/MapRangeIndexMaintenanceJUnitTest.java c339ec9 
> 
> Diff: https://reviews.apache.org/r/36484/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>