[jira] Commented: (AXIS2-3843) httpFrontendHostUrl does not affect auto-generated WSDL

["Dobri Kitipov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AXIS2-3843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732502#action_12732502 ] 

Dobri Kitipov commented on AXIS2-3843:
--------------------------------------

Hi Andreas,
I would like to share some thoughts about the current fix we have. I have observed the code and it seems to me that introducing new field for the TransportInDescription into the SimpleHTTPServer is redundant:

  private TransportInDescription trpInDesc;

If we have a closer look into the code we can see that when SimpleHTTPServer is initialized it always invokes its public SimpleHTTPServer(HttpFactory httpFactory) constructor. In it we have the following lines of code here (excerpt):

        TransportInDescription httpDescription =
                new TransportInDescription(Constants.TRANSPORT_HTTP);
        httpDescription.setReceiver(this);
        trpInDesc = httpDescription;
        httpFactory.getListenerManager().addListener(httpDescription, true);

In the end when ListenreManager#addListener(httpDescription, true); is invoked it sets the TransportIn Desc to the axis2 configuration object:

   configctx.getAxisConfiguration().addTransportIn(trsIn);

Here I am not 100% that this is correct, since it causes the replacement of the original http transportIn (if any at all) set into the axis2.xml. But I cannot  think of a use case that may really cause a problem. And AxisConfiguration object in fact is not a static representation of the axis2.xml. So let's say there is no problem. If you can think of any, please share it.

Let;s go back to the main topic. 
So at the end when HTTPTransportUtils#getEPRsForService method is invoked we can just retrieve the transportIn description calling:

  TransportInDescription trpInDescAxis = axisConfiguration.getTransportIn(Constants.TRANSPORT_HTTP);

In the end we get rid of all the redundant code we have if introducing with the new private TransportInDescription trpInDesc; field of the SimpleHTTPServer. 

If you think that this concept is ok I can commit the patches into the Axis2 trunk with my committer's account.

Thanks,
Dobri



> httpFrontendHostUrl does not affect auto-generated WSDL
> -------------------------------------------------------
>
>                 Key: AXIS2-3843
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3843
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: transports
>    Affects Versions: 1.4
>         Environment: Windows 2003 Server, Tomcat 6.0, Axis2 1.4
>            Reporter: Alexander Stockinger
>            Assignee: Andreas Veithen
>             Fix For: 1.6
>
>
> Setting the "httpFrontendHostUrl" parameter in the "axis2.conf" config file does not affect endpoint URL in auto-generated WSDL.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.