You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/10/30 09:27:53 UTC
Review Request 39809: LENS-719: Allow fact start time to be specified
for a storage and a update period
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39809/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-719
https://issues.apache.org/jira/browse/LENS-719
Repository: lens
Description
-------
We can specify absolute and relative start time for a fact. This improvement request is to add the ability to override the start time of a fact on a storage and a update period.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 2796cd9805e470923164ae3d7a96de7cdc94b920
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 9ea43bba0244555678499799edfba444822b73fd
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java f67fc260bf9b5964189df2a5e083bd40e8f90062
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd
Diff: https://reviews.apache.org/r/39809/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 39809: LENS-719: Allow fact start time to be
specified for a storage and a update period
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39809/#review104535
-----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java (line 1336)
<https://reviews.apache.org/r/39809/#comment162778>
Can you add assert for the storage table being skipped?
- Amareshwari Sriramadasu
On Oct. 30, 2015, 8:27 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39809/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2015, 8:27 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-719
> https://issues.apache.org/jira/browse/LENS-719
>
>
> Repository: lens
>
>
> Description
> -------
>
> We can specify absolute and relative start time for a fact. This improvement request is to add the ability to override the start time of a fact on a storage and a update period.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 2796cd9805e470923164ae3d7a96de7cdc94b920
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 9ea43bba0244555678499799edfba444822b73fd
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java f67fc260bf9b5964189df2a5e083bd40e8f90062
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd
>
> Diff: https://reviews.apache.org/r/39809/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 39809: LENS-719: Allow fact start time to be
specified for a storage and a update period
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39809/#review105366
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Nov. 2, 2015, 9:35 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39809/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 9:35 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-719
> https://issues.apache.org/jira/browse/LENS-719
>
>
> Repository: lens
>
>
> Description
> -------
>
> We can specify absolute and relative start time for a fact. This improvement request is to add the ability to override the start time of a fact on a storage and a update period.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 5d7630d8176a4a527a335dbceb12dee2bc0d51c8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 2796cd9805e470923164ae3d7a96de7cdc94b920
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 9ea43bba0244555678499799edfba444822b73fd
> lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 67932da900ebe8f92f1dbeb612ca2479b3f62a35
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java f67fc260bf9b5964189df2a5e083bd40e8f90062
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d7484d83dc0a3f7810ab2109ec882b19b940803b
>
> Diff: https://reviews.apache.org/r/39809/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.265s]
> [INFO] Lens .............................................. SUCCESS [3.315s]
> [INFO] Lens API .......................................... SUCCESS [27.409s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.902s]
> [INFO] Lens Cube ......................................... SUCCESS [5:15.658s]
> [INFO] Lens DB storage ................................... SUCCESS [28.398s]
> [INFO] Lens Query Library ................................ SUCCESS [20.105s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.316s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.869s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.170s]
> [INFO] Lens Server ....................................... SUCCESS [8:26.874s]
> [INFO] Lens client ....................................... SUCCESS [35.698s]
> [INFO] Lens CLI .......................................... SUCCESS [54.384s]
> [INFO] Lens Examples ..................................... SUCCESS [8.477s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.456s]
> [INFO] Lens Distribution ................................. SUCCESS [9.226s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:23.078s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.365s]
> [INFO] Lens Regression ................................... SUCCESS [15.631s]
> [INFO] Lens UI ........................................... SUCCESS [28.731s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:16.273s
> [INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015
> [INFO] Final Memory: 198M/2047M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 39809: LENS-719: Allow fact start time to be
specified for a storage and a update period
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39809/#review106554
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Nov. 12, 2015, 10:40 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39809/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 10:40 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-719
> https://issues.apache.org/jira/browse/LENS-719
>
>
> Repository: lens
>
>
> Description
> -------
>
> We can specify absolute and relative start time for a fact. This improvement request is to add the ability to override the start time of a fact on a storage and a update period.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 5d7630d8176a4a527a335dbceb12dee2bc0d51c8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 2796cd9805e470923164ae3d7a96de7cdc94b920
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 9ea43bba0244555678499799edfba444822b73fd
> lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 67932da900ebe8f92f1dbeb612ca2479b3f62a35
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java f67fc260bf9b5964189df2a5e083bd40e8f90062
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d7484d83dc0a3f7810ab2109ec882b19b940803b
>
> Diff: https://reviews.apache.org/r/39809/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.265s]
> [INFO] Lens .............................................. SUCCESS [3.315s]
> [INFO] Lens API .......................................... SUCCESS [27.409s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.902s]
> [INFO] Lens Cube ......................................... SUCCESS [5:15.658s]
> [INFO] Lens DB storage ................................... SUCCESS [28.398s]
> [INFO] Lens Query Library ................................ SUCCESS [20.105s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.316s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.869s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.170s]
> [INFO] Lens Server ....................................... SUCCESS [8:26.874s]
> [INFO] Lens client ....................................... SUCCESS [35.698s]
> [INFO] Lens CLI .......................................... SUCCESS [54.384s]
> [INFO] Lens Examples ..................................... SUCCESS [8.477s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.456s]
> [INFO] Lens Distribution ................................. SUCCESS [9.226s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:23.078s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.365s]
> [INFO] Lens Regression ................................... SUCCESS [15.631s]
> [INFO] Lens UI ........................................... SUCCESS [28.731s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:16.273s
> [INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015
> [INFO] Final Memory: 198M/2047M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 39809: LENS-719: Allow fact start time to be
specified for a storage and a update period
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39809/
-----------------------------------------------------------
(Updated Nov. 12, 2015, 4:10 p.m.)
Review request for lens.
Bugs: LENS-719
https://issues.apache.org/jira/browse/LENS-719
Repository: lens
Description
-------
We can specify absolute and relative start time for a fact. This improvement request is to add the ability to override the start time of a fact on a storage and a update period.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 5d7630d8176a4a527a335dbceb12dee2bc0d51c8
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 2796cd9805e470923164ae3d7a96de7cdc94b920
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 9ea43bba0244555678499799edfba444822b73fd
lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 67932da900ebe8f92f1dbeb612ca2479b3f62a35
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java f67fc260bf9b5964189df2a5e083bd40e8f90062
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d7484d83dc0a3f7810ab2109ec882b19b940803b
Diff: https://reviews.apache.org/r/39809/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.265s]
[INFO] Lens .............................................. SUCCESS [3.315s]
[INFO] Lens API .......................................... SUCCESS [27.409s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.902s]
[INFO] Lens Cube ......................................... SUCCESS [5:15.658s]
[INFO] Lens DB storage ................................... SUCCESS [28.398s]
[INFO] Lens Query Library ................................ SUCCESS [20.105s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.316s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.869s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [17.170s]
[INFO] Lens Server ....................................... SUCCESS [8:26.874s]
[INFO] Lens client ....................................... SUCCESS [35.698s]
[INFO] Lens CLI .......................................... SUCCESS [54.384s]
[INFO] Lens Examples ..................................... SUCCESS [8.477s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.456s]
[INFO] Lens Distribution ................................. SUCCESS [9.226s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:23.078s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.365s]
[INFO] Lens Regression ................................... SUCCESS [15.631s]
[INFO] Lens UI ........................................... SUCCESS [28.731s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23:16.273s
[INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015
[INFO] Final Memory: 198M/2047M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 39809: LENS-719: Allow fact start time to be
specified for a storage and a update period
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39809/
-----------------------------------------------------------
(Updated Nov. 2, 2015, 3:05 p.m.)
Review request for lens.
Bugs: LENS-719
https://issues.apache.org/jira/browse/LENS-719
Repository: lens
Description
-------
We can specify absolute and relative start time for a fact. This improvement request is to add the ability to override the start time of a fact on a storage and a update period.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 5d7630d8176a4a527a335dbceb12dee2bc0d51c8
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 2796cd9805e470923164ae3d7a96de7cdc94b920
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 9ea43bba0244555678499799edfba444822b73fd
lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 67932da900ebe8f92f1dbeb612ca2479b3f62a35
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java f67fc260bf9b5964189df2a5e083bd40e8f90062
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d7484d83dc0a3f7810ab2109ec882b19b940803b
Diff: https://reviews.apache.org/r/39809/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.265s]
[INFO] Lens .............................................. SUCCESS [3.315s]
[INFO] Lens API .......................................... SUCCESS [27.409s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.902s]
[INFO] Lens Cube ......................................... SUCCESS [5:15.658s]
[INFO] Lens DB storage ................................... SUCCESS [28.398s]
[INFO] Lens Query Library ................................ SUCCESS [20.105s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.316s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.869s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [17.170s]
[INFO] Lens Server ....................................... SUCCESS [8:26.874s]
[INFO] Lens client ....................................... SUCCESS [35.698s]
[INFO] Lens CLI .......................................... SUCCESS [54.384s]
[INFO] Lens Examples ..................................... SUCCESS [8.477s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.456s]
[INFO] Lens Distribution ................................. SUCCESS [9.226s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:23.078s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.365s]
[INFO] Lens Regression ................................... SUCCESS [15.631s]
[INFO] Lens UI ........................................... SUCCESS [28.731s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23:16.273s
[INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015
[INFO] Final Memory: 198M/2047M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 39809: LENS-719: Allow fact start time to be
specified for a storage and a update period
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39809/
-----------------------------------------------------------
(Updated Nov. 2, 2015, 1:48 p.m.)
Review request for lens.
Bugs: LENS-719
https://issues.apache.org/jira/browse/LENS-719
Repository: lens
Description
-------
We can specify absolute and relative start time for a fact. This improvement request is to add the ability to override the start time of a fact on a storage and a update period.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 5d7630d8176a4a527a335dbceb12dee2bc0d51c8
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 2796cd9805e470923164ae3d7a96de7cdc94b920
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 9ea43bba0244555678499799edfba444822b73fd
lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 67932da900ebe8f92f1dbeb612ca2479b3f62a35
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java f67fc260bf9b5964189df2a5e083bd40e8f90062
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d7484d83dc0a3f7810ab2109ec882b19b940803b
Diff: https://reviews.apache.org/r/39809/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.265s]
[INFO] Lens .............................................. SUCCESS [3.315s]
[INFO] Lens API .......................................... SUCCESS [27.409s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.902s]
[INFO] Lens Cube ......................................... SUCCESS [5:15.658s]
[INFO] Lens DB storage ................................... SUCCESS [28.398s]
[INFO] Lens Query Library ................................ SUCCESS [20.105s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.316s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.869s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [17.170s]
[INFO] Lens Server ....................................... SUCCESS [8:26.874s]
[INFO] Lens client ....................................... SUCCESS [35.698s]
[INFO] Lens CLI .......................................... SUCCESS [54.384s]
[INFO] Lens Examples ..................................... SUCCESS [8.477s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.456s]
[INFO] Lens Distribution ................................. SUCCESS [9.226s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:23.078s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.365s]
[INFO] Lens Regression ................................... SUCCESS [15.631s]
[INFO] Lens UI ........................................... SUCCESS [28.731s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23:16.273s
[INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015
[INFO] Final Memory: 198M/2047M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 39809: LENS-719: Allow fact start time to be
specified for a storage and a update period
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Oct. 30, 2015, 8:55 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java, line 66
> > <https://reviews.apache.org/r/39809/diff/2/?file=1113161#file1113161line66>
> >
> > What are these changes for?
Just simplifying the regular expression.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39809/#review104567
-----------------------------------------------------------
On Nov. 2, 2015, 1:48 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39809/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 1:48 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-719
> https://issues.apache.org/jira/browse/LENS-719
>
>
> Repository: lens
>
>
> Description
> -------
>
> We can specify absolute and relative start time for a fact. This improvement request is to add the ability to override the start time of a fact on a storage and a update period.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 5d7630d8176a4a527a335dbceb12dee2bc0d51c8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 2796cd9805e470923164ae3d7a96de7cdc94b920
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 9ea43bba0244555678499799edfba444822b73fd
> lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 67932da900ebe8f92f1dbeb612ca2479b3f62a35
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java f67fc260bf9b5964189df2a5e083bd40e8f90062
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d7484d83dc0a3f7810ab2109ec882b19b940803b
>
> Diff: https://reviews.apache.org/r/39809/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.265s]
> [INFO] Lens .............................................. SUCCESS [3.315s]
> [INFO] Lens API .......................................... SUCCESS [27.409s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.902s]
> [INFO] Lens Cube ......................................... SUCCESS [5:15.658s]
> [INFO] Lens DB storage ................................... SUCCESS [28.398s]
> [INFO] Lens Query Library ................................ SUCCESS [20.105s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.316s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.869s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.170s]
> [INFO] Lens Server ....................................... SUCCESS [8:26.874s]
> [INFO] Lens client ....................................... SUCCESS [35.698s]
> [INFO] Lens CLI .......................................... SUCCESS [54.384s]
> [INFO] Lens Examples ..................................... SUCCESS [8.477s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.456s]
> [INFO] Lens Distribution ................................. SUCCESS [9.226s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:23.078s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.365s]
> [INFO] Lens Regression ................................... SUCCESS [15.631s]
> [INFO] Lens UI ........................................... SUCCESS [28.731s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:16.273s
> [INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015
> [INFO] Final Memory: 198M/2047M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 39809: LENS-719: Allow fact start time to be
specified for a storage and a update period
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39809/#review104567
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java (lines 153 - 157)
<https://reviews.apache.org/r/39809/#comment162798>
Can you add new properties in cube xsd ?
lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java (line 66)
<https://reviews.apache.org/r/39809/#comment162797>
What are these changes for?
- Amareshwari Sriramadasu
On Oct. 30, 2015, 11:24 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39809/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2015, 11:24 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-719
> https://issues.apache.org/jira/browse/LENS-719
>
>
> Repository: lens
>
>
> Description
> -------
>
> We can specify absolute and relative start time for a fact. This improvement request is to add the ability to override the start time of a fact on a storage and a update period.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 2796cd9805e470923164ae3d7a96de7cdc94b920
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 9ea43bba0244555678499799edfba444822b73fd
> lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 67932da900ebe8f92f1dbeb612ca2479b3f62a35
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java f67fc260bf9b5964189df2a5e083bd40e8f90062
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d7484d83dc0a3f7810ab2109ec882b19b940803b
>
> Diff: https://reviews.apache.org/r/39809/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.265s]
> [INFO] Lens .............................................. SUCCESS [3.315s]
> [INFO] Lens API .......................................... SUCCESS [27.409s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.902s]
> [INFO] Lens Cube ......................................... SUCCESS [5:15.658s]
> [INFO] Lens DB storage ................................... SUCCESS [28.398s]
> [INFO] Lens Query Library ................................ SUCCESS [20.105s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.316s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.869s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.170s]
> [INFO] Lens Server ....................................... SUCCESS [8:26.874s]
> [INFO] Lens client ....................................... SUCCESS [35.698s]
> [INFO] Lens CLI .......................................... SUCCESS [54.384s]
> [INFO] Lens Examples ..................................... SUCCESS [8.477s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.456s]
> [INFO] Lens Distribution ................................. SUCCESS [9.226s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:23.078s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.365s]
> [INFO] Lens Regression ................................... SUCCESS [15.631s]
> [INFO] Lens UI ........................................... SUCCESS [28.731s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:16.273s
> [INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015
> [INFO] Final Memory: 198M/2047M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 39809: LENS-719: Allow fact start time to be
specified for a storage and a update period
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39809/#review104556
-----------------------------------------------------------
Chnages look ok.
+1
- Puneet Gupta
On Oct. 30, 2015, 11:24 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39809/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2015, 11:24 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-719
> https://issues.apache.org/jira/browse/LENS-719
>
>
> Repository: lens
>
>
> Description
> -------
>
> We can specify absolute and relative start time for a fact. This improvement request is to add the ability to override the start time of a fact on a storage and a update period.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 2796cd9805e470923164ae3d7a96de7cdc94b920
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 9ea43bba0244555678499799edfba444822b73fd
> lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 67932da900ebe8f92f1dbeb612ca2479b3f62a35
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java f67fc260bf9b5964189df2a5e083bd40e8f90062
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d7484d83dc0a3f7810ab2109ec882b19b940803b
>
> Diff: https://reviews.apache.org/r/39809/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.265s]
> [INFO] Lens .............................................. SUCCESS [3.315s]
> [INFO] Lens API .......................................... SUCCESS [27.409s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.902s]
> [INFO] Lens Cube ......................................... SUCCESS [5:15.658s]
> [INFO] Lens DB storage ................................... SUCCESS [28.398s]
> [INFO] Lens Query Library ................................ SUCCESS [20.105s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.316s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.869s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.170s]
> [INFO] Lens Server ....................................... SUCCESS [8:26.874s]
> [INFO] Lens client ....................................... SUCCESS [35.698s]
> [INFO] Lens CLI .......................................... SUCCESS [54.384s]
> [INFO] Lens Examples ..................................... SUCCESS [8.477s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.456s]
> [INFO] Lens Distribution ................................. SUCCESS [9.226s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:23.078s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.365s]
> [INFO] Lens Regression ................................... SUCCESS [15.631s]
> [INFO] Lens UI ........................................... SUCCESS [28.731s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:16.273s
> [INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015
> [INFO] Final Memory: 198M/2047M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 39809: LENS-719: Allow fact start time to be
specified for a storage and a update period
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39809/
-----------------------------------------------------------
(Updated Oct. 30, 2015, 4:54 p.m.)
Review request for lens.
Bugs: LENS-719
https://issues.apache.org/jira/browse/LENS-719
Repository: lens
Description
-------
We can specify absolute and relative start time for a fact. This improvement request is to add the ability to override the start time of a fact on a storage and a update period.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 2796cd9805e470923164ae3d7a96de7cdc94b920
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 9ea43bba0244555678499799edfba444822b73fd
lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 67932da900ebe8f92f1dbeb612ca2479b3f62a35
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java f67fc260bf9b5964189df2a5e083bd40e8f90062
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d7484d83dc0a3f7810ab2109ec882b19b940803b
Diff: https://reviews.apache.org/r/39809/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.265s]
[INFO] Lens .............................................. SUCCESS [3.315s]
[INFO] Lens API .......................................... SUCCESS [27.409s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.902s]
[INFO] Lens Cube ......................................... SUCCESS [5:15.658s]
[INFO] Lens DB storage ................................... SUCCESS [28.398s]
[INFO] Lens Query Library ................................ SUCCESS [20.105s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.316s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.869s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [17.170s]
[INFO] Lens Server ....................................... SUCCESS [8:26.874s]
[INFO] Lens client ....................................... SUCCESS [35.698s]
[INFO] Lens CLI .......................................... SUCCESS [54.384s]
[INFO] Lens Examples ..................................... SUCCESS [8.477s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.456s]
[INFO] Lens Distribution ................................. SUCCESS [9.226s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:23.078s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.365s]
[INFO] Lens Regression ................................... SUCCESS [15.631s]
[INFO] Lens UI ........................................... SUCCESS [28.731s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23:16.273s
[INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015
[INFO] Final Memory: 198M/2047M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal