[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336#discussion_r633083814



##########
File path: java/i18n/src/org/netbeans/modules/i18n/wizard/Util.java
##########
@@ -179,15 +179,9 @@ static boolean wizardEnabled(Node[] activatedNodes) {
                 FileObject primaryFile = dobj.getPrimaryFile();
                 
                 boolean isLocal;
-                try {
-                    isLocal = !primaryFile.isVirtual()
+                isLocal = !primaryFile.isVirtual()

Review comment:
       Seems to have lost some where (see other comments)

##########
File path: enterprise/web.freeform/src/org/netbeans/modules/web/freeform/WebModules.java
##########
@@ -193,11 +193,7 @@ private FileObject getFile (Element parent, String fileElName) {
         Set<FileObject> srcRootSet = new HashSet<FileObject>();
         for (int i = 0; i < sg.length; i++) {
             URL entry; 
-            try {
-                entry = sg[i].getRootFolder().getURL();
-            } catch (FileStateInvalidException x) {
-                throw new AssertionError(x);
-            }
+            entry = sg[i].getRootFolder().toURL();

Review comment:
       Looks still the same

##########
File path: enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/DDDataNode.java
##########
@@ -73,11 +73,7 @@ public String getShortDescription() {
         if (saxError == null) {
             if (dataObject instanceof DDFragmentDataObject) {
                 URL url = null;
-                try {
-                    url = dataObject.getPrimaryFile().getURL();
-                } catch (FileStateInvalidException ex) {
-                    // ignore
-                }
+                url = dataObject.getPrimaryFile().toURL();

Review comment:
       Looks still the same - could you please check whether the commit really made it? I'm looking at the changes from the github UI and lines 75+76 are still separate.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists